[WPB-18127] Update email templates to v1.0.155. - #5344
Conversation
battermann
left a comment
There was a problem hiding this comment.
Most templates are changed to English, that can't be right.
|
Given that we won't include unverified/unvalidated translations, we should drop them all along, to avoid selecting fr/it/... and end up with english e-mails. |
But don't we need some default? What do you want to display instead of English if there is no translation? |
|
I talked to @Astrid-Wire, here is the conclusion:
|
|
Ah, there are some legit test failures, i'll fix them and add tests for the new templates, get CI green, then it's time for a review. |
|
I looked into the testing situation: we're testing the email subsystem, not the templates, and I would like to extend the email subsystem in a separate PR. Then I can also move the tests from services/brig to libs/wire-subsystems, I think that's the only thing they (morally) depend on. |
(Unapproved) Translations are back, so please update this PR accordingly before merging. |
stefanwire
left a comment
There was a problem hiding this comment.
We cannot merge without the translations been put back.
|
replaced by #5399 |
|
#5399 closed, I'll do it here. (With yet another update from wire-emails.) |
d3e6700 to
0777f2c
Compare
Now this PR only contains the new app templates in German and English. |
https://wearezeta.atlassian.net/browse/WPB-18127
This PR is the result of following the instructions here.
Checklist
changelog.d