Skip to content

[WPB-18127] Update email templates to v1.0.155. - #5344

Merged
fisx merged 6 commits into
developfrom
email-templates-v1.0.152
Jul 31, 2026
Merged

[WPB-18127] Update email templates to v1.0.155.#5344
fisx merged 6 commits into
developfrom
email-templates-v1.0.152

Conversation

@fisx

@fisx fisx commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-18127

This PR is the result of following the instructions here.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx
fisx requested review from a team as code owners July 17, 2026 13:49
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 17, 2026
Comment thread libs/wire-subsystems/templates/lt/user/email/new-client.txt Outdated
Comment thread libs/wire-subsystems/templates/fr/user/email/new-client.txt Outdated

@battermann battermann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most templates are changed to English, that can't be right.

@blackheaven

Copy link
Copy Markdown
Contributor

Given that we won't include unverified/unvalidated translations, we should drop them all along, to avoid selecting fr/it/... and end up with english e-mails.

@fisx

fisx commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Given that we won't include unverified/unvalidated translations, we should drop them all along, to avoid selecting fr/it/... and end up with english e-mails.

But don't we need some default? What do you want to display instead of English if there is no translation?

@fisx

fisx commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

I talked to @Astrid-Wire, here is the conclusion:

  • we have never officially supported anything but English and German, and the unapproved translations were always provided as-is, without any promises.
  • @screendriver recently changed wire-emails to disregard unapproved emails. This is why the translations all switched to English (the default).
  • We want to stick with this change. Unapproved translations are a potential attack vector, so in emails, non-English-speaking users will be exposed to more English starting in the next release.
  • If you want to approve some of the unapproved translations and thus get them into the product again, you can reach out to Astrid and become a part-time translator.

@fisx
fisx requested review from battermann and blackheaven July 21, 2026 08:21
@fisx

fisx commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Ah, there are some legit test failures, i'll fix them and add tests for the new templates, get CI green, then it's time for a review.

@fisx

fisx commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

I looked into the testing situation: we're testing the email subsystem, not the templates, and I would like to extend the email subsystem in a separate PR. Then I can also move the tests from services/brig to libs/wire-subsystems, I think that's the only thing they (morally) depend on.

@stefanwire

Copy link
Copy Markdown
Contributor

I talked to @Astrid-Wire, here is the conclusion:

  • we have never officially supported anything but English and German, and the unapproved translations were always provided as-is, without any promises.
  • @screendriver recently changed wire-emails to disregard unapproved emails. This is why the translations all switched to English (the default).
  • We want to stick with this change. Unapproved translations are a potential attack vector, so in emails, non-English-speaking users will be exposed to more English starting in the next release.
  • If you want to approve some of the unapproved translations and thus get them into the product again, you can reach out to Astrid and become a part-time translator.

(Unapproved) Translations are back, so please update this PR accordingly before merging.

@stefanwire stefanwire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot merge without the translations been put back.

@fisx

fisx commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

replaced by #5399

@fisx fisx closed this Jul 30, 2026
@fisx fisx changed the title [WPB-18127] Update email templates to v1.0.152. [WPB-18127] Update email templates to v1.0.154. Jul 30, 2026
@fisx

fisx commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

#5399 closed, I'll do it here. (With yet another update from wire-emails.)

@fisx fisx reopened this Jul 30, 2026
@fisx
fisx force-pushed the email-templates-v1.0.152 branch from d3e6700 to 0777f2c Compare July 31, 2026 07:57
@fisx fisx changed the title [WPB-18127] Update email templates to v1.0.154. [WPB-18127] Update email templates to v1.0.155. Jul 31, 2026
@fisx
fisx requested a review from stefanwire July 31, 2026 08:05
@fisx

fisx commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

replaced by #5399

Now this PR only contains the new app templates in German and English.

@fisx
fisx merged commit b412c1c into develop Jul 31, 2026
9 checks passed
@fisx
fisx deleted the email-templates-v1.0.152 branch July 31, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants