[WPB-27227] Cleanup PR 5343. - #5354
Merged
Merged
Conversation
zebot
added
the
ok-to-test
2 tasks
fisx
marked this pull request as ready for review
July 21, 2026 15:20
supersven
reviewed
Jul 21, 2026
| @@ -0,0 +1 @@ | |||
| Cleanup PR 5343. | |||
Contributor
There was a problem hiding this comment.
I would delete this file. It provides little value to the reader who will care about the release, not single PRs.
supersven
reviewed
Jul 21, 2026
Comment on lines
+72
to
+73
| -- | Delete app. This is meant for calling from when deleting team | ||
| -- members and does not check authentication. |
Contributor
There was a problem hiding this comment.
Suggested change
| -- | Delete app. This is meant for calling from when deleting team | |
| -- members and does not check authentication. | |
| -- | Delete app. This is meant for calling to delete team | |
| -- members. It does not check authentication. |
The sentence reads a bit clunky. 馃槄
Contributor
Author
There was a problem hiding this comment.
Also I can't parse it any more... :) Thanks!
supersven
approved these changes
Jul 21, 2026
supersven
left a comment
supersven
left a comment
Contributor
There was a problem hiding this comment.
You may want to consider my comments. However, there's nothing severe enough to block merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-27227
as promised in #5343 (comment) :)
Checklist
changelog.d