WPB-23631: Move Spar.Sem.SamlProtocolSettings to Wire.SamlProtocolSettings - #5377
Merged
blackheaven merged 2 commits intoJul 28, 2026
Merged
Conversation
…Settings` Move the SamlProtocolSettings effect + Servant interpreter to Wire.SamlProtocolSettings(.Servant). Interpreter keeps taking SAML.Config as an arg (unchanged). Rewire consumers (CanonicalInterpreter, Spar.API, Test.Spar.Saml.IdPSpec, Test.Spar.Sem.SamlProtocolSettingsSpec); delete old modules; register in cabal. Clean cutover. Per-commit build gate passed: cabal build wire-subsystems spar.
zebot
added
the
ok-to-test
supersven
approved these changes
Jul 28, 2026
supersven
left a comment
supersven
left a comment
Contributor
There was a problem hiding this comment.
Besides the comment about the correct changelog section, LGTM 👍
Contributor
There was a problem hiding this comment.
Shouldn't this be in internal? 🤔
I mean, you aren't changing any behaviour here, no?
Contributor
Author
There was a problem hiding this comment.
Good catch, changed!
blackheaven
deleted the
gdifolco/WPB-23631-migrate-brig-galley-spar-effects-1
branch
July 28, 2026 15:11
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-23631
Checklist
changelog.d