[WPB-27705] Roll back: do *not* include collaborator apps in get-apps end-point. - #5402
Merged
fisx merged 4 commits intoJul 31, 2026
Conversation
zebot
added
the
ok-to-test
fisx
marked this pull request as ready for review
July 31, 2026 10:50
battermann
approved these changes
Jul 31, 2026
supersven
approved these changes
Jul 31, 2026
supersven
left a comment
supersven
left a comment
Contributor
There was a problem hiding this comment.
The why should be documented; in the commit message, changelog or PR description. This would help your colleagues answering possible questions regarding this when you're not around.
Other than that: Looks good to me 👍
fisx
deleted the
WPB-27705-roll-back_-do-_not_-include-collaborator-apps-in-get-apps-end-point
branch
July 31, 2026 13:35
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-27705
There is
GET /teams/:tid/appsandGET /teams/:tid/collaborators, and mixing the two concerns in these two end-points seems incoherent to me.There is an ongoing discussion whether collaborators are team members (they interact with the team, but do you have to pay for their seats, even though the home team has already paid?), but for these two end-points there shouldn't be any disagreements. (... right?)
Checklist
changelog.d