Skip to content

WPB-23631: move ScimExternalIdStore law tests from library to test-suite - #5423

Merged
blackheaven merged 1 commit into
developfrom
gdifolco/WPB-23631-migrate-brig-galley-spar-effects-6-fix-src-tests
Aug 6, 2026
Merged

WPB-23631: move ScimExternalIdStore law tests from library to test-suite#5423
blackheaven merged 1 commit into
developfrom
gdifolco/WPB-23631-migrate-brig-galley-spar-effects-6-fix-src-tests

Conversation

@blackheaven

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-23631

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@blackheaven
blackheaven requested a review from a team as a code owner August 6, 2026 09:52
Relocate the Polysemy.Check property-law module for Wire.ScimExternalIdStore out of the library exposed-modules and into the wire-subsystems test-suite as Wire.ScimExternalIdStore.MemSpec (auto-discovered by hspec-discover, run against the in-memory interpreter). Delete the redundant spar driver Test.Spar.Sem.ScimExternalIdStoreSpec that re-ran the same laws. Supply the CoArbitrary UserId / ScimUserCreationStatus orphans locally (mirroring spar's Arbitrary.hs) and drop the now-redundant CoArbitrary constraints from the PropConstraints instance head (-Wredundant-constraints).
@blackheaven
blackheaven force-pushed the gdifolco/WPB-23631-migrate-brig-galley-spar-effects-6-fix-src-tests branch from 6330dc1 to 99a04dd Compare August 6, 2026 09:53
@blackheaven
blackheaven requested review from a team as code owners August 6, 2026 09:53
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 6, 2026
@blackheaven
blackheaven merged commit d8fb5af into develop Aug 6, 2026
9 checks passed
@blackheaven
blackheaven deleted the gdifolco/WPB-23631-migrate-brig-galley-spar-effects-6-fix-src-tests branch August 6, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants