[WPB-18127] Move email template completeness tests from brig to wire-subsystems. - #5429
Merged
fisx merged 2 commits intoAug 11, 2026
Conversation
zebot
added
the
ok-to-test
fisx
force-pushed
the
WPB-18127-move-email-template-completeness-tests-from-brig-to-wire-subsystems
branch
from
August 11, 2026 07:26
6a4d6a3 to
dba85a1
Compare
Contributor
Author
|
I wonder if we should also |
fisx
marked this pull request as ready for review
August 11, 2026 07:26
fisx
force-pushed
the
WPB-18127-move-email-template-completeness-tests-from-brig-to-wire-subsystems
branch
from
August 11, 2026 07:52
dba85a1 to
9129f3a
Compare
blackheaven
approved these changes
Aug 11, 2026
fisx
deleted the
WPB-18127-move-email-template-completeness-tests-from-brig-to-wire-subsystems
branch
August 11, 2026 08:45
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring PR for making #5243 easier to implement.
What can be run as unit test should not be run as integration test. Rendering email templates is clearly unit-testable, so I moved
/services/brig/test/integration/API/Template.hsto/libs/wire-subsystems/test/unit/Wire/EmailSubsystem/. Prior art:/libs/wire-subsystems/test/unit/Wire/SAMLEmailSubsystem/InterpreterSpec.hs, from which I moved some code into a new fixtures module;loadTeamTemplates, which inspiredloadUserTemplates.https://wearezeta.atlassian.net/browse/WPB-18127
Checklist
changelog.d