Remove V1 usermod

[netmindz]

Remove legacy usermod

Summary by CodeRabbit

• Refactor

  • Streamlined usermod integration to rely on the central usermod manager for lifecycle events, removing legacy callback paths.

• Chores

  • Removed unused usermod template code and related documentation.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 94d0487e-c5cb-47df-8975-e234f99badb1

📥 Commits

Reviewing files that changed from the base of the PR and between 0a21869 and 1795797.

📒 Files selected for processing (2)

• wled00/fcn_declare.h
• wled00/wled.cpp

💤 Files with no reviewable changes (2)

• wled00/fcn_declare.h
• wled00/wled.cpp

---

Walkthrough

This change removes the legacy usermod callback functions (userSetup(), userConnected(), userLoop()) from the codebase. Their declarations are deleted from the header, their empty implementation file is removed, and all direct invocations are replaced with calls to the UsermodManager equivalents in the main application logic.

Changes

Usermod removal and rewiring

Layer / File(s)	Summary
Remove legacy declarations wled00/fcn_declare.h	Removed declarations of userSetup(), userConnected(), and userLoop().
Wiring: replace direct user calls with UsermodManager wled00/wled.cpp	Replaced direct calls to userLoop(), userSetup(), and userConnected() with UsermodManager::loop(), UsermodManager::setup(), and UsermodManager::connected().
Deleted legacy stub wled00/usermod.cpp	Removed the empty usermod implementation file that contained the legacy callback stubs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Suggested labels: usermod

Suggested reviewers:

• willmmiles
• softhack007

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: removing the V1 usermod legacy system (function declarations, the usermod.cpp template file, and direct function calls). It is concise and specific.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[willmmiles]

There are several v1 usermods still in the tree -- they should get ported to v2 before we merge this. As it turns out, the v1 usermod binding is actually fully compatible with the "usermods as libraries" approach, though you can only enable one (it'll throw a linker error otherwise).

[netmindz]

How does that work then? Does the compiler just treat the CPP fille as if it's a duplicate header definition as the function is empty and magically switch to the version in the other directory if on the include path?

[willmmiles]

Well blow me sideways - I wrote it months ago, but I never merged that patch! It was in my TTGO-T-Display usermod branch, PR #4600. I'd flagged it as draft as I didn't have the hardware to test it. (I have something "close enough" on my test block now; works fine, I should dust it off and submit.)

But yes - that's pretty much how it works, through the power of weak symbols. The definitions in wled00/usermod.cpp can be flagged to be linked in only if no other source file defines them.

Sorry for the confusion.