Add hardware-based DICE on MCXN#780
Open
yosuke-wolfssl wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds DICE attestation support for MCXN, including a hardware-backed DICE path via MCXN EdgeLock Secure Subsystem and a new public API for retrieving the read-once IAK public key.
Changes:
- Adds
WOLFBOOT_DICE_HWbuild path, HAL hooks, and MCXN ELS-backed DICE key/signing implementation. - Adds PSA/TEE API support for
psa_initial_attest_get_iak_pubkey(). - Adds MCXN PSA/DICE sample configs, tests, app verification flow, and documentation.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/dice/dice.c |
Adds hardware DICE signing path and IAK public-key caching/getter. |
hal/mcxn.c |
Implements MCXN UUID/UEID handling and ELS-backed CDI/key/signature hooks. |
hal/hal.c |
Adds weak hardware DICE HAL hook stubs. |
include/hal.h |
Declares hardware DICE HAL hook API. |
include/wolfboot/dice.h |
Adds component name macros and public IAK public-key getter. |
src/arm_tee_psa_ipc.c |
Adds secure-side PSA IPC dispatch for IAK public-key retrieval. |
zephyr/src/arm_tee_attest_api.c |
Adds non-secure PSA wrapper for IAK public-key retrieval. |
zephyr/include/psa/initial_attestation.h |
Declares the new PSA attestation public-key getter. |
zephyr/include/arm_tee_attest_defs.h |
Adds attestation message ID for IAK public-key retrieval. |
include/wolfboot/arm_tee_api.h |
Narrows CMSE NS entry attribute condition. |
test-app/app_mcxn.c |
Adds PSA attestation token verification test using retrieved IAK public key. |
options.mk |
Adds WOLFBOOT_DICE_HW compiler define handling under PSA TrustZone builds. |
arch.mk |
Adds MCXN ELS PKC include paths and objects for PSA builds. |
config/examples/mcxn-tz-psa.config |
Adds MCXN TrustZone PSA software-DICE sample config. |
config/examples/mcxn-tz-psa-hw.config |
Adds MCXN TrustZone PSA hardware-DICE sample config. |
.github/workflows/test-configs.yml |
Adds MCXN PSA and hardware-DICE build jobs. |
docs/DICE.md |
Documents hardware DICE keying mode and public-key getter. |
docs/Targets.md |
Links MCXN DICE documentation from target docs. |
docs/MCXN947-DICE.md |
Adds MCXN947 DICE sample setup and expected output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #780
Scan targets checked: wolfboot-bugs
Failed targets: wolfboot-src
Author
|
Hello @danielinux , I finished the implementation. |
danielinux
requested changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the hardware-based DICE attestation feature on wolfBoot.
Also, this updates existing DICE feature to give users a derived public part of IAK for further verification.
Changes: hardware-based DICE
Changes: MCXN specific
Changes: Public key distribution