Tests: improve Windows compatibility - #323
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Windows compatibility for the DB-related Behat suite and SQLite command execution paths, mainly by avoiding POSIX-only paths/quoting and reducing SQLite file-locking failures on Windows.
Changes:
- Update SQLite CLI invocation and export/import mechanics to be more Windows-friendly (path normalization, using
-initscripts, closing$wpdbbefore deletes). - Adjust Behat scenarios to avoid
/tmp/...paths and single-quote shell arguments that don’t work reliably on Windows. - Skip a few SQLite-related scenarios on Windows where CI/environment limitations (file locking, missing
dbstat) make them unreliable.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/DB_Command_SQLite.php |
Improves SQLite CLI usage on Windows (env wrapper, file-lock mitigation, init-file based dump/import, path normalization). |
features/db.feature |
Removes /tmp usage; skips flaky SQLite CRUD/export/import scenarios on Windows. |
features/db-size.feature |
Skips SQLite table-size scenarios on Windows due to missing dbstat on CI. |
features/db-search.feature |
Switches to Windows-compatible quoting and adjusts regex delimiter expectations; skips custom-color scenario on Windows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.