Add build step for wp-cli/wp-cli-shim - #592
Conversation
|
@szepeviktor What do you think of this? Does it solve your needs? |
|
@swissspidy The repository was created: https://github.com/wp-cli/wp-cli-shim |
|
@schlessera Thanks! Can you add me to the repo so I can add an initial |
wp-cli/pharwp-cli/wp-cli-shim
|
@swissspidy Done. |
|
@schlessera OK so I pushed a branch intending to create a PR but because it was the first branch that became the default 馃う https://github.com/wp-cli/wp-cli-shim Can you make |
|
@schlessera OK, so now I suppose what's left is making sure that the Once it does, we can tag what's currently in the repo with Not sure if we need |
|
@schlessera wanna give this a try for next release? |
This comment was marked as resolved.
This comment was marked as resolved.
|
Hi @swissspidy, I came here from #134. I'm aware of @johnpbloch's great https://github.com/johnpbloch/wp-cli-phar package, and we use it in our organization, but having a first-party repository would be even better (especially in times of supply chain attacks becoming worryingly regular). Therefore, please allow me to ask if there are any plans to move this PR forward. |
|
Thanks for the ping! Work on this kinda stalled in favor of wp-cli/wp-cli#5920, where we wanted to take a step back and identify the actual problem we're trying to solve. If you'd like to leave a comment expressing your interest & what you would like to see solved, that would be very helpful. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the 鈿欙笍 Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The `deploy-shim` job downloaded an artifact named `wp`, but the build job uploads it as `wp-cli-phar` containing `wp-cli.phar`, so the download failed and the subsequent `chmod`/`git add` had no file to operate on. Download the correct artifact and rename the Phar to `wp`, which is what `wp-cli/wp-cli-shim` declares as its `bin`. Also align the job with the existing `deploy` job: * Give it a distinct display name, as both were labelled "Deployment". * Pin `actions/checkout`, `actions/download-artifact` and `ad-m/github-push-action` to the same SHAs used elsewhere in this workflow, instead of floating tags and `@master`. * Push to `main` explicitly. Without it the action defaults to the current ref, which would push to a branch named after the bundle's ref rather than the shim's default branch. * Push tags, so the "Tag stable release" step is no longer a no-op. * Skip on `workflow_dispatch`, matching `deploy`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RHtjyXkZh8X16sBgmidSQi

Assumes the existence of a new
wp-cli/pharrepository with acomposer.jsonsuch as this one:{ "name": "wp-cli/wp-cli-shim", "description": "Composer-based WP-CLI Phar", "license": ["MIT"], "require": { "php": ">=5.6" }, "conflict": { "wp-cli/wp-cli" : "*" }, "bin": ["wp-cli.phar"] }And I think that's all that's needed.
To-do:
wp-cli/wp-cli-shimor somethingFixes #134
Fixes wp-cli/ideas#145