More performant conversion byte to hexadecimal string - #70
Closed
xtonik wants to merge 2 commits into
Closed
Conversation
| // Branch-less code: return CHAR_TO_HEX_MAP[ch & 127] | (127 - ch) >> 31; | ||
| return ch < 128 ? CHAR_TO_HEX_MAP[ch] : -1; | ||
| static int lookupHex(char ch) { | ||
| return CHAR_TO_HEX_MAP[ch & 0xff]; |
Owner
There was a problem hiding this comment.
return CHAR_TO_HEX_MAP[ch & 0xff];
This code incorrectly maps characters outside of the ASCII range.
For example, the code incorrectly maps the character 'Ł' U+0141 to 'A' U+0041.
Author
There was a problem hiding this comment.
You are right, I had to overlook something.
Owner
|
I am closing this merge request, because it incorrectly accepts some non-ascii characters as hex characters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.