Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Outside GitHub Actions, the
cloud-cacheCLI printed raw workflow commands to stdout.@actions/core,@actions/cacheand@actions/globwrite lines such as::debug::...,::warning::...and::group::.... Only GitHub Actions reads them. In a Bitbucket or generic log they are noise, a warning does not go to stderr, and an::add-mask::line would print the secret value.Measured before the fix:
cloud-cache restore --dual-cacheandcloud-cache save --dual-cacheagainst a local RustFS printed about 40::debug::and::warning::lines on stdout.Change
src/cli/workflowCommands.ts. It interceptsprocess.stdout.writewhile the CLI runs a command, after the host is set. Each workflow command line goes to the host log:debuggoes tolog.debug, which prints only with--debug.warninggoes tolog.warning, anderrorgoes tolog.error. Both print on stderr.noticegoes tolog.info.groupandendgroupgo tolog.startGroupandlog.endGroup.add-maskis dropped.Bufferwrites pass through unchanged. The escaped characters%0A,%0Dand%25are decoded.hashFilesinhashTemplate.tsis removed, because the new one covers it. This also fixes a known small defect: the old interceptor dropped plain text that came in the same write as a::debug::line.Measured
tests/unit/cli/workflowCommands.test.tshas 6 new tests. They use the real@actions/corefunctions.npm test: 1304 passed, 16 skipped.npm run lint,npm run format:checkandnpm run typecheckpass.TEST_CLI=1): 10 passed.::on stdout. The warnings print on stderr aswarning: ....Not measured