Skip to content

Force a sync render after resize occurs - #5529

Merged
Tyriar merged 1 commit into
xtermjs:masterfrom
Tyriar:worktree1
Dec 28, 2025
Merged

Tyriar merged 1 commit into
xtermjs:masterfrom
Tyriar:worktree1

Conversation

@Tyriar

@Tyriar Tyriar commented Dec 28, 2025

Copy link
Copy Markdown
Member

@Tyriar Tyriar added this to the 6.1.0 milestone Dec 28, 2025
@Tyriar Tyriar self-assigned this Dec 28, 2025
@Tyriar
Tyriar enabled auto-merge December 28, 2025 22:39
@Tyriar
Tyriar merged commit c975956 into xtermjs:master Dec 28, 2025
12 checks passed
Bokjan added a commit to Bokjan/ZShell that referenced this pull request Oct 17, 2026
Switching to a tab showed its terminal empty for one frame. A terminal reloads the WebGL renderer when its tab is shown, and the new canvas stays empty until xterm.js draws it on the next animation frame, which the first frame doesn't wait for: the terminal is still paused until its IntersectionObserver reports it back on screen, a frame late, and at fractional pixel ratios (125%, 175%) the addon's ResizeObserver also resizes the canvas by a pixel on the first layout, which clears it. The terminal is now drawn right after that observer, before the frame is painted, through an internal of xterm.js that ignores the pause. Recorded with screencasts at 100% and 175%, every tab switch showed one empty frame before and none after.

xterm.js master fixes the resize part (xtermjs/xterm.js#5529) but still skips the redraw while paused; docs/TODO.md tracks both and how to remove the workaround.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Canvas flickers when canvas position is moving.

1 participant