Repository navigation
Force a sync render after resize occurs - #5529
Merged
Merged
Conversation
Tyriar
enabled auto-merge
December 28, 2025 22:39
Bokjan
added a commit
to Bokjan/ZShell
that referenced
this pull request
Oct 17, 2026
Switching to a tab showed its terminal empty for one frame. A terminal reloads the WebGL renderer when its tab is shown, and the new canvas stays empty until xterm.js draws it on the next animation frame, which the first frame doesn't wait for: the terminal is still paused until its IntersectionObserver reports it back on screen, a frame late, and at fractional pixel ratios (125%, 175%) the addon's ResizeObserver also resizes the canvas by a pixel on the first layout, which clears it. The terminal is now drawn right after that observer, before the frame is painted, through an internal of xterm.js that ignores the pause. Recorded with screencasts at 100% and 175%, every tab switch showed one empty frame before and none after. xterm.js master fixes the resize part (xtermjs/xterm.js#5529) but still skips the redraw while paused; docs/TODO.md tracks both and how to remove the workaround. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4922
Related microsoft/vscode#230120