Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6302.
A full reset currently leaves a hidden cursor hidden and preserves the host's newline-mode changes. Restore cursor visibility in CoreService.reset and keep LNM as a runtime mode override rather than modifying the embedder's
convertEoloption.The effective newline mode falls back to the application's current
convertEolsetting when no host override exists. RIS and Terminal.reset clear the override. DECSTR preserves it, matching the attributes listed in the VT510 soft-reset reference.This deliberately separates host mode changes from application configuration: CSI 20 h/l no longer mutate
terminal.options.convertEol. Existing set/reset tests now inspect the runtime mode; additional browser and headless tests assert actual line-feed output, mode-query replies, unchanged application options, and resets with both configured defaults.Validation: