Repository navigation
Trim buffer lines on a column shrink when reflow is disabled - #6314
Open
SeoJunLee-code wants to merge 1 commit into
Open
SeoJunLee-code wants to merge 1 commit into
SeoJunLee-code wants to merge 1 commit into
Conversation
The trim only ran inside the reflow branch, so buffers with reflow off, such as the alt buffer, kept their old line length and the cells past cols. Fixes xtermjs#6228 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6228
Summary
Buffer.resizeonly trimmed lines on a column shrink when reflow was enabled, so buffers withreflow off (the alt buffer, and the normal buffer under a
windowsPtywithout reflow support)kept their old line length and the cells past
cols. Run the existing trim outside the reflow branch.Behavior change
With reflow off, cells cut by a shrink no longer reappear when the terminal is widened again.
Testing
npm run test-unit: 2448 passing, 0 failingnpm run lint-changes; addon-serialize unit tests: 47 passingLimitations
Not tested: real full-screen apps such as vim or tmux, browser rendering, Playwright, macOS, Linux.
🤖 Generated with Claude Code