LocalStore.list_prefix adds directory prefix to all paths

[dcherian]

Zarr version

v3

Numcodecs version

?

Python Version

?

Operating System

?

Installation

?

Description

list_prefix("") for a LocalStore seems inconsistent with the other stores. Discovered in #2189

'/private/var/folders/sc/hsdthq2x7mnbfvwnk7rp4xmr0000gn/T/pytest-of-deepak/pytest-854/test_zarr_hierarchy_local_0/zarr.json'

Also:

zarr-python/tests/v3/test_store/test_local.py

Lines 39 to 40 in b1ecdd5

	def test_list_prefix(self, store: LocalStore) -> None:
	assert True

LOL

Steps to reproduce

Additional output

No response

[zoj613]

In my very inexperienced eyes, this looks like the cause:

zarr-python/src/zarr/store/local.py

Lines 204 to 211 in b1ecdd5

	for p in (self.root / prefix).rglob("*"):
	if p.is_file():
	yield str(p)
	to_strip = str(self.root) + "/"
	for p in (self.root / prefix).rglob("*"):
	if p.is_file():
	yield str(p).replace(to_strip, "")

The root directory path is not stripped away and returned as is (line 206). I am not sure why the code appears to be duplicated in that function? Maybe someone who was implementing the correct code (lines 208 - 211) forgot to delete the previous block?

[jhamman]

I think @d-v-b is working on a related set of fixes here: #2064

[d-v-b]

yep, and I can split the fixes out of #2064 into their own PR

[d-v-b]

#2064 is in, so I'm curious to see if the problem you observed is still around.

zarr-python/tests/v3/test_store/test_local.py

Lines 39 to 40 in b1ecdd5

	def test_list_prefix(self, store: LocalStore) -> None:
	assert True

LOL indeed, this bit me when working on the PR because I had no idea why my changes to the localstore implementation were not making tests fail :)