Add feed mapper

[snapshotpl]

No description provided.

[ins0]

i think this method is not necessary and the name don't indicates there actually return - there is no need to wrap it into a sep. method - no?

[ins0]

@snapshotpl can u please provide tests for this feature?

[snapshotpl]

@ins0 Test provided, but Travis looks dead ;)

[ins0]

could you please update the url too? zfmodules.com

[snapshotpl]

I think we should create a new PR with this update in whole project

[ins0]

yeah sounds like a better plan 💯

[ins0]

@snapshotpl just searched inside the project and actually this is the only file that contains the url and needs an update ^^

[snapshotpl]

There is also link in README

[gianarb]

Maybe serverUrl is a best solution

[ins0]

Isn't this a View Helper?

[gianarb]

mmm you are in Controller..
You can use

$url = $this->url()->fromRoute('home', [], ['force_canonical', true]);

@ins0 print the url into the application in my opinion is not a good idea.. But I don't remember if this solution works

PS same stuff for the setFeedLink

$url = $this->url()->fromRoute('feed', [], ['force_canonical', true]);

[ins0]

@gianarb 👍
@snapshotpl if u like to create a new pr with the url just say otherwise i would do this 😃

[snapshotpl]

Change in progress...

[ins0]

thanks @snapshotpl for providing tests 👍 - this looks good from my point of view 😃

[snapshotpl]

@ins0 @gianarb Done. I extended also feed entry data

[ins0]

i would suggest to name this more explicit and not simple $url

[snapshotpl]

@ins0 what about now? :)

[ins0]

slightly better but still odd. how about sprintf('%s/%s', $module->getOwner(), $moduleName) or we extend the module entity to get a full repository name - but not sure about that. /cc @Ocramius @localheinz

[snapshotpl]

I like idea with additional method i module entity. We can reuse it in views.

[ins0]

yeah i ike this idea as well, there should be no reason to not follow this way 👍

[Ocramius]

If the module pseudo-identifier is this one, then yes, this should be part of the Module model API

[snapshotpl]

My PR needs review :-)

[snapshotpl]

@ins0 who said that Module entity can come from db?

[Ocramius]

Merged, thanks @snapshotpl!