Skip to content
This repository was archived by the owner on May 1, 2019. It is now read-only.

Fix: GitHub API response for contributors #452

Merged
Ocramius merged 3 commits into from
Mar 4, 2015
Merged

Fix: GitHub API response for contributors #452

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4420534
Fix: GitHub API response
localheinz Mar 4, 2015
c93e6b2
Fix: Failing tests
localheinz Mar 4, 2015
b70d28d
Fix: Shorten variable
localheinz Mar 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 28 additions & 14 deletions module/Application/test/ApplicationTest/Service/RepositoryRetrieverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,9 +458,14 @@ public function testGetContributorsDecodesResponseToArray()

array_walk($contributors, function ($contributor) {
$this->assertInternalType('array', $contributor);
$this->assertArrayHasKey('login', $contributor);
$this->assertArrayHasKey('avatar_url', $contributor);
$this->assertArrayHasKey('html_url', $contributor);
$this->assertArrayHasKey('author', $contributor);

$author = $contributor['author'];

$this->assertInternalType('array', $author);
$this->assertArrayHasKey('login', $author);
$this->assertArrayHasKey('avatar_url', $author);
$this->assertArrayHasKey('html_url', $author);
});
}

Expand Down Expand Up @@ -512,18 +517,23 @@ public function testGetContributorsReturnsContributorsInReverseOrder()

array_walk($contributors, function ($contributor) use (&$contributorsAsReturned) {

$expectedContributor = array_pop($contributorsAsReturned);
$expected = array_pop($contributorsAsReturned);

$this->assertInternalType('array', $contributor);
$this->assertArrayHasKey('author', $contributor);

$author = $contributor['author'];

$this->assertArrayHasKey('login', $contributor);
$this->assertSame($expectedContributor->login, $contributor['login']);
$this->assertInternalType('array', $author);

$this->assertArrayHasKey('avatar_url', $contributor);
$this->assertSame($expectedContributor->avatar_url, $contributor['avatar_url']);
$this->assertArrayHasKey('login', $author);
$this->assertSame($expected->author->login, $author['login']);

$this->assertArrayHasKey('html_url', $contributor);
$this->assertSame($expectedContributor->html_url, $contributor['html_url']);
$this->assertArrayHasKey('avatar_url', $author);
$this->assertSame($expected->author->avatar_url, $author['avatar_url']);

$this->assertArrayHasKey('html_url', $author);
$this->assertSame($expected->author->html_url, $author['html_url']);
});
}

Expand Down Expand Up @@ -566,17 +576,21 @@ public function testGetContributorsReturnsFalseIfRuntimeExceptionIsThrown()
}

/**
* @link https://developer.github.com/v3/repos/#response-5
* @link https://developer.github.com/v3/repos/statistics/#response
*
* @return stdClass
*/
private function contributor()
{
$author = new stdClass();

$author->login = $this->faker()->unique()->userName;
$author->avatar_url = $this->faker()->unique()->url;
$author->html_url = $this->faker()->unique()->url;

$contributor = new stdClass();

$contributor->login = $this->faker()->unique()->userName;
$contributor->avatar_url = $this->faker()->unique()->url;
$contributor->html_url = $this->faker()->unique()->url;
$contributor->author = $author;

return $contributor;
}
Expand Down