Skip to content

Update package.json - #23

Open
Braunson wants to merge 1 commit into
zhouzi:mainfrom
Braunson:patch-1
Open

Braunson wants to merge 1 commit into
zhouzi:mainfrom
Braunson:patch-1

Conversation

@Braunson

@Braunson Braunson commented Dec 6, 2023

Copy link
Copy Markdown

Updating the joi dependency

ref: #22

Updating the joi dependency
@zhouzi

zhouzi commented Dec 11, 2023

Copy link
Copy Markdown
Owner

Thanks for the PR and sorry for the delay 🙏

That's too bad because ^17.4.0 matches 17.11.0 and would work out of the box if we:

  1. Move joi to the peerDependencies so it relies on the project's version
  2. Add joi to the devDependencies so it's installed when developing

In this case ^17.0.0 should work as this plugin uses very basic joi features that probably didn't receive a breaking change with a minor version update.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants