resinator should not observe any environment variables

[andrewrk]

One of zig's principles as a toolchain is to reduce dependencies on global state of the system, so that collaborators on wildly different systems can have a seamless experience working with each other.

To that end, this code should be deleted:

zig/src/resinator/compile.zig

Lines 112 to 123 in 7a9500f

	if (!options.ignore_include_env_var) {
	const INCLUDE = std.process.getEnvVarOwned(allocator, "INCLUDE") catch "";
	defer allocator.free(INCLUDE);
	// TODO: Should this be platform-specific? How does windres/llvm-rc handle this (if at all)?
	var it = std.mem.tokenize(u8, INCLUDE, ";");
	while (it.next()) |search_path| {
	var dir = openSearchPathDir(options.cwd, search_path) catch continue;
	errdefer dir.close();
	try search_dirs.append(.{ .dir = dir, .path = try allocator.dupe(u8, search_path) });
	}
	}

All include paths that are intended to be observed by resinator should be provided explicitly by the user, and explicitly for resinator and no other files, and it should be per invocation rather than global.

I noticed this when enhancing zig env to tattle on what environment variables are possibly observed by the compiler, and it's unfortunate that INCLUDE is in this list.

cc @squeek502

[squeek502]

EDIT: Oops, yes, this was an accidental regression in the clang argv setup in #17412 (I don't pass ignore_include_env_var = true to it).

Will fix this tomorrow.

---

Unless I accidentally regressed something (very possible), this is already the case for everything except zig rc:

ignore_include_env_var is unconditionally set to true when compiling .rc and .manifest files:

zig/src/Compilation.zig

Line 4873 in aeadcb3

.ignore_include_env_var = true,

zig/src/Compilation.zig

Line 4675 in aeadcb3

.ignore_include_env_var = true,

It is controlled by the /x flag in zig rc for compatibility with rc.exe but I could be persuaded against that if you feel it would be an improvement (the INCLUDE env var is only really set when setting up a "Visual Studio development environment" via the vcvarsall.bat and friends scripts, and resinator doesn't really depend on it being set since it autodetects the system include paths by default anyway).

[andrewrk]

Nice, that all makes sense and I think your intended way for it to work is perfectly reasonable.