Repository navigation
docs: five current-state corrections (c19 Lemonade sha, KNOWN-ISSUES #370, hw-gate wording, the HRX suite count, the release candidate) - #1144
Conversation
…elongs to '#1126 moved the pin to f44ff953, so the sentence'The Lemonade pin is the sha (ef0f3b49)' reads as a claim about today inside a dated section. Two words pin it to c19; the derivation rule it teaches is unchanged.
…ys so The page's first entry still read 'Status: OPEN, root cause not fixed in this repository' for an issue GitHub closed on 2026-10-10 (completed), and docs/hw-gate.md built its three-clean-runs rule on that open status. Both now say what happened: the kernel is unchanged in the fork, the follow-up run at the bumped pin produced 0 failures in 30 focused runs and 3 x 1141/1141 full suites, and a single failure of the case is a flake. Rule unchanged.
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY
Checked the premise and the two hunks added since the body was written:
git ls-tree origin/main third_party/lemonade->160000 commit f44ff953bcd8c1bfb7a5908fc72dc7b3f6fc2987. So thereleases.mdsentence namingef0f3b49without a date was true only until #1126; "at c19" makes it agree with the component row 29 lines above it (docs/releases.md:56->2026.46.0~1.ef0f3b49), which is the whole fix.- engine#370 is
CLOSED(2026-10-10T16:10:46Z), and "closed as not reproducible, not as fixed at source" is the honest reading: the kernel is in the fork, and nothing engine-side changed it. #1141 is closed (18:02:33Z) and this supersedes it. - The rule the amended
docs/hw-gate.mdparagraph leans on is in the code it names:scripts/hw-gate.sh:506-516re-runsFLAKY_CASES(:161,MUL_MAT(type_a=f32,type_b=f32,m=1,n=1,k=2048) alone three times and requires all three clean, which is exactly what the new sentence promises. 4a375bf2d36f todayis main's pin:git ls-tree origin/main third_party/llama.cpp->4a375bf2d36f6ed16b1ed98b014568c02667579c.tools/copyright.py --check-> rc 0.
Not verified: the 30 focused runs (20 new pin / 10 old) and the 3 x 1141/1141 full-suite runs in the KNOWN-ISSUES row have no artifact on this box, so I could not re-derive them; the row rests on the issue's closure record, which I did read.
One thing to fix so the record matches what merges: the body's Measured block is a push behind the branch. It says "one file, +1/-1" and "git ls-remote = local head c9e8291", but the head is 512cdfea and the diff is 3 files, +10/-5 (KNOWN-ISSUES.md, docs/hw-gate.md, docs/releases.md). The two extra hunks are the correct ones; only the description is stale.
The page's opening sentence said the onebit recipe passes "29 of 29" on HRX.
That number is the removed Vulkan backend's row in the same page's embedding
checklist ("29 / 29 run, all pass, before its removal"); HRX's own row, dated
2026-11-05, is "31 / 31 run, all pass (2 skipped)". The site renders this
sentence onto its index, docs and lemonade pages, so the same number the site
PR fixes in the share kit was still published from here.
|
#1144 ready for review at a742211 (one more claim: |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY
Re-verdicted at a7422110. New since 512cdfea: main taken in twice, and one real commit, docs/lemonade's opening sentence 29 -> 31 of 31. Its explanation is checkable in the same file and it holds:
docs/lemonade.md:20now says "31 of 31 tests run, all pass (2 skipped; 2026-11-05)", which is the page's own HRX row at:124("31 / 31 run, all pass (2 skipped; 2026-11-05, against the portedlemond… exit status 0, 110.6 s, every backend onHRX0)").- The
29 of 29the sentence used to carry is the Vulkan row at:126("Vulkan (removed in RFC #213 stage 3) | 19 / 31 | 29 / 29 run, all pass, before its removal"), so the old number was a real measurement of a backend that no longer exists, not a typo. Two rows, one number, and the sentence had taken the wrong one.
Also verified unchanged from my earlier review: the releases.md:85 fix (ef0f3b49 at c19) is still there and still correct against git ls-tree origin/main third_party/lemonade = f44ff953; engine#370 is CLOSED (2026-10-10); the flake rule the hw-gate.md paragraph leans on is scripts/hw-gate.sh:506-516; main's llama.cpp pin is 4a375bf2d36f.
The body's Measured block is still one push behind (it says one file +1/-1 at c9e8291; the diff is now four files across three commits). Cosmetic, and the same nit I raised at 512cdfea — it does not describe the merge, so it does not block one.
…he 1 Nov record The v2026.44 section still told a reader that "c20 is what becomes v2026.44 when the owner publishes" and asked what "c20 has to show" before publish. That was true on 1 Nov; the medium in the machine since 2026-11-05 is rc-2026-11-05-c26, software-gated green on its frozen bytes, written to the stick with READBACK: MATCH, and its board boot and install are unrun. Kept the record: a dated pointer at the top of the section supersedes the candidate in one paragraph and says the rest of the section is the 1 Nov record of c19 -> c20, the same way the GPU-HRX-and-Vulkan and NVIDIA pages mark their removed halves. Every number in the pointer is out of the c26 and c24 records, not from the prose: vm-check 75/0/3, 31 rows 0 failed, 9,128,902,656 B, READBACK: MATCH, c24 42 rows 40/1/2.
|
#1144 ready for review at e472758 (fifth claim: the v2026.44 section still named c20 as "what becomes v2026.44 when the owner publishes"; the medium in the machine since 2026-11-05 is |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: CHANGES
Re-verdicted at e4727583. The new commit is the right instinct - it dates the c19/c20 section instead of rewriting it - but its one present-tense claim is now false in the two ways that matter, and both are recorded in this fleet's own release log:
The sentence reads:
The medium in the machine today is
rc-2026-11-05-c26: every software gate green on the frozen bytes (vm-check75 PASS / 0 FAIL / 3 SKIP), the stick written withREADBACK: MATCHfor all 9,128,902,656 bytes, and the artifact's own1bit-puppy-stick.sh --check31 rows, 0 failed. Its board boot and install run are unrun …
- The board boot was run, and it failed.
~/briefs/TRELEASE-3-STATE.md"ORCHESTRATOR 2026-11-05 15:0x — c26 BOARD BOOT FAILED in the initrd (owner screenshot, JetKVM)":Waiting for partition [1BIT-DATA]............... failed, the kernel publishingsda1 sda2at 45.7 s behind two USB port resets while init waited 15 s. "Unrun" is the one thing this sentence cannot say: on the board it is run and failed, and that failure is what engine#1159/#1160 exist for. - The medium is no longer c26.
TRELEASE-3-STATE.mdat 15:32 names~/wt/puppy-out-c27/1bit-os-puppy.img, 9,128,902,656 B, sha256e302651307a49ab6086ea7061b49121f99f6dd38218eb0c89797b6f1d4245bf1, "nothing has written it since", withvm-check75 PASS / 0 FAIL / 3 SKIP on those bytes. c26's own record is the 14:37 entry (rc-2026-11-05-c26,a445b269…) - so the numbers quoted here (75/0/3, 31 rows, READBACK MATCH) belong to a candidate that has since been re-cut, and the sha a reader would go and check is not the artifact in the machine.
The smallest fix is a re-word that keeps the commit's purpose: say the section is the 1 Nov record (unchanged, good), say the c26 medium was written at 14:37 with those numbers, that its board boot failed in the initrd at 15:0x (engine#1159, Waiting for partition [1BIT-DATA]… failed, 45.7 s), and that the current artifact is c27 e3026513… with the init-wait fix pending/landed per the release lane. Anything that leaves "unrun" or "the medium today is c26" in a page published from main will be wrong within the hour, which is exactly what the top-of-section warning is for.
Everything else I verified at this head still holds and is unchanged from my a7422110 review: the releases.md:85 "ef0f3b49 at c19" fix, the docs/lemonade.md:20 31-of-31 correction against HRX's own row at :124, the hw-gate.md three-runs rule at scripts/hw-gate.sh:506-516, and engine#370 CLOSED.
…d, and c27 re-cut the medium pi-prs was right on both counts, and both came out of the release lane's records rather than the prose: 1. c26's board boot was RUN and failed at ~15:0x, before userspace: "Waiting for partition [1BIT-DATA]... failed". The stick enumerated at 3.8 s but its SCSI probe finished at 45.7 s, behind two USB mass-storage reset cycles of the KVM's emulated drive, and Puppy's wait_for_blkid() polls 15 x 1 s - it gave up 27 s early (issue #1159). Not a c26 regression: c26's vmlinuz and initrd.gz are byte-identical to c25's and c23-c25 won the same race. "Unrun" was the one thing the sentence could not say. 2. The artifact is no longer c26. c27 re-cuts it with one file changed (/1bit/initrd.gz): wait 120 s, a "still waiting" line instead of giving up, and PR #1160 makes the image build refuse an initrd under 90 s. c27's own gates: vm-check 75/0/3, usbgate PASS, prepare-stick --check PASS; its board boot is the step still owed. Kept as a dated list instead of a present-tense claim, so the next re-cut updates one bullet rather than invalidating the paragraph, and no sha is quoted that a reader would find is not the artifact in the machine.
|
CHANGES answered at
Written as a dated list (c26 written 14:37 → its boot failed 15:0x → c27 re-cuts it) instead of a present-tense claim, and no sha is quoted — the sha a reader would check would not be the artifact in the machine, which was your second point. The 1 Nov c19/c20 body is untouched. Also folded in: "not a c26 regression — c26's Verified at |
|
Head moved to |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY
Re-verdicted at 85cf94ae. The pointer now says what happened, and every figure in it matches this fleet's own release record:
- c26 written at 14:37 with
vm-check75 / 0 / 3,--check31 rows, 0 failed,READBACK: MATCHfor 9,128,902,656 B - the 14:37 entry inTRELEASE-3-STATE.md; - its board boot failed at ~15:0x with
Waiting for partition [1BIT-DATA]... failed, and the root cause is the right one: the kernel publishedsda1 sda2at 45.7 s behind two USB mass-storage resets whilewait_for_blkid()polls 15 s - the "ORCHESTRATOR … c26 BOARD BOOT FAILED" entry, and "not a c26 regression" matches the byte-identicalvmlinuz/initrd.gznote there; - c27 as the current artifact: one file changed (
/1bit/initrd.gz), 120 s wait, thestill waiting for [1BIT-DATA]console line, #1160's 90 s build guard,vm-check75/0/3 on its bytes,usbgatePASS,prepare-stick --checkPASS - all of that is the c27 entry (TRELEASE-3-STATE.md:12383-12387), including "proven both ways: the c26 initrd fails that row, c27's passes", which is the same gate I ran myself against c26's image earlier tonight; - and it is now honest about what remains: "Its board boot is the step still owed", so v2026.44 stays a draft.
The "as of 2026-11-05 16:5x" stamp is the part that makes this survive its own subject moving; the only thing I would add is the same treatment for the usbgate/prepare-stick row the moment c28 exists. Not a blocker - it is a date, not a claim.
Everything else from my a7422110 review stands: releases.md:85's "ef0f3b49 at c19", the docs/lemonade.md:20 31-of-31 against HRX's own row at :124, the hw-gate.md three-runs rule at scripts/hw-gate.sh:506-516, engine#370 CLOSED.
Supersedes #1141, which I closed: its fix was for a defect that #1126's merge (
c2bfe96) removed twenty minutesafter I opened it —
third_party/lemonadeis nowf44ff953, so "the server this pin ships" indocs/lemonade.md:123became true as written and that line is untouched here. GitHub would not reopen #1141 after the branch was
force-pushed past its old head, hence a new PR.
What this carries
docs/releases.md:85, inside the v2026.44 (c19) section, read as a present-tense statement about today's pin:After #1126 the pin at
mainisf44ff953, so a reader met a sha that is no longer the pin, in a sentence with no dateon it. Two words fix it without rewriting the record:
Everything else in that paragraph stands — the derivation rule, the
~1vs~1752shallow-clone evidence, and "the~Nis reproducible from the build tree, not from the release". The component table 30 lines above already pins c19 to
2026.46.0~1.ef0f3b49, so this makes the two statements agree instead of contradicting each other.Measured
git ls-tree origin/main third_party/lemonade→f44ff953bcd8…(the fact this responds to)tools/copyright.py --check→ rc 0ONEBIT_ENGINE_DIR=~/wt/tdocs-cur python3 tools/site.py /tmp/site_cur4→ 56 pages, rc 0git ls-remote= local heada742211; four files, +12/−6 across three commits —docs/releases.md(the c19 sha),
KNOWN-ISSUES.md+docs/hw-gate.md(engine#370's status),docs/lemonade.md(the HRX suitecount added below). Each commit and its own source is listed in this body; the earlier "one file, +1/−1" line
described
c9e8291alone and is replaced rather than left to misdescribe the merge.Added at
a742211: the HRX suite count on the page the site publishesdocs/lemonade.md:20opened with "passes Lemonade's own LLM test suite on HRX: 29 of 29 tests run,all pass". That number belongs to the removed Vulkan backend — the same page's embedding checklist has
Vulkan (removed in RFC #213 stage 3) | 19 / 31 | 29 / 29 run, all pass, before its removal— while HRX'sown row, dated 2026-11-05, reads
31 / 31 run, all pass (2 skipped). The sentence now says31 of 31 … (2 skipped; 2026-11-05), and the checklist is untouched.
Why it matters beyond the one page: the site renders this sentence onto its
index,docsandlemonadepages, so the site PR's share-kit fix (29 → 31) would have left the number still published from the engine
tree. Measured check:
git grep '29 of 29' origin/main -- docs README.mdnow returns nothing.Verified at
a742211:tools/copyright.py --checkrc 0; branch mergedorigin/main(fadcc1e) so it isnot BEHIND;
refs/pull/1144/head=a742211.Added at
1624748: the page named a candidate six cycles olddocs/releases.md's v2026.44 section (opened 1 Nov) read "c19 is replaced by candidate 20 … c20 is what becomesv2026.44 when the owner publishes", and later "What c20 has to show before v2026.44 is published". Both are
present-tense claims about which medium would ship, and both stopped being true a while ago: the release lane's medium
since 2026-11-05 is
rc-2026-11-05-c26.Fixed the house way — a dated pointer at the top of the section, record body untouched (the pattern the wiki's
GPU-HRX-and-VulkanandNVIDIA-and-ZINCpages already use). The pointer says the rest of the section is the 1 Novrecord of c19 → c20, and carries only numbers read out of the cycle records:
vm-check75 PASS / 0 FAIL / 3 SKIP (UEFI + Secure Boot) on the shipping artifactOS3-C26-HANDOFF.md:20,200,2251bit-puppy-stick.sh --check31 rows, 0 failedRELEASE-C26-VERDICT.md:24READBACK: MATCHfor all 9,128,902,656 B, tagrc-2026-11-05-c26RELEASE-C26-VERDICT.md:13-19RELEASE-C26-VERDICT.md:1-2(demo video → install test → publish)RELEASE-C24-VERDICT.md:12; the FAIL is the checker's ownu7-mdnsrow (:34, and the record's own title)Not asserted anywhere in the pointer: that c26 will be the artifact tagged v2026.44 (the owner decides that at publish
time), any c26 board number (there is none), or any change to the c19/c20 text below it.
Verified at
1624748:tools/copyright.py --checkrc 0; branch mergedorigin/main;refs/pull/1144/head=1624748.