Skip to content

upcoming: [DI-27518] - Resetting errors, refactor logic of TextField … - #487

Merged
santoshp210-akamai merged 5 commits into
ACLPManager:aclp_developfrom
santoshp210-akamai:bugfix/alerts-ui
Oct 8, 2025
Merged

upcoming: [DI-27518] - Resetting errors, refactor logic of TextField …#487
santoshp210-akamai merged 5 commits into
ACLPManager:aclp_developfrom
santoshp210-akamai:bugfix/alerts-ui

Conversation

@santoshp210-akamai

@santoshp210-akamai santoshp210-akamai commented Oct 3, 2025

Copy link
Copy Markdown

Description 📝

Changes 🔄

List any change(s) relevant to the reviewer.

  • Using resetField instead of setValue
  • Using string.max().concat(baseValueSchema) instead of baseValueSchema.concat(string().max())

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Include a screenshot <img src="" /> or video <video src="" /> of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 For changes requiring multiple steps to validate, prefer a video for clarity.

Before After
image image

How to test 🧪

Prerequisites

(How to setup test environment)

  • ...
  • ...

Reproduction steps

(How to reproduce the issue, if applicable)

  • ...
  • ...

Verification steps

(How to verify changes)

  • ...
  • ...
Author Checklists

As an Author, to speed up the review process, I considered 🤔

Check all that apply

  •  Use React components instead of HTML Tags
  • Proper naming conventions like cameCase for variables & Function & snake_case for constants
  • Use appropriate types & avoid using "any"
  • No type casting & non-null assertions
  • Adding a changeset
  • Providing/Improving test coverage
  • Use sx props to pass styles instead of style prop
  • Add JSDoc comments for interface properties & functions
  • Use strict equality (===) instead of double equal (==)
  • Use of named arguments (interfaces) if function argument list exceeds size 2
  • Destructure the props
  • Keep component size small & move big computing functions to separate utility
  • 📱 Providing mobile support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@santoshp210-akamai
santoshp210-akamai requested a review from a team as a code owner October 3, 2025 06:33
@santoshp210-akamai
santoshp210-akamai marked this pull request as draft October 3, 2025 06:33
@santoshp210-akamai
santoshp210-akamai marked this pull request as ready for review October 3, 2025 09:52
@santoshp210-akamai
santoshp210-akamai merged commit ce56881 into ACLPManager:aclp_develop Oct 8, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants