upcoming: [DI-27518] - Resetting errors, refactor logic of TextField … - #487
Merged
santoshp210-akamai merged 5 commits intoOct 8, 2025
Merged
Conversation
…validation for DimensionFilterValue
santoshp210-akamai
requested review from
ankita-akamai,
nikhagra-akamai and
venkymano-akamai
October 3, 2025 06:33
santoshp210-akamai
marked this pull request as draft
October 3, 2025 06:33
santoshp210-akamai
marked this pull request as ready for review
October 3, 2025 09:52
ankita-akamai
approved these changes
Oct 3, 2025
venkymano-akamai
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Changes 🔄
List any change(s) relevant to the reviewer.
resetFieldinstead ofsetValuestring.max().concat(baseValueSchema)instead ofbaseValueSchema.concat(string().max())Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
Include a screenshot
<img src="" />or video<video src="" />of the change.🔒 Use the Mask Sensitive Data setting for security.
💡 For changes requiring multiple steps to validate, prefer a video for clarity.
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
Check all that apply
As an Author, before moving this PR from Draft to Open, I confirmed ✅