upcoming: [DI-26678] - Alert Firewall dimension filters customization by santoshp210-akamai · Pull Request #12789 · linode/manager

santoshp210-akamai · 2025-09-02T12:35:18Z

Description 📝

Firewall dimension filters customization for Create/Edit/Show-details in Alerts

Changes 🔄

Custom validation for Interface IDs
Fetching different queries and transforming options for Linode, Linode Region, VPC-subnet dimension filters
Transforming linode_ids, subnet_ids to labels in show-details
Enhanced useFetchOptions to send Loading and Error states along with values
Add config map entries for Linode ID, Linode Region, VPC-Subnet filter, Interface ID filter
Relevant unit tests to test the functionalities
Mock responses to test the features

Scope 🚢

Upon production release, changes in this PR will be visible to:

All customers
Some customers (e.g. in Beta or Limited Availability)
No customers / Not applicable

Target release date 🗓️

Sept 9th

Preview 📷

Linode ID translation in Show-details

Before	After

interface_id_customisation.mp4

vpc_subnet_dimension.mp4

firewall-linode-id-region-filter.mp4

How to test 🧪

Prerequisites

(How to setup test environment)

In Mock environment , please choose Legacy MSW Handlers for Base Preset
Under Monitor, click on Alerts
For Create : Click on Create Alert button, choose the Firewall service. Please select all entities for the Linode and Linode Region values to be available. In VPC_Subnet for 'in' operator it is showing multiple values even though selected id's are 1 or 2. I suspect that it is due to the repeated id's for subnets across multiple VPC's.
For Show-Details: In the Alerts Page, Find 'Firewall - testing' alert and in action menu click on Show Details
For Edit: In the Alerts Page, Find 'Firewall - testing' alert and in action menu click on Edit. Please select all entites for the Linode and Linode Region values to be available.In VPC_Subnet for 'in' operator it is showing multiple values even though only 2 id's are passed. I suspect that it is due to the repeated id's for subnets across multiple VPC's.

Verification steps

(How to verify changes)

Linode dimension filter is filtering the parent linode entity from the selected entities and the supportedRegion of the account and showing the relevant options.
Linode Region dimension filter is filtering the parent linode entity from the selected entities and the supportedRegion of the account and showing the relevant options.
VPC Subnet dimension filter is transforming the values and displaying similarly as shown in the preview
Interface dimension filter is validation the inputs properly. (Similar to configuration dimension filter validation from nodebalancer service)
The translation of linode_id, subnet_id to the relevant labels in Show-details

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All tests and CI checks are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

…lerts

santoshp210-akamai · 2025-09-02T12:38:13Z

Few changes from ValueSchema.ts included in this PR are already part of a previous PR: #12771.

Around 250+ lines of code changes are for mock testing, utils and tests.

santoshp210-akamai · 2025-09-02T19:14:02Z

~~Although I have not directly changed anything related to the AlertReusableComponent, the UT is failing. Will work on it and fix the fix for that UT failure.~~

I have pushed the fix

… component

…red util

dwiley-akamai · 2025-09-03T17:33:57Z

+    threshold: 1000,
+    dimension_filters: [
+      {
+        label: 'VPC-Subnet',


Suggested change

label: 'VPC-Subnet',

label: 'VPC Subnet',

I think we should remove any instances where the dash appears as we don't use "VPC-Subnet" anywhere else in the application

I am using the same labels that we currently receive from the firewall/metric-definitions API call for mocks as well.

dwiley-akamai · 2025-09-03T20:00:12Z

+export const getResolvedDimensionValue = (
+  dimensionFilterKey: string,
+  dimensionOperator: DimensionFilterOperatorType,
+  value: null | string | undefined,
+  serviceType: CloudPulseServiceType,
+  linodeMap: Record<string, string>,
+  vpcSubnetMap: Record<string, string>,
+  transformationAllowedOperators: DimensionFilterOperatorType[]
+): string => {


With this many parameters, it would be better to have the function accept an object. It will also help prevent the wrong thing from being passed in the wrong slot (which could happen with, for example, linodeMap and vpcSubnetMap in the current implementation).

@dwiley-akamai , All of the logic initially was in the RenderAlertsMetricsAndDimensions component directly. Created this separated util to handle logic and keep the component clean and simple.

As of now there are no requirements that will require us to make further use of this component. But if we have to, we will consider this feedback and create a Interface for them in the upcoming PRs.

fwiw I second this bc it makes the code more readable at first glance. For example re the below image, it might not be clear at first what some of the arguments like 'linode-c, linode-d', 'firewall', etc are for

@coliu-akamai ,Sure will make it a prop interface and push the change.

…g from constants

coliu-akamai

question with Linode Region dimension filter - should we consider using a region select for cases when the filter is equal, not equal, or in?

Seeing this error appear some times - I haven't been able to get clear replicating steps, but it once appeared when I changed the Operator type and then backspaced in the Value field

ankita-akamai · 2025-09-04T15:44:27Z

@santoshp210-akamai there are some conflicts due to recent merge, they need to be resolved. I also see serverhandler changes being pushed, please remove them.

santoshp210-akamai · 2025-09-04T16:11:40Z

@coliu-akamai , For the Linode Region filter we want to provide the functionality of choosing the options currently. We are not sure to make it a RegionFilter as of now and it wasn't in the scope of this particular ticket. If we plan it , it will be part of a future PR.

linode-gh-bot · 2025-09-04T17:16:31Z

Cloud Manager UI test results

🔺 1 failing test on test run #13 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`1 Failing`	`737 Passing`	`6 Skipped`	`43m 56s`

Details

Failing Tests
	Spec	Test
❌	`open-support-ticket.spec.ts`	Cloud Manager Cypress Tests→open support tickets » can create a support ticket with an entity

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/helpAndSupport/open-support-ticket.spec.ts"

santoshp210-akamai · 2025-09-04T17:59:45Z

Pushed this commit 0e51a78 which has the following changes

//Previous implementation
const baseValueSchema = string()
  .nullable()
  .required(fieldErrorMessage)
  .test('nonEmpty', fieldErrorMessage, (value) => value !== null);

As @coliu-akamai pointed out, we encountered a special case where when the operator is selected and backspace is pressed it is showing us the default yup schema error message.

And it was happening only when the operator was changed to starts with/ends with because those are the cases where the Value component is a TextField and upon operator change we typically reset the value to null (Because in Autocomplete use-cases we use null when resetting and intializing).

So currently transforming the value to '' if it's null, to test value !== '' .

//Current implementation
 const baseValueSchema = string()
 .nullable()
 .transform((value) => (value === null ? '' : value)) // normalize null to empty string to avoid the empty string case for TextField components
 .required(fieldErrorMessage)
 .test('nonEmpty', fieldErrorMessage, (value) => value !== '');

This transformation is allowing it to display the proper error message.

Will create a ticket to investigate the cause of this further and improve the validation schemas overall in the future PR's

coliu-akamai

Confirming that for the filters, things are matching the preview videos

Linode dimension filter
Linode Region dimension filter
VPC Subnet dimension filter
Interface dimension filter validates inputs properly as expected
translation of linode_id, subnet_id to the relevant labels in Show-details

We spoke async about the validation issue I mentioned earlier + it will be followed up on

…onValue util

coliu-akamai · 2025-09-04T19:07:34Z

closing in favor of #12817

santoshp210-akamai added 2 commits September 2, 2025 17:45

upcoming: [DI-26678] - Firewall dimension filters customization for A…

e465cc7

…lerts

upcoming: [DI-26678] - Mocks for testing

45d0015

santoshp210-akamai requested a review from a team as a code owner September 2, 2025 12:35

santoshp210-akamai requested review from bnussman-akamai and harsh-akamai and removed request for a team September 2, 2025 12:35

github-project-automation Bot added this to Cloud Manager Sep 2, 2025

github-project-automation Bot moved this to Review in Cloud Manager Sep 2, 2025

santoshp210-akamai changed the title ~~upcoming: [DI-26678] - Mocks for testing~~ upcoming: [DI-26678] - Alert Firewall dimension filters customization Sep 2, 2025

santoshp210-akamai self-assigned this Sep 2, 2025

santoshp210-akamai added Cloud Pulse Cloud Pulse - Alerting labels Sep 2, 2025

santoshp210-akamai requested review from a team, coliu-akamai, dwiley-akamai, nikhagra-akamai and venkymano-akamai and removed request for a team September 2, 2025 12:36

santoshp210-akamai added the 🚨 Urgent label Sep 2, 2025

santoshp210-akamai added 2 commits September 2, 2025 18:09

add changeset

8935958

upcoming: [DI-26678] - Fix typo

2c7654e

santoshp210-akamai requested a review from jaalah-akamai September 2, 2025 13:13

venkymano-akamai reviewed Sep 2, 2025

View reviewed changes

Comment thread ...ges/manager/src/features/CloudPulse/Alerts/AlertsDetail/RenderAlertsMetricsAndDimensions.tsx Outdated

venkymano-akamai reviewed Sep 2, 2025

View reviewed changes

Comment thread ...ges/manager/src/features/CloudPulse/Alerts/AlertsDetail/RenderAlertsMetricsAndDimensions.tsx

venkymano-akamai reviewed Sep 3, 2025

View reviewed changes

Comment thread ...ges/manager/src/features/CloudPulse/Alerts/AlertsDetail/RenderAlertsMetricsAndDimensions.tsx Outdated

santoshp210-akamai added 2 commits September 3, 2025 12:42

upcoming: [DI-26678] - Tidying up the RenderAlertsMetricAndDimensions…

4ceb8b4

… component

Merge branch 'develop' into feature/firewall-dimension-filters

0cfda30

venkymano-akamai approved these changes Sep 3, 2025

View reviewed changes

santoshp210-akamai added 3 commits September 3, 2025 16:07

Merge branch 'develop' into feature/firewall-dimension-filters

0d9f959

upcoming: [DI-26678] - destructuring dimension object in isCheckRequi…

06dbadf

…red util

Merge branch 'develop' into feature/firewall-dimension-filters

804444e

dwiley-akamai reviewed Sep 3, 2025

View reviewed changes

santoshp210-akamai added 3 commits September 4, 2025 17:27

upcoming: [DI-26678] - removing unnecessary prop drilling by importin…

6a943a4

…g from constants

remove unused import

c2b2377

Merge branch 'develop' into feature/firewall-dimension-filters

9c564c9

coliu-akamai reviewed Sep 4, 2025

View reviewed changes

merging latest linode/develop, resolve conflicts

396ebcf

upcoming: [DI-26678] - fixing the default error message bug

0e51a78

coliu-akamai approved these changes Sep 4, 2025

View reviewed changes

github-project-automation Bot moved this from Review to Approved in Cloud Manager Sep 4, 2025

santoshp210-akamai added 2 commits September 4, 2025 23:37

Merge branch 'develop' into feature/firewall-dimension-filters

69f74d2

upcoming: [DI-26678] - using a prop interface for the resolvedDimensi…

f71cf5c

…onValue util

coliu-akamai added the Do Not Merge label Sep 4, 2025

coliu-akamai mentioned this pull request Sep 4, 2025

upcoming: [DI-26678] - Alert Firewall dimension filters customization #12817

Merged

12 tasks

coliu-akamai closed this Sep 4, 2025

github-project-automation Bot moved this from Approved to Merged in Cloud Manager Sep 4, 2025

This was referenced Oct 3, 2025

upcoming: [DI-27518] - Resetting errors, refactor logic of TextField … ACLPManager/manager#487

Merged

upcoming: [DI-21578] - Resetting errors in Alert form #12968

Merged

Uh oh!

Conversation

santoshp210-akamai commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Changes 🔄

Scope 🚢

Target release date 🗓️

Preview 📷

Linode ID translation in Show-details

How to test 🧪

Prerequisites

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

santoshp210-akamai commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

santoshp210-akamai commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dwiley-akamai Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

santoshp210-akamai Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

dwiley-akamai Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

santoshp210-akamai Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coliu-akamai Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

santoshp210-akamai Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

coliu-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

ankita-akamai commented Sep 4, 2025

Uh oh!

santoshp210-akamai commented Sep 4, 2025

Uh oh!

linode-gh-bot commented Sep 4, 2025

Cloud Manager UI test results

🔺 1 failing test on test run #13 ↗︎

Details

Troubleshooting

Uh oh!

santoshp210-akamai commented Sep 4, 2025

Uh oh!

coliu-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

coliu-akamai commented Sep 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

santoshp210-akamai commented Sep 2, 2025 •

edited

Loading

santoshp210-akamai commented Sep 2, 2025 •

edited

Loading

santoshp210-akamai commented Sep 2, 2025 •

edited

Loading

santoshp210-akamai Sep 3, 2025 •

edited

Loading

coliu-akamai Sep 4, 2025 •

edited

Loading