This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Repository navigation
Add purchased + reposted tracks to library PAY-1633 - #3820
Merged
Merged
Conversation
nicoback2
requested review from
a team and
Kyle-Shanks
and removed request for
a team and
Kyle-Shanks
July 28, 2023 23:57
nicoback2
commented
Jul 28, 2023
| @@ -0,0 +1,191 @@ | |||
| import { | |||
Contributor
Author
There was a problem hiding this comment.
screencapture-mail-google-mail-u-0-2023-07-28-16_54_40.pdf
^converted .js to .ts - here is the diff
rickyrombo
reviewed
Jul 29, 2023
Contributor
There was a problem hiding this comment.
Looks like we need latest sdk update!
JK just reread the description and saw #3819
| encodedDataSignature: signature | ||
| } | ||
| )) as any | ||
| const savedTracksResponseData = savedTracksResponse.data as APIActivityV2[] |
Contributor
There was a problem hiding this comment.
Bummer that we have to cast this. Would be a great use case for satisfies when our codebase supports it.
Contributor
Author
There was a problem hiding this comment.
yeah agreed, i think @piazzatron was gonna try to update the API so that the SDK is able to type the response fully!
rickyrombo
approved these changes
Jul 31, 2023
nicoback2
added a commit
that referenced
this pull request
Jul 31, 2023
This reverts commit 8dc4c8a.
nicoback2
added a commit
that referenced
this pull request
Jul 31, 2023
nicoback2
added a commit
that referenced
this pull request
Jul 31, 2023
Co-authored-by: Nikki Kang <kangaroo233@gmail.com>
schottra
added a commit
that referenced
this pull request
Jul 31, 2023
…onts * origin/main: [C-2857] Revert remove get blocknumber (#3802)" (#3826) [C-2742] Multi-track form pagination (#3818) Bump mobile versions for client v1.5.35 full app release (#3827) Revert "Add purchased + reposted tracks to library PAY-1633 (#3820)" (#3825) Add purchased + reposted tracks to library PAY-1633 (#3820) Update SDK version + ActivityFull type (#3819)
schottra
added a commit
that referenced
this pull request
Aug 1, 2023
* origin/main: Update userbank function usage to pass config object (#3823) Update dapp-store build artifacts [C-2857] Revert remove get blocknumber (#3802)" (#3826) [C-2742] Multi-track form pagination (#3818) Bump mobile versions for client v1.5.35 full app release (#3827) Revert "Add purchased + reposted tracks to library PAY-1633 (#3820)" (#3825) Add purchased + reposted tracks to library PAY-1633 (#3820) Update SDK version + ActivityFull type (#3819) Use audius-query in USDC Purchase Drawer (#3822) Update bootstrap nodes (#3821) [PAY-1589] Wire up Stripe Onramp in mobile (#3814) v1.5.35 Add favorite test and fix aria-label (#3817) [C-2908 C-2744] fix desktop follow button (#3816)
nicoback2
added a commit
that referenced
this pull request
Aug 3, 2023
Co-authored-by: Nikki Kang <kangaroo233@gmail.com>
audius-infra
pushed a commit
that referenced
this pull request
Aug 5, 2023
[f9e1380] Add DirectMessages Banner and Update All Banners (#3851) Marcus Pasell [e523d39] [PAY-1692] Rewrite 'Share to DMs' using less stateful logic (#3852) Marcus Pasell [af62892] [C-2675][C-2692] Add multi track navigation sidebar and form controls (#3847) Andrew Mendelsohn [ee38400] Fix send audio flow (#3850) Reed [bd1752b] Update SDK to latest 3.0.3-beta.109 (#3849) nicoback2 [6988a03] Add npm run clean script (#3846) Reed [68bd638] DMs: Web: Don't nav back when clicking outside the modal (#3844) Marcus Pasell [1f7d7d0] Add prepare step to dapp-store ci flow (#3841) Raymond Jacobson [6c87efd] [Harmony] Add SelectablePill to Harmony PAY-1654 (#3803) nicoback2 [69fbfb3] [PAY-1688] Mobile: Share track, collection to DMs (#3840) Marcus Pasell [f2f9717] Disable upload redesign (#3842) Andrew Mendelsohn [9671c06] Update dapp-store build artifacts audius-infra [77b4030] Update dapp-store build artifacts audius-infra [baedc13] Fix dapp store deployment (#3829) Raymond Jacobson [bcb5137] [C-2907] Add contextual-menu, refactor release-date-field (#3836) Dylan Jeffers [df90566] [PAY-1687] Web: Share tracks, playlists, and albums via Direct Message (#3828) Marcus Pasell [ec16cc3] Upgrade sdk to beta.105 to fix rewards claiming (#3839) Dylan Jeffers [270cc2f] [C-2923] Fix toasts in modal screens (#3838) Dylan Jeffers [18616df] Add cypress upload test for subgenre (#3833) Raymond Jacobson [8a76f7c] [PAY-1685] Wire up stripe UI for USDC purchase in mobile (#3837) Reed [6337949] Fix broken track upload for electronic subgenres on mobile (#3835) nicoback2 [f643695] Fix tag input (#3832) Andrew Mendelsohn [5da8e8f] Update userbank function usage to pass config object (#3823) Randy Schott [8a5419d] Update dapp-store build artifacts audius-infra [6284c14] [C-2857] Revert remove get blocknumber (#3802)" (#3826) Dylan Jeffers [6a54b3a] [C-2742] Multi-track form pagination (#3818) Andrew Mendelsohn [65471a1] Bump mobile versions for client v1.5.35 full app release (#3827) nicoback2 [6c88515] Revert "Add purchased + reposted tracks to library PAY-1633 (#3820)" (#3825) nicoback2 [8dc4c8a] Add purchased + reposted tracks to library PAY-1633 (#3820) nicoback2 [5ddf078] Update SDK version + ActivityFull type (#3819) nicoback2 [c643b8a] Use audius-query in USDC Purchase Drawer (#3822) Reed [a119db1] Update bootstrap nodes (#3821) Theo Ilie [d2630a8] [PAY-1589] Wire up Stripe Onramp in mobile (#3814) Reed
nicoback2
added a commit
that referenced
this pull request
Aug 23, 2023
Co-authored-by: Nikki Kang <kangaroo233@gmail.com>
nicoback2
added a commit
that referenced
this pull request
Aug 31, 2023
Co-authored-by: Nikki Kang <kangaroo233@gmail.com>
nicoback2
added a commit
that referenced
this pull request
Sep 1, 2023
Co-authored-by: Nikki Kang <kangaroo233@gmail.com>
nicoback2
added a commit
that referenced
this pull request
Sep 8, 2023
Co-authored-by: Nikki Kang <kangaroo233@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds full library tracks to Library page (no filters yet). Works on web, mobile, and mobile web. Also converts the SavedPage saga to TS.
Note reposting or purchasing a track does not add it to the page immediately yet; this is a future task
Companion in main: #3819
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.