Skip to content
This repository was archived by the owner on Oct 4, 2023. It is now read-only.

[C-2675][C-2692] Add multi track navigation sidebar and form controls - #3847

Merged
amendelsohn merged 10 commits into
mainfrom
amendel-multi-track-navigation
Aug 3, 2023
Merged

[C-2675][C-2692] Add multi track navigation sidebar and form controls#3847
amendelsohn merged 10 commits into
mainfrom
amendel-multi-track-navigation

Conversation

@amendelsohn

@amendelsohn amendelsohn commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

Description

Adds

  • Floating sidebar navigation component to switch between tracks
  • Header and footer when in multi-track mode on edit form w/navigation buttons
  • HarmonyButtonType.PLAIN for buttons with only text + icon

Feature Flags

UPLOAD_REDESIGN_ENABLED

@amendelsohn amendelsohn changed the title Add multi track navigation sidebar and form controls [C-2675] Add multi track navigation sidebar and form controls Aug 2, 2023
@amendelsohn amendelsohn changed the title [C-2675] Add multi track navigation sidebar and form controls [C-2675][C-2692] Add multi track navigation sidebar and form controls Aug 2, 2023
@audius-infra

audius-infra commented Aug 2, 2023

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/amendel-multi-track-navigation

dylanjeffers
dylanjeffers approved these changes Aug 3, 2023
View reviewed changes

@dylanjeffers dylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an incredible pr, so much work and it's all so clean.

Comment thread packages/stems/src/components/HarmonyButton/HarmonyButton.module.css
Comment thread packages/stems/src/components/HarmonyButton/HarmonyButton.module.css
border: none;
border-radius: 0;
padding: 0;
height: 100%;

@dylanjeffers dylanjeffers Aug 3, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need height?

@amendelsohn amendelsohn Aug 3, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah at least I didn't find another way to prevent this. I think because the other buttons want that vertical space to push the border out? Couldn't figure out what was creating it though.
image

Comment thread packages/web/src/pages/upload-page/components/EditPageNew.module.css Outdated
Comment thread packages/web/src/pages/upload-page/components/EditPageNew.module.css Outdated
Comment thread packages/web/src/pages/upload-page/components/EditPageNew.tsx
Comment thread packages/web/src/pages/upload-page/fields/MultiTrackSidebar.tsx
Comment thread packages/web/src/pages/upload-page/fields/MultiTrackSidebar.tsx
Comment thread packages/web/src/pages/upload-page/fields/MultiTrackSidebar.tsx
Comment thread packages/web/src/pages/upload-page/fields/MultiTrackSidebar.tsx Outdated
Comment thread packages/web/src/pages/upload-page/fields/MultiTrackSidebar.tsx Outdated
@audius-infra

audius-infra commented Aug 3, 2023

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/amendel-multi-track-navigation

@pull-request-size pull-request-size Bot added size/XL and removed size/L labels Aug 3, 2023
@amendelsohn
amendelsohn merged commit af62892 into main Aug 3, 2023
@amendelsohn
amendelsohn deleted the amendel-multi-track-navigation branch August 3, 2023 22:29
audius-infra pushed a commit that referenced this pull request Aug 5, 2023
audius-infra
v1.5.36
bb99113 
[f9e1380] Add DirectMessages Banner and Update All Banners (#3851) Marcus Pasell
[e523d39] [PAY-1692] Rewrite 'Share to DMs' using less stateful logic (#3852) Marcus Pasell
[af62892] [C-2675][C-2692] Add multi track navigation sidebar and form controls (#3847) Andrew Mendelsohn
[ee38400] Fix send audio flow (#3850) Reed
[bd1752b] Update SDK to latest 3.0.3-beta.109 (#3849) nicoback2
[6988a03] Add npm run clean script (#3846) Reed
[68bd638] DMs: Web: Don't nav back when clicking outside the modal (#3844) Marcus Pasell
[1f7d7d0] Add prepare step to dapp-store ci flow (#3841) Raymond Jacobson
[6c87efd] [Harmony] Add SelectablePill to Harmony PAY-1654 (#3803) nicoback2
[69fbfb3] [PAY-1688] Mobile: Share track, collection to DMs (#3840) Marcus Pasell
[f2f9717] Disable upload redesign (#3842) Andrew Mendelsohn
[9671c06] Update dapp-store build artifacts audius-infra
[77b4030] Update dapp-store build artifacts audius-infra
[baedc13] Fix dapp store deployment (#3829) Raymond Jacobson
[bcb5137] [C-2907] Add contextual-menu, refactor release-date-field (#3836) Dylan Jeffers
[df90566] [PAY-1687] Web: Share tracks, playlists, and albums via Direct Message (#3828) Marcus Pasell
[ec16cc3] Upgrade sdk to beta.105 to fix rewards claiming (#3839) Dylan Jeffers
[270cc2f] [C-2923] Fix toasts in modal screens (#3838) Dylan Jeffers
[18616df] Add cypress upload test for subgenre (#3833) Raymond Jacobson
[8a76f7c] [PAY-1685] Wire up stripe UI for USDC purchase in mobile (#3837) Reed
[6337949] Fix broken track upload for electronic subgenres on mobile (#3835) nicoback2
[f643695] Fix tag input (#3832) Andrew Mendelsohn
[5da8e8f] Update userbank function usage to pass config object (#3823) Randy Schott
[8a5419d] Update dapp-store build artifacts audius-infra
[6284c14] [C-2857] Revert remove get blocknumber (#3802)" (#3826) Dylan Jeffers
[6a54b3a] [C-2742] Multi-track form pagination (#3818) Andrew Mendelsohn
[65471a1] Bump mobile versions for client v1.5.35 full app release (#3827) nicoback2
[6c88515] Revert "Add purchased + reposted tracks to library PAY-1633  (#3820)" (#3825) nicoback2
[8dc4c8a] Add purchased + reposted tracks to library PAY-1633  (#3820) nicoback2
[5ddf078] Update SDK version + ActivityFull type (#3819) nicoback2
[c643b8a] Use audius-query in USDC Purchase Drawer (#3822) Reed
[a119db1] Update bootstrap nodes (#3821) Theo Ilie
[d2630a8] [PAY-1589] Wire up Stripe Onramp in mobile (#3814) Reed
schottra added a commit that referenced this pull request Aug 8, 2023
@schottra
Merge remote-tracking branch 'origin/main' into pay-1630-purchase-sagas
cf3e4a4 
* origin/main:
  Add nodes to env for SEO support (#3859)
  [C-2941] Modify cloudflare worker to pull in SEO data from discovery nodes (#3858)
  [C-2879] Add validation to single track upload flow (#3855)
  [C-2940] Update google analytics tags and fix embed build (#3856)
  [C-2852 PLAT-1094 PLAT-1093] Add fetch collection by permalink (#3751)
  v1.5.36
  Add DirectMessages Banner and Update All Banners (#3851)
  [PAY-1692] Rewrite 'Share to DMs' using less stateful logic (#3852)
  [C-2675][C-2692] Add multi track navigation sidebar and form controls (#3847)
  Fix send audio flow (#3850)
  Update SDK to latest 3.0.3-beta.109 (#3849)
@AudiusProject AudiusProject deleted a comment from linear Bot Sep 11, 2023
@AudiusProject AudiusProject deleted a comment from linear Bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Kyle-Shanks Kyle-Shanks Awaiting requested review from Kyle-Shanks
1 more reviewer
@dylanjeffers dylanjeffers dylanjeffers approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amendelsohn @audius-infra @dylanjeffers