This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Repository navigation
[C-2852 PLAT-1094 PLAT-1093] Add fetch collection by permalink - #3751
Merged
Merged
Conversation
Collaborator
|
Preview this change https://demo.audius.co/dj-c-2852-fix-hidden-playlist-slug |
Contributor
|
thank you so much dylan!!! i have one question - when i look at https://demo.audius.co/dj-c-2852-fix-hidden-playlist-slug/ray/playlist/a-playlist-testing-slugs-492987202, since i just created this playlist, shouldn't the new slug also work? it leads to a blank page for me https://demo.audius.co/dj-c-2852-fix-hidden-playlist-slug/ray/playlist/a-playlist-testing-slugs |
dylanjeffers
requested review from
a team and
Kyle-Shanks
and removed request for
a team
July 17, 2023 21:33
Contributor
|
scenarios i tested:
things i want to cover:
|
Collaborator
|
Preview this change https://demo.audius.co/dj-c-2852-fix-hidden-playlist-slug |
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 688750 | Generic High Entropy Secret | 4333ae5 | packages/mobile/.env.dev | View secret |
| 688750 | Generic High Entropy Secret | 4333ae5 | packages/mobile/.env.prod | View secret |
| 2460749 | Generic High Entropy Secret | 4333ae5 | packages/mobile/.env.prod | View secret |
| 2858198 | Generic High Entropy Secret | 4333ae5 | packages/mobile/.env.prod | View secret |
| 688750 | Generic High Entropy Secret | 4333ae5 | packages/mobile/.env.stage | View secret |
| 2416684 | Generic High Entropy Secret | 4333ae5 | packages/mobile/.env.stage | View secret |
| 2858199 | Generic High Entropy Secret | 4333ae5 | packages/mobile/.env.stage | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Collaborator
|
Preview this change https://demo.audius.co/dj-c-2852-fix-hidden-playlist-slug |
Collaborator
|
Preview this change https://demo.audius.co/dj-c-2852-fix-hidden-playlist-slug |
Collaborator
|
Preview this change https://demo.audius.co/dj-c-2852-fix-hidden-playlist-slug |
schottra
added a commit
that referenced
this pull request
Aug 8, 2023
* origin/main: Add nodes to env for SEO support (#3859) [C-2941] Modify cloudflare worker to pull in SEO data from discovery nodes (#3858) [C-2879] Add validation to single track upload flow (#3855) [C-2940] Update google analytics tags and fix embed build (#3856) [C-2852 PLAT-1094 PLAT-1093] Add fetch collection by permalink (#3751) v1.5.36 Add DirectMessages Banner and Update All Banners (#3851) [PAY-1692] Rewrite 'Share to DMs' using less stateful logic (#3852) [C-2675][C-2692] Add multi track navigation sidebar and form controls (#3847) Fix send audio flow (#3850) Update SDK to latest 3.0.3-beta.109 (#3849)
audius-infra
pushed a commit
that referenced
this pull request
Aug 12, 2023
[3436c20] [PAY-1701] Fix "Share to DMs" to work through InboxUnavailableModal (#3874) Marcus Pasell [a740243] Add sdk:update-hotfix (#3875) Dylan Jeffers [a25fd19] [C-2759] Make donation link external (#3872) Dylan Jeffers [15f056c] [PAY-1630] Wire up purchase content sagas (#3834) Randy Schott [998d44b] Fix mobile crash on drawer dismiss (#3871) Reed [7d0e0b3] [PAY-1430] "Leaving Audius" Warning for External Links (and createModal helper) (#3860) Marcus Pasell [bee8bd1] Remove .only on upload cypress test (#3869) Raymond Jacobson [4c0b25f] [C-2926] Implement selected values for upload contextual menu fields (#3848) Dylan Jeffers [5773578] Preserve CIDs for track and collection cover arts (#3866) Marcus Pasell [be0d278] [C-2930] Fix extra space after username in tip to unlock modal (#3845) nicoback2 [f5320be] QA-588 Fix collection card profile link (#3853) nicoback2 [360416e] Fix broken playlist fetch via resolve (#3863) Raymond Jacobson [2dc2c29] [PAY-1695] DMs: Entrypoint Analytics (#3862) Marcus Pasell [f80d366] Minor improvements to SEO flow merged in #3859 (#3861) Raymond Jacobson [b99d62f] Add nodes to env for SEO support (#3859) Raymond Jacobson [20476ee] [C-2941] Modify cloudflare worker to pull in SEO data from discovery nodes (#3858) Raymond Jacobson [7f79830] [C-2879] Add validation to single track upload flow (#3855) Kyle Shanks [6f4fc89] [C-2940] Update google analytics tags and fix embed build (#3856) Raymond Jacobson [3469c89] [C-2852 PLAT-1094 PLAT-1093] Add fetch collection by permalink (#3751) Dylan Jeffers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds feature to fetch collection by permalink. This should not be enabled in prod until a few fixes roll out in the coming weeks.