[C-2926] Implement selected values for upload contextual menu fields by dylanjeffers · Pull Request #3848 · AudiusProject/audius-client

dylanjeffers · 2023-08-03T15:24:42Z

Description

Adds selected values for each of the upload contextual menu fields.

audius-infra · 2023-08-03T15:49:19Z

Preview this change https://demo.audius.co/dj-c-2926-selected-value

amendelsohn

Really nice! Love the renderValue pattern!

amendelsohn · 2023-08-03T19:04:37Z

    ? {
        ...styleProp,
-        '--icon-color': toCSSVariableName(color)
+        '--icon-color': `var(${toCSSVariableName(color)})`


omg is that why it wasn't working?

yeah fairly tragic, lol

amendelsohn · 2023-08-03T19:06:11Z

@@ -1,5 +1,5 @@
 .root {
-  gap: var(--unit-2);
+  gap: var(--unit-4);


We do have cn(layoutStyles.col, layoutStyles.gap4) for this. Unsure if it's worth doing when we also have custom styling. Though we could also include padding if we do a Box or similar. No need to change here, but just gathering use cases for layout patterns.

amendelsohn · 2023-08-03T19:10:46Z

+              <div className={styles.advancedOptions}>
+                <ReleaseDateField />
+                <RemixSettingsField />
+                <SourceFilesField />
+                <AccessAndSaleField />
+                <AttributionField />
+              </div>


Nice! I like pulling them straight in here. The name advancedOptions doesn't resonate but I don't think I have a better one

yeah agreed id like a better name, something we can consider with product team during our qa runthroughs imo, make sure we understand each section and what its intent is, maybe additionalOptions?

amendelsohn · 2023-08-03T19:12:18Z

-export const TrackAvailabilityModalForm = () => {
+export const AccessAndSaleField = () => {
  // Fields from the outer form
-  const [{ value: isUnlistedValue }, , { setValue: setIsUnlistedValue }] =


yeah that's more readable. Ty!

amendelsohn · 2023-08-03T19:18:04Z

-        <Text className={styles.title} variant='title' size='large'>
-          {messages.title}
-        </Text>
+  const renderValue = useCallback(() => {


dang so many cases

amendelsohn · 2023-08-03T19:27:11Z

+/**
+ * This is a subform that expects to exist within a parent TrackEdit form.
+ * The useField calls reference the outer form's fields which much match the name constants.
+ */


Can we update this now that we have ContextualMenu? Maybe now the comment goes on the fields component?

amendelsohn · 2023-08-03T19:31:34Z

+  display: flex;
+  flex-direction: column;
+  gap: var(--unit-6);


layoutStyles

amendelsohn · 2023-08-03T19:34:18Z

-      <Text>{messages.description}</Text>
-    </div>
-  )
+  const renderValue = () => {


seems like there are multiple values a lot of the time.
Should this be renderValues or do we consider the whole ContextualMenu to be one 'Field' with a single composite 'value' per the name of this file?

yeah defintely agree with thoughts here. "value" was chosen cause each field has a value like you said, but could see using language like "renderSelectedLabels" which would be in line with what the mockups are saying. That would require changing a bunch of the component names too which im totally down. for also. ill make a tech-debt story to start collecting these great ideas.

amendelsohn · 2023-08-03T19:35:25Z

  display: flex;
  flex-direction: column;
-  gap: var(--unit-2);
+  gap: var(--unit-4);


layoutStyles

amendelsohn · 2023-08-03T20:00:01Z

 import { moodMap } from 'utils/Moods'

-import { getTrackFieldName } from '../forms/utils'
+import { getTrackFieldName } from '../hooks'


I know I did this, but feels weird to import a regular function from a hooks file 🤔

gitguardian · 2023-08-10T06:06:57Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	Secret	Commit	Filename
1606949	Generic High Entropy Secret	`d826b16`	packages/web/.env/.env.prod	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

* origin/main: [C-2926] Implement selected values for upload contextual menu fields (#3848) Preserve CIDs for track and collection cover arts (#3866)

[3436c20] [PAY-1701] Fix "Share to DMs" to work through InboxUnavailableModal (#3874) Marcus Pasell [a740243] Add sdk:update-hotfix (#3875) Dylan Jeffers [a25fd19] [C-2759] Make donation link external (#3872) Dylan Jeffers [15f056c] [PAY-1630] Wire up purchase content sagas (#3834) Randy Schott [998d44b] Fix mobile crash on drawer dismiss (#3871) Reed [7d0e0b3] [PAY-1430] "Leaving Audius" Warning for External Links (and createModal helper) (#3860) Marcus Pasell [bee8bd1] Remove .only on upload cypress test (#3869) Raymond Jacobson [4c0b25f] [C-2926] Implement selected values for upload contextual menu fields (#3848) Dylan Jeffers [5773578] Preserve CIDs for track and collection cover arts (#3866) Marcus Pasell [be0d278] [C-2930] Fix extra space after username in tip to unlock modal (#3845) nicoback2 [f5320be] QA-588 Fix collection card profile link (#3853) nicoback2 [360416e] Fix broken playlist fetch via resolve (#3863) Raymond Jacobson [2dc2c29] [PAY-1695] DMs: Entrypoint Analytics (#3862) Marcus Pasell [f80d366] Minor improvements to SEO flow merged in #3859 (#3861) Raymond Jacobson [b99d62f] Add nodes to env for SEO support (#3859) Raymond Jacobson [20476ee] [C-2941] Modify cloudflare worker to pull in SEO data from discovery nodes (#3858) Raymond Jacobson [7f79830] [C-2879] Add validation to single track upload flow (#3855) Kyle Shanks [6f4fc89] [C-2940] Update google analytics tags and fix embed build (#3856) Raymond Jacobson [3469c89] [C-2852 PLAT-1094 PLAT-1093] Add fetch collection by permalink (#3751) Dylan Jeffers

dylanjeffers added 6 commits August 2, 2023 16:24

[C-2926] Implement menu fields preview

5165439

Implement source files field

4fb0d5b

Implement access and sale fields

a91822b

Implement attribution preview

65386ba

Simplify contextual menu

802e7a2

undo the flag

da59cd4

pull-request-size Bot added the size/XXL label Aug 3, 2023

dylanjeffers requested review from a team, Kyle-Shanks and amendelsohn and removed request for a team August 3, 2023 15:24

amendelsohn approved these changes Aug 3, 2023

View reviewed changes

dylanjeffers added 3 commits August 9, 2023 23:01

merge the stuff

d826b16

Revert locks

667f4a9

Address type errors

687b03a

Merge branch 'main' into dj-c-2926-selected-value

4e9b6eb

dylanjeffers merged commit 4c0b25f into main Aug 10, 2023

dylanjeffers deleted the dj-c-2926-selected-value branch August 10, 2023 06:13

AudiusProject deleted a comment from linear Bot Sep 11, 2023

Conversation

dylanjeffers commented Aug 3, 2023

Description

Uh oh!

audius-infra commented Aug 3, 2023

Uh oh!

amendelsohn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dylanjeffers Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gitguardian Bot commented Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dylanjeffers Aug 10, 2023 •

edited

Loading

gitguardian Bot commented Aug 10, 2023 •

edited

Loading