This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Repository navigation
[PAY-1701] Fix "Share to DMs" to work through InboxUnavailableModal - #3874
Merged
Merged
Conversation
…ns, and use them in InboxUnavailableModal to pass the create chat action
rickyrombo
assigned
raymondjacobson,
dylanjeffers,
Kyle-Shanks,
dharit-tan,
sddioulde and
schottra
Collaborator
|
Preview this change https://demo.audius.co/mjp-dms-share-2 |
raymondjacobson
approved these changes
Aug 12, 2023
| ) => { | ||
| const dispatch = useDispatch() | ||
| const [, setCreateChatVisible] = useModalState('CreateChat') | ||
| const { onOpen: openCreateChatModal } = useCreateChatModal() |
Member
There was a problem hiding this comment.
it's a little weird that this is called onOpen versus open
Contributor
Author
There was a problem hiding this comment.
I feel the same way about onClose, should I change them to open and close?
Member
There was a problem hiding this comment.
ye i think so, but ok if in sep pr for me
| yield* put( | ||
| fetchPermissions({ userIds: [sender.user_id, recipient.user_id] }) | ||
| ) | ||
| if (onSuccessConfirmedAction) { |
Collaborator
|
Preview this change https://demo.audius.co/mjp-dms-share-2 |
nicoback2
approved these changes
Aug 12, 2023
nicoback2
left a comment
nicoback2
left a comment
Contributor
There was a problem hiding this comment.
Nicee LGTM! no need to make changes before merging but left some comments
Collaborator
|
Preview this change https://demo.audius.co/mjp-dms-share-2 |
audius-infra
pushed a commit
that referenced
this pull request
Aug 12, 2023
[3436c20] [PAY-1701] Fix "Share to DMs" to work through InboxUnavailableModal (#3874) Marcus Pasell [a740243] Add sdk:update-hotfix (#3875) Dylan Jeffers [a25fd19] [C-2759] Make donation link external (#3872) Dylan Jeffers [15f056c] [PAY-1630] Wire up purchase content sagas (#3834) Randy Schott [998d44b] Fix mobile crash on drawer dismiss (#3871) Reed [7d0e0b3] [PAY-1430] "Leaving Audius" Warning for External Links (and createModal helper) (#3860) Marcus Pasell [bee8bd1] Remove .only on upload cypress test (#3869) Raymond Jacobson [4c0b25f] [C-2926] Implement selected values for upload contextual menu fields (#3848) Dylan Jeffers [5773578] Preserve CIDs for track and collection cover arts (#3866) Marcus Pasell [be0d278] [C-2930] Fix extra space after username in tip to unlock modal (#3845) nicoback2 [f5320be] QA-588 Fix collection card profile link (#3853) nicoback2 [360416e] Fix broken playlist fetch via resolve (#3863) Raymond Jacobson [2dc2c29] [PAY-1695] DMs: Entrypoint Analytics (#3862) Marcus Pasell [f80d366] Minor improvements to SEO flow merged in #3859 (#3861) Raymond Jacobson [b99d62f] Add nodes to env for SEO support (#3859) Raymond Jacobson [20476ee] [C-2941] Modify cloudflare worker to pull in SEO data from discovery nodes (#3858) Raymond Jacobson [7f79830] [C-2879] Add validation to single track upload flow (#3855) Kyle Shanks [6f4fc89] [C-2940] Update google analytics tags and fix embed build (#3856) Raymond Jacobson [3469c89] [C-2852 PLAT-1094 PLAT-1093] Add fetch collection by permalink (#3751) Dylan Jeffers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Might be useful to look at commit by commit
CreateChatModalto use thecreateModalhelper, making this easierInboxUnavailableModalto usecreateModalhelper, making this easierSearchUserModalto not take amodalNameetc and just acceptisOpenonSuccessandonSuccessConfirmedwhich are used to navigate the user to the chat and create the chat respectively in the InboxUnavailable flow.Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Tested E2E on web against stage. Mobile has a slightly different impl, looking at that next and will try to unify
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.