Skip to content

chore: tsconfig deduplication - #142

Closed
ludamad wants to merge 37 commits into
masterfrom
adam/chore/tsconfig-refactor-2
Closed

chore: tsconfig deduplication#142
ludamad wants to merge 37 commits into
masterfrom
adam/chore/tsconfig-refactor-2

Conversation

@ludamad

@ludamad ludamad commented Mar 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

A few small quality of life improvements to tsconfig management
Provides utilities to derive package.json, tsconfig.json and build_manifest.json from scanning imports as well as reducing the amount of tsconfig.json files

The tsconfig.json file at the base is used by tests and vscode. It needs to hold all project references

tsconfig.base.json at the base is used for grouping common compilerOptions

There is now one tsconfig.dest.json per folder, but no tsconfig.json (which is only at the root - vscode looks for this exact name)

Just call yarn prepare after importing new dependencies to fix project references, package.json and build_manifest.json

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

ludamad
ludamad commented Mar 31, 2023
View reviewed changes
Comment thread build_manifest.json Outdated
"rebuildPatterns": [
"^yarn-project/ethereum.js/"
],
"dependencies": [

@ludamad ludamad Mar 31, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, this isn't good

spalladino
spalladino approved these changes Mar 31, 2023
View reviewed changes
Comment thread circuits

@spalladino spalladino Mar 31, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep any updates to submodules out of this PR (if possible)

@ludamad ludamad Mar 31, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake, but all too easy to make

Comment thread scripts/derive-package-deps.py
ts_files = filter(lambda f: "example" not in str(f), ts_files)

# Regular expression pattern to match import statements from @aztec packages
import_regex = r'^import.*from.*@aztec/([a-zA-Z0-9\-\._]+)'

@spalladino spalladino Mar 31, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only bit that makes me nervous!

@ludamad ludamad Mar 31, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair :D

@ludamad

ludamad commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator Author

This ended up a rabbit hole - punting for now : (

@ludamad ludamad closed this Mar 31, 2023
ludamad pushed a commit that referenced this pull request Apr 14, 2023
@dbanks12
bump generators for wasm in bberg (#142)
5b336c5
ludamad pushed a commit that referenced this pull request Apr 17, 2023
@dbanks12 @ludamad
bump generators for wasm in bberg (#142)
7d0dee8
ludamad pushed a commit that referenced this pull request Apr 17, 2023
@dbanks12 @ludamad
bump generators for wasm in bberg (#142)
76019ca
ludamad added a commit that referenced this pull request Jul 14, 2023
@suyash67 @dbanks12
@iAmMichaelConnor dbanks12 @spalladino @ludamad @Maddiaa0 cheethas
Aztec3 Specific Work in Barretenberg (#142)
c3d461f 
* Split Pedersen Hash & Commitment Gadgets (#95)

* [SQUASHED] Pedersen refactor into hash and commitment.

Use lookup pedersen for merkle tree, fixed-base pedersen for commitments.
---------
Co-authored-by: Suyash Bagad <suyashnbagad1997@gmail.com>

Port `copy_as_new_witness`.

Port `must_imply`.

`operator++`.

Port changes from `common`.

Port `ecc/groups`.

* [CPM] add missing dependencies to libbarretenberg.a (#154)
---------

* Increase Pedersen Generator indices and subindices. (#169)

* Remove a3 specific types. (#252)

* Address Luke's Comments on `aztec3 -> master` (#263)

* Add must_imply tests.

* Added a test for `field_t::copy_as_new_witness`

* add test for `conditional_assign`

* Added `infinity` test.

* Add `add_affine_test`.

* Tests for Array Object in `stdlib` (#262)

* basic array tests.

* Add `composer_type` while hashing/compressing a vkey.

* Add `contains_recursive_proof` to Recursive VK (#268)

* feat: debug utility for serialization (#290)

* feat: enable asan config

* `array_push` for Generic Type (#291)

* Add Indexed Merkle Tree  (#281)

* remove ts (consulted with Adam and we're good to go). (#292)

* Add cout for verification_key struct (#295)

* compute tree (#298)

* [SQUASHED] fixing `push_array_to_array` method. (#304)

* feat(memory_tree|a3): add sibling path calculations (#301)

* feat(memory_tree): frontier paths

* fix array and resolve merge conflicts (#305)

* Mc/hash vk (#306)

* Increase number of sub-generators to 128.

* Build a3crypto.wasm (#311)

* More Tests on A3 `stdlib` methods (#316)

* test: more vk tests to compare circuit/native/vk_data (#310)

* Mc/hash vk (#306)

* inc num_generators_per_hash_index to 128. (#309)

* fix. (#318)

* Added test for `compute_tree_native`. (#319)

* Install instructions for apt on ubuntu (#312)

* Fix address compilation. (#329)

---------

Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com>
Co-authored-by: Michael Connor <mike@aztecprotocol.com>
Co-authored-by: dbanks12 <david@aztecprotocol.com>
Co-authored-by: Santiago Palladino <spalladino@gmail.com>
Co-authored-by: ludamad <adam.domurad@gmail.com>
Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com>
Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>
Co-authored-by: ludamad <domuradical@gmail.com>
Co-authored-by: cheethas <urmasurda@gmail.com>
@ludamad
ludamad deleted the adam/chore/tsconfig-refactor-2 branch July 14, 2023 23:02
codygunton pushed a commit that referenced this pull request Jan 23, 2024
@suyash67 @dbanks12
@iAmMichaelConnor dbanks12 @spalladino @ludamad @Maddiaa0 cheethas
Aztec3 Specific Work in Barretenberg (#142)
2c569cf 
* Split Pedersen Hash & Commitment Gadgets (#95)

* [SQUASHED] Pedersen refactor into hash and commitment.

Use lookup pedersen for merkle tree, fixed-base pedersen for commitments.
---------
Co-authored-by: Suyash Bagad <suyashnbagad1997@gmail.com>

Port `copy_as_new_witness`.

Port `must_imply`.

`operator++`.

Port changes from `common`.

Port `ecc/groups`.

* [CPM] add missing dependencies to libbarretenberg.a (#154)
---------

* Increase Pedersen Generator indices and subindices. (#169)

* Remove a3 specific types. (#252)

* Address Luke's Comments on `aztec3 -> master` (#263)

* Add must_imply tests.

* Added a test for `field_t::copy_as_new_witness`

* add test for `conditional_assign`

* Added `infinity` test.

* Add `add_affine_test`.

* Tests for Array Object in `stdlib` (#262)

* basic array tests.

* Add `composer_type` while hashing/compressing a vkey.

* Add `contains_recursive_proof` to Recursive VK (#268)

* feat: debug utility for serialization (#290)

* feat: enable asan config

* `array_push` for Generic Type (#291)

* Add Indexed Merkle Tree  (#281)

* remove ts (consulted with Adam and we're good to go). (#292)

* Add cout for verification_key struct (#295)

* compute tree (#298)

* [SQUASHED] fixing `push_array_to_array` method. (#304)

* feat(memory_tree|a3): add sibling path calculations (#301)

* feat(memory_tree): frontier paths

* fix array and resolve merge conflicts (#305)

* Mc/hash vk (#306)

* Increase number of sub-generators to 128.

* Build a3crypto.wasm (#311)

* More Tests on A3 `stdlib` methods (#316)

* test: more vk tests to compare circuit/native/vk_data (#310)

* Mc/hash vk (#306)

* inc num_generators_per_hash_index to 128. (#309)

* fix. (#318)

* Added test for `compute_tree_native`. (#319)

* Install instructions for apt on ubuntu (#312)

* Fix address compilation. (#329)

---------

Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com>
Co-authored-by: Michael Connor <mike@aztecprotocol.com>
Co-authored-by: dbanks12 <david@aztecprotocol.com>
Co-authored-by: Santiago Palladino <spalladino@gmail.com>
Co-authored-by: ludamad <adam.domurad@gmail.com>
Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com>
Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>
Co-authored-by: ludamad <domuradical@gmail.com>
Co-authored-by: cheethas <urmasurda@gmail.com>
@AztecBot AztecBot mentioned this pull request Mar 13, 2026
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spalladino spalladino spalladino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ludamad @spalladino