Skip to content

Modularize Aztec TX - #95

Merged
LeilaWang merged 8 commits into
masterfrom
sp/tx
Mar 28, 2023
Merged

Modularize Aztec TX#95
LeilaWang merged 8 commits into
masterfrom
sp/tx

Conversation

@spypsy

@spypsy spypsy commented Mar 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description

  • Create Tx package in yarn-project
  • Remove remaining .yalc folder & references

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@spypsy
spypsy requested a review from LeilaWang March 28, 2023 15:32
@LeilaWang
LeilaWang merged commit 08a17f2 into master Mar 28, 2023
@charlielye
charlielye deleted the sp/tx branch March 28, 2023 21:19
ludamad added a commit that referenced this pull request Jul 14, 2023
@suyash67 @dbanks12
@iAmMichaelConnor dbanks12 @spalladino @ludamad @Maddiaa0 cheethas
Aztec3 Specific Work in Barretenberg (#142)
c3d461f 
* Split Pedersen Hash & Commitment Gadgets (#95)

* [SQUASHED] Pedersen refactor into hash and commitment.

Use lookup pedersen for merkle tree, fixed-base pedersen for commitments.
---------
Co-authored-by: Suyash Bagad <suyashnbagad1997@gmail.com>

Port `copy_as_new_witness`.

Port `must_imply`.

`operator++`.

Port changes from `common`.

Port `ecc/groups`.

* [CPM] add missing dependencies to libbarretenberg.a (#154)
---------

* Increase Pedersen Generator indices and subindices. (#169)

* Remove a3 specific types. (#252)

* Address Luke's Comments on `aztec3 -> master` (#263)

* Add must_imply tests.

* Added a test for `field_t::copy_as_new_witness`

* add test for `conditional_assign`

* Added `infinity` test.

* Add `add_affine_test`.

* Tests for Array Object in `stdlib` (#262)

* basic array tests.

* Add `composer_type` while hashing/compressing a vkey.

* Add `contains_recursive_proof` to Recursive VK (#268)

* feat: debug utility for serialization (#290)

* feat: enable asan config

* `array_push` for Generic Type (#291)

* Add Indexed Merkle Tree  (#281)

* remove ts (consulted with Adam and we're good to go). (#292)

* Add cout for verification_key struct (#295)

* compute tree (#298)

* [SQUASHED] fixing `push_array_to_array` method. (#304)

* feat(memory_tree|a3): add sibling path calculations (#301)

* feat(memory_tree): frontier paths

* fix array and resolve merge conflicts (#305)

* Mc/hash vk (#306)

* Increase number of sub-generators to 128.

* Build a3crypto.wasm (#311)

* More Tests on A3 `stdlib` methods (#316)

* test: more vk tests to compare circuit/native/vk_data (#310)

* Mc/hash vk (#306)

* inc num_generators_per_hash_index to 128. (#309)

* fix. (#318)

* Added test for `compute_tree_native`. (#319)

* Install instructions for apt on ubuntu (#312)

* Fix address compilation. (#329)

---------

Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com>
Co-authored-by: Michael Connor <mike@aztecprotocol.com>
Co-authored-by: dbanks12 <david@aztecprotocol.com>
Co-authored-by: Santiago Palladino <spalladino@gmail.com>
Co-authored-by: ludamad <adam.domurad@gmail.com>
Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com>
Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>
Co-authored-by: ludamad <domuradical@gmail.com>
Co-authored-by: cheethas <urmasurda@gmail.com>
codygunton pushed a commit that referenced this pull request Jan 23, 2024
@suyash67 @dbanks12
@iAmMichaelConnor dbanks12 @spalladino @ludamad @Maddiaa0 cheethas
Aztec3 Specific Work in Barretenberg (#142)
2c569cf 
* Split Pedersen Hash & Commitment Gadgets (#95)

* [SQUASHED] Pedersen refactor into hash and commitment.

Use lookup pedersen for merkle tree, fixed-base pedersen for commitments.
---------
Co-authored-by: Suyash Bagad <suyashnbagad1997@gmail.com>

Port `copy_as_new_witness`.

Port `must_imply`.

`operator++`.

Port changes from `common`.

Port `ecc/groups`.

* [CPM] add missing dependencies to libbarretenberg.a (#154)
---------

* Increase Pedersen Generator indices and subindices. (#169)

* Remove a3 specific types. (#252)

* Address Luke's Comments on `aztec3 -> master` (#263)

* Add must_imply tests.

* Added a test for `field_t::copy_as_new_witness`

* add test for `conditional_assign`

* Added `infinity` test.

* Add `add_affine_test`.

* Tests for Array Object in `stdlib` (#262)

* basic array tests.

* Add `composer_type` while hashing/compressing a vkey.

* Add `contains_recursive_proof` to Recursive VK (#268)

* feat: debug utility for serialization (#290)

* feat: enable asan config

* `array_push` for Generic Type (#291)

* Add Indexed Merkle Tree  (#281)

* remove ts (consulted with Adam and we're good to go). (#292)

* Add cout for verification_key struct (#295)

* compute tree (#298)

* [SQUASHED] fixing `push_array_to_array` method. (#304)

* feat(memory_tree|a3): add sibling path calculations (#301)

* feat(memory_tree): frontier paths

* fix array and resolve merge conflicts (#305)

* Mc/hash vk (#306)

* Increase number of sub-generators to 128.

* Build a3crypto.wasm (#311)

* More Tests on A3 `stdlib` methods (#316)

* test: more vk tests to compare circuit/native/vk_data (#310)

* Mc/hash vk (#306)

* inc num_generators_per_hash_index to 128. (#309)

* fix. (#318)

* Added test for `compute_tree_native`. (#319)

* Install instructions for apt on ubuntu (#312)

* Fix address compilation. (#329)

---------

Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com>
Co-authored-by: Michael Connor <mike@aztecprotocol.com>
Co-authored-by: dbanks12 <david@aztecprotocol.com>
Co-authored-by: Santiago Palladino <spalladino@gmail.com>
Co-authored-by: ludamad <adam.domurad@gmail.com>
Co-authored-by: Maddiaa <47148561+cheethas@users.noreply.github.com>
Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>
Co-authored-by: ludamad <domuradical@gmail.com>
Co-authored-by: cheethas <urmasurda@gmail.com>
This was referenced Jun 23, 2026
Merged
Merged
PhilWindle added a commit that referenced this pull request Jun 23, 2026
@PhilWindle
fix(spartan): fund sponsored FPC in block-capacity bench env (#24248)
484e63f 
## Problem

The nightly `block-capacity-benchmark` job has been failing fast (~5
min) with every transaction rejected:

```
Invalid tx: Insufficient fee payer balance (required=507345496560000, available=0)
```

All 8 benchmark cases fail on the first `send`. The build succeeds and
the network is reachable — this is purely a genesis-funding problem.

## Root cause

`block_capacity.test.ts` pays **all** fees through
`SponsoredFeePaymentMethod` (account deploys, mints, transfers). The fee
payer is therefore the sponsored FPC, not the worker wallets. But
`spartan/environments/block-capacity.env` never set
`SPONSORED_FPC=true`, so the network was deployed **without funding the
sponsored FPC at genesis** — its fee-juice balance is `available=0`, so
no tx can be paid for.

Every other bench env already sets this flag (`tps-scenario`,
`bench-10tps`, `prove-n-tps-fake`, `prove-n-tps-real`, `next-scenario`);
`block-capacity.env` was the only one missing it. `network-defaults.yml`
documents the flag as *"Fund sponsored FPC with fee juice"*.

## Fix

Add `SPONSORED_FPC=true` to `block-capacity.env`.

Found while investigating the failures in nightly Spartan Benchmarks run
#95.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeilaWang LeilaWang Awaiting requested review from LeilaWang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spypsy @LeilaWang