Skip to content

feat: merge-train/barretenberg - #20941

Merged
AztecBot merged 13 commits into
nextfrom
merge-train/barretenberg
Feb 27, 2026
Merged

feat: merge-train/barretenberg#20941
AztecBot merged 13 commits into
nextfrom
merge-train/barretenberg

Conversation

@AztecBot

@AztecBot AztecBot commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

BEGIN_COMMIT_OVERRIDE
chore: cleanup polynomials module (#20585)
fix: splitting scalars edge case (#20686)
feat: parallelize ACIR parsing and decompression (#20873)
END_COMMIT_OVERRIDE

Cleanup and minor changes in the polynomial module. 

Changes:
- Delete unused methods in `univariate_coefficient_basis.hpp`
    -  `is_zero`
    - `random_element`
    - `to_buffer`
    - `serialize_from_buffer`
    - `size`
    - `get_random`
 - Delete unused methods in `polynomial.hpp/cpp`
    - `clear()`
    - `right_shifted()`
    - `debug_hash()`
    - `compute_barycentric_evaluation()`
    -  `in_place_operation_viable`
    -  overload of evaluate `evaluate(const Fr& z, size_t target_size)`
  - Delete unused methods in `polynomial_arithmetic.hpp/cpp`
    - `compute_multiplicative_subgroup`
    - `compute_barycentric_evaluation `
- `fft`, `coset_fft`, unused overloads of `fft_inner_parallel` and
`ifft`
- Delete unused `compute_generator_table` and `four_inverse` in
`evaluation_domain.hpp`
- Fixed `_allocate_aligned_memory` call to pass element count (`n_l`)
instead of byte size.
- Add new tests in `barycentric.test.cpp` covering the `stdlib` runtime
path
- Deduplicate compile-time and runtime `BarycentricData` logic via a
shared base class (resolves TODO
[#674](AztecProtocol/barretenberg#674))
notnotraju and others added 12 commits February 27, 2026 12:57
Fixes an edge case in the `split_into_endomorphism_scalars` method. Adds
detailed documentation for the algorithm in the form of a literate
python program and regression tests for EC edge cases and
`biggroup_goblin`.

---------

Co-authored-by: notnotraju <raju@aztec-labs.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
## Summary

- Parallelizes `PrivateExecutionSteps::parse()` — deserializes each
step's ACIR bytecode and witness data in parallel using `parallel_for`
- Parallelizes `PrivateExecutionStepRaw::load_and_decompress()` —
decompresses gzip data for each step in parallel

Closes #1395

[ClaudeBox
log](http://ci.aztec-labs.com/6987e2365fae49247e056cb7a95c3578)

@ludamad ludamad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Auto-approved

@AztecBot
AztecBot enabled auto-merge February 27, 2026 19:12
@AztecBot

Copy link
Copy Markdown
Collaborator Author

🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass.

@AztecBot
AztecBot added this pull request to the merge queue Feb 27, 2026
@AztecBot

Copy link
Copy Markdown
Collaborator Author

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/fa76025193f7b131�fa76025193f7b1318;;�): yarn-project/end-to-end/scripts/run_test.sh ha src/composed/ha/e2e_ha_full.test.ts (115s) (code: 0)

@AztecBot

Copy link
Copy Markdown
Collaborator Author

🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass.

Merged via the queue into next with commit 17d3acd Feb 27, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants