fix(ci3): GITHUB_REPOSITORY unbound when running ci.sh locally - #24059
Merged
Conversation
…locally
The repo-scoped instance name added `repo=${GITHUB_REPOSITORY##*/}` followed by
`repo=${repo:-aztec-packages}`. Under `set -u` (set by ci3/source), the `##*/`
expansion on an unset GITHUB_REPOSITORY aborts before the default on the next line
applies — so any local `./ci.sh <cmd>` fails with "GITHUB_REPOSITORY: unbound
variable". It only surfaced locally; CI always has GITHUB_REPOSITORY set.
Default first, then strip: `repo=${GITHUB_REPOSITORY:-aztec-packages}; repo=${repo##*/}`.
Same fix in ci.sh and ci3/bootstrap_ec2.
charlielye
added a commit
that referenced
this pull request
Jun 12, 2026
…xt) (#24060) Port of the unbound-variable fix (see #24059). The repo-scoped instance name added `repo=${GITHUB_REPOSITORY##*/}` then `repo=${repo:-aztec-packages}`. Under `set -u` (set by `ci3/source`), `##*/` on an unset `GITHUB_REPOSITORY` aborts before the default applies, so any local `./ci.sh <cmd>` fails with `GITHUB_REPOSITORY: unbound variable`. CI always has it set, so it passed there. Fix: default first, then strip — `repo=${GITHUB_REPOSITORY:-aztec-packages}; repo=${repo##*/}` — in `ci.sh` and `ci3/bootstrap_ec2`. Instance-name scheme unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression
The cross-repo instance-name fix (#23987) added to
ci.shandci3/bootstrap_ec2:Under
set -u(set byci3/source), the##*/expansion on an unsetGITHUB_REPOSITORYaborts before the:-aztec-packagesdefault on the next line can apply. So any local invocation fails immediately:It only bit locally — CI always has
GITHUB_REPOSITORYset, so it passed there.Fix
Default first, then strip:
Applied in both
ci.shandci3/bootstrap_ec2. Verified underset -uwith the var unset: resolves toaztec-packages(andAztecProtocol/aztec-packages→aztec-packageswhen set), so the instance-name scheme is unchanged.