fix(ci3): GITHUB_REPOSITORY unbound when running ci.sh locally (v5-next) - #24060
Merged
Conversation
…locally
The repo-scoped instance name added `repo=${GITHUB_REPOSITORY##*/}` followed by
`repo=${repo:-aztec-packages}`. Under `set -u` (set by ci3/source), the `##*/`
expansion on an unset GITHUB_REPOSITORY aborts before the default on the next line
applies — so any local `./ci.sh <cmd>` fails with "GITHUB_REPOSITORY: unbound
variable". It only surfaced locally; CI always has GITHUB_REPOSITORY set.
Default first, then strip: `repo=${GITHUB_REPOSITORY:-aztec-packages}; repo=${repo##*/}`.
Same fix in ci.sh and ci3/bootstrap_ec2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of the unbound-variable fix (see #24059).
The repo-scoped instance name added
repo=${GITHUB_REPOSITORY##*/}thenrepo=${repo:-aztec-packages}. Underset -u(set byci3/source),##*/on an unsetGITHUB_REPOSITORYaborts before the default applies, so any local./ci.sh <cmd>fails withGITHUB_REPOSITORY: unbound variable. CI always has it set, so it passed there.Fix: default first, then strip —
repo=${GITHUB_REPOSITORY:-aztec-packages}; repo=${repo##*/}— inci.shandci3/bootstrap_ec2. Instance-name scheme unchanged.