docs(aztec-nr): document partial note completion trust model - #24816
Merged
Conversation
nchamo
added
ci-draft
nchamo
marked this pull request as ready for review
July 20, 2026 16:47
nventuro
reviewed
Jul 20, 2026
nventuro
approved these changes
Jul 21, 2026
This was referenced Jul 21, 2026
6 tasks
rangozd
pushed a commit
to rangozd/aztec-packages
that referenced
this pull request
Aug 5, 2026
…otocol#24816) ## Summary - Documents the trust model of partial note completion on `PartialUintNote` and `PartialNFTNote`: - The validity commitment only proves that the contract created the partial note designating `completer`. - The storage slot and value/token id are trusted arguments, not bound by the commitment. - The completer is not authenticated by the check itself, so contracts must pass `msg_sender()` as `completer`. - Adds a WARNING that completion is not single-use: the designated completer can complete the same partial note any number of times, so contracts must make every completion independently paid for or authorized in the completing function (as the token and NFT contracts already do). - Fixes doc overclaims that said the validity commitment verifies the storage slot / state variable. (cherry picked from commit 1879ac1)
rangozd
pushed a commit
to rangozd/aztec-packages
that referenced
this pull request
Aug 5, 2026
…ztecProtocol#24931) Forward-ports the **noir / aztec-nr / contracts** slice of the v5-next → next backlog (work merged to `v5-next` after the ~2026-07-08 cut that reshaped `next`). ## Applied (clean cherry-picks, chronological) - fix: prevent reception of messages too far into the future (AztecProtocol#24645) - fix(aztec-nr): reject infinity ephemeral key in message encryption (AztecProtocol#24665) - fix(aztec-nr): tolerate malformed partial-note completion logs (AztecProtocol#24668) - docs(aztec-nr): document partial note completion trust model (AztecProtocol#24816) - refactor(aztec-nr): shared no-op sync handler for stateless contracts (AztecProtocol#24844) - fix: dont panic on note msgs on contracts with no notes (AztecProtocol#24852) - docs(noir-contracts): document standard-contract re-pin consequences (AztecProtocol#24890) ##⚠️ Needs owner conflict-resolution (conflict against reshaped `next`; not included here) Cherry-pick onto this branch and resolve: - [ ] `git cherry-pick -x 9f1167e` — feat!: make inbox secrets be multiple fields (AztecProtocol#24599) - [ ] `git cherry-pick -x 4490597` — fix(aztec-nr): prevent recipient forging a colliding handshake (AztecProtocol#24403) - [ ] `git cherry-pick -x 8b1903c` — feat!: forbid external note validation checks (AztecProtocol#24644) - [ ] `git cherry-pick -x 10e339a` — fix(aztec-nr)!: compute note property selectors from the packed layout (AztecProtocol#24689) - [ ] `git cherry-pick -x 15c7a1e` — chore: clarify scope of packable impl detection (AztecProtocol#24820) - [ ] `git cherry-pick -x f66808c` — fix: change init and single claim nullif to incl owner address, add testing utilities (AztecProtocol#24892) Part of the manual v5-next → next backlog sweep. Draft until conflicts are resolved and CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PartialUintNoteandPartialNFTNote:completer.msg_sender()ascompleter.