Skip to content

docs(noir-contracts): document standard-contract re-pin consequences - #24890

Merged
nchamo merged 2 commits into
merge-train/fairies-v5from
nchamo/repin-comment
Jul 21, 2026
Merged

nchamo merged 2 commits into
merge-train/fairies-v5from
nchamo/repin-comment

Conversation

@nchamo

@nchamo nchamo commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Expand the comment on pin-standard-build to spell out what re-pinning the standard contracts implies: it moves their canonical deterministic addresses and class ids, which are baked into every deployed network and published package, so it is only correct as part of a coordinated redeploy.
  • Add a <standard_contract_repin> rule to the root CLAUDE.md making explicit that a re-pin is a deliberate human decision, never an automatic follow-up to a source or bytecode change: the pin exists so those changes do not move the addresses, and CI does not fail when the bytecode drifts.

@nchamo nchamo self-assigned this Jul 21, 2026
@nchamo nchamo added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure labels Jul 21, 2026
@nchamo
nchamo requested a review from nventuro July 21, 2026 17:39
@nchamo
nchamo marked this pull request as ready for review July 21, 2026 17:39
Comment thread noir-projects/noir-contracts/bootstrap.sh Outdated
@nchamo
nchamo enabled auto-merge (squash) July 21, 2026 18:59
@nchamo
nchamo merged commit 7e29a2d into merge-train/fairies-v5 Jul 21, 2026
12 checks passed
@nchamo
nchamo deleted the nchamo/repin-comment branch July 21, 2026 19:28
rangozd pushed a commit to rangozd/aztec-packages that referenced this pull request Aug 5, 2026
rangozd pushed a commit to rangozd/aztec-packages that referenced this pull request Aug 5, 2026
…ztecProtocol#24931)

Forward-ports the **noir / aztec-nr / contracts** slice of the v5-next →
next backlog (work merged to `v5-next` after the ~2026-07-08 cut that
reshaped `next`).

## Applied (clean cherry-picks, chronological)
- fix: prevent reception of messages too far into the future (AztecProtocol#24645)
- fix(aztec-nr): reject infinity ephemeral key in message encryption
(AztecProtocol#24665)
- fix(aztec-nr): tolerate malformed partial-note completion logs
(AztecProtocol#24668)
- docs(aztec-nr): document partial note completion trust model (AztecProtocol#24816)
- refactor(aztec-nr): shared no-op sync handler for stateless contracts
(AztecProtocol#24844)
- fix: dont panic on note msgs on contracts with no notes (AztecProtocol#24852)
- docs(noir-contracts): document standard-contract re-pin consequences
(AztecProtocol#24890)

## ⚠️ Needs owner conflict-resolution (conflict against reshaped `next`;
not included here)
Cherry-pick onto this branch and resolve:
- [ ] `git cherry-pick -x 9f1167e` — feat!: make inbox secrets be
multiple fields (AztecProtocol#24599)
- [ ] `git cherry-pick -x 4490597` — fix(aztec-nr): prevent recipient
forging a colliding handshake (AztecProtocol#24403)
- [ ] `git cherry-pick -x 8b1903c` — feat!: forbid external note
validation checks (AztecProtocol#24644)
- [ ] `git cherry-pick -x 10e339a` — fix(aztec-nr)!: compute note
property selectors from the packed layout (AztecProtocol#24689)
- [ ] `git cherry-pick -x 15c7a1e` — chore: clarify scope of packable
impl detection (AztecProtocol#24820)
- [ ] `git cherry-pick -x f66808c` — fix: change init and single
claim nullif to incl owner address, add testing utilities (AztecProtocol#24892)

Part of the manual v5-next → next backlog sweep. Draft until conflicts
are resolved and CI is green.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants