feat: check existence of vk in contract tree - #167
Merged
Merged
Conversation
…g merkle tree membership calls)
dbanks12
force-pushed
the
mc/check-vk-exists-in-contract-tree
branch
from
April 6, 2023 02:35
c3a161e to
580540d
Compare
added 2 commits
April 6, 2023 02:43
…af all the way to function root and then to contract root
dbanks12
marked this pull request as ready for review
April 6, 2023 20:45
Contributor
Author
|
Looks good! Thanks for taking this over, and for the simple root_from_sibling_path function. Would be nice to refactor the bberg Merkle Tree code to a few simple functions one day. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note: added acir_hash to the PrivateCallData struct - this will need to be mirrored in the TypeScript struct.
Checklist:
/specshave been updated.@briefdescribing the intended functionality.