feat: Kernel fix & test improvements/refactoring - #239
Merged
Conversation
added 9 commits
April 12, 2023 17:09
…nit arrays of frs
…gic in test setup for computing function/contract tree roots/siblings
dbanks12
marked this pull request as ready for review
April 13, 2023 17:50
Comment on lines
+96
to
+97
| // TODO: this fails intermittently, with: | ||
| // bigfield multiply range check failed |
Contributor
There was a problem hiding this comment.
I think this TODO has been fixed, so this comment can be removed.
dbanks12
commented
Apr 13, 2023
| NT::Proof mock_kernel_proof = mock_kernel_prover.construct_proof(); | ||
| // info("\nmock_kernel_proof: ", mock_kernel_proof.proof_data); | ||
|
|
||
| std::shared_ptr<NT::VK> mock_kernel_vk = mock_kernel_composer.compute_verification_key(); |
Contributor
Author
There was a problem hiding this comment.
@iAmMichaelConnor this is the big chunk we should be able to remove once we have the special kernel version for the initial iteration. Won't need to compute the mock kernel anymore.
iAmMichaelConnor
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Status
Blocked by chore: zero-initialize all structs & their members and arrays #233Needs to be rebased on master which will be some work.Need to comment helper functions in hash.hpp.Contents
std::functiontype to write functions that accept any circuit function as input.Checklist:
/specshave been updated.@briefdescribing the intended functionality.