WIP: Add page for hide sensitive info - #112
Conversation
|
|
||
| The hide icon / button, which is usually displayed within close reach of the balance itself, is used to quickly and easily hide and reveal wallet information by tapping or clicking on it. | ||
|
|
||
|  |
There was a problem hiding this comment.
Can you consider making this a bit bigger as it's difficult to know what to look at without zooming in, especially on mobile?
There was a problem hiding this comment.
Good point! I will work on this
|
|
||
| ## Consider removing the hide toggle from the homepage | ||
|
|
||
| Having the show/hide button right on the main screen make things quite obvious for someone who has access to your device to press unhide. A solution would be to move the hide toggle away from the home screen and into the app settings. This way, if someone has access to your device and opens the app, they may not immediately know how to reveal the hidden information as it is not as obvious as the previous solutions. |
There was a problem hiding this comment.
Might be worth also including what information will be hidden as well.
There was a problem hiding this comment.
Alright, that's noted
pavlenex
left a comment
There was a problem hiding this comment.
Congratulations and thanks for your first PR. 🎉
Although for me it's a bit hard to see in which context this will be related to the payment guide, it's certainly great piece of information. As payment guide progresses, we may be able to agree on the structure of content, but since we still don't have the context, we can change that if needed in the future.
I've made a few minor suggestions and added a few recommendations mostly around content simplification and a bit too informal language used on two places.
|
|
||
| Cons | ||
|
|
||
| - It may be annoying having to repeatedly put in your min when ever you want to reveal your information especially if you do so often |
There was a problem hiding this comment.
- It may be annoying having to repeatedly put in your min when ever you want to reveal your information especially if you do so often
Too informal imo. Annoying, also unsure what this means put in your min when ever you want to reveal your information
|
|
||
| # Hiding Sensitive Information | ||
|
|
||
| Imagine this scenario. You are in a public place, and you need to make a payment using your bitcoin wallet. You open your wallet on your phone, but you don’t feel comfortable having your address and balance information clearly visible to strangers who may be looking over your shoulder. Hence by giving users the ability to hide sensitive information in their wallet if desired, they gain an added sense of privacy and security when using the app in public. |
There was a problem hiding this comment.
clearly visible to strangers who may be looking over your shoulder
Video surveillance can be another attack vector to add
There was a problem hiding this comment.
That makes an excellent point! considering that video surveillance is quite common nowadays.
|
|
||
| ## Why is this pattern important to designers? | ||
|
|
||
| Privacy in bitcoin payments goes far beyond hiding balances and other sensitive information, the privacy by design framework states that privacy should be incorporated and built into products by default. This way, whether or not the user is concerned with their data privacy, they would always be protected through good UX. |
There was a problem hiding this comment.
through good UX.
Perhaps UI?
There was a problem hiding this comment.
Do we have a good resource we can link to for "privacy by design framework"? If we mention a framework, we should make it easy to read up on it.
There was a problem hiding this comment.
This one might be okay - https://www.ipc.on.ca/wp-content/uploads/Resources/7foundationalprinciples.pdf
|
|
||
| ## Entering a pin to unveil information | ||
|
|
||
| A problem that seemed to arise throughout each implementation was that is was as easy to reverse the hidden state as it was to enable it. This may be for convenience sake, however, if you are in a situation where you are concerned about unauthorized access by someone who has your device, once hidden perhaps you should be only able to unhide if a PIN or password has been entered. This could therefore reaffirm the identity of the wallet owner for extra security. |
There was a problem hiding this comment.
This may be for convenience sake, however, if you are in a situation where you are concerned about unauthorized access by someone who has your device, once hidden perhaps you should be only able to unhide if a PIN or password has been entered.
This sentence seems a bit lengthy and wordy, perhaps you can try to break it down a bit and simplify.
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Pavlenex <pavle@pavle.org>
Co-authored-by: Pavlenex <pavle@pavle.org> Co-authored-by: Christoph Ono <chri@sto.ph>
…a01/Guide into feature/hide-sensitive-info
|
Really like the new images. Could you please also make the image sources available so they can also be something we can collaborate on like we do with text? What I have done on my pages is to have all images sources in a Figma file and link that in a comment at the top of the page (doesn't have to be Figma). Also outlined an example here. Small typo on the images. It should be "received", not "recieved". Thanks for patiently addressing all the feedback. |
|
The tricky part with privacy modes, is people know they exist. Maybe you can survive a wrench attack if you give them your hidden wallet that only actually has 10% of your net worth, or? You can't just have a hidden balance, or one hidden wallet. You need at least 3.
|
|
@ConorOkus Great idea, I think the reason we left this PR stale is that we couldn't find a suitable place for it. Go for it, but if you know how please add @Tiana01 as co-author of the commits for that section. I think portions of it would indeed fit perfectly into the onboarding section. |
|
Closing this in favour of #302, thanks @ConorOkus for adding this great PR to a proper place and for crediting @Tiana01's commits in your PR. |
Problem
Designing for physical privacy and security is sometimes overlooked in the design process. By owning bitcoin, you are in a position of being your own bank, and the responsibility of securing and protecting your funds falls on you. With this in mind, perhaps physical privacy should be looked at more seriously. So in a scenario where a user finds themselves in an uncomfortable environment, being able to ensure their immediate safety or comfort by protecting the sensitive information on their wallets, could come in handy.
Solution
This page should would serve as an introduction to physical privacy for designers, understanding why physical privacy should be seen as important and how this can be achieved in the wallet designs
Assumptions about the reader
Result