Skip to content

WIP: Add page for hide sensitive info - #112

Closed
Tiana01 wants to merge 24 commits into
BitcoinDesign:masterfrom
Tiana01:feature/hide-sensitive-info
Closed

WIP: Add page for hide sensitive info#112
Tiana01 wants to merge 24 commits into
BitcoinDesign:masterfrom
Tiana01:feature/hide-sensitive-info

Conversation

@Tiana01

@Tiana01 Tiana01 commented Jan 12, 2021

Copy link
Copy Markdown
Contributor
type: page
title: Hide Sensitive Information
permalink: /guide/payments/hide-sensitive-information
file: /guide/payments/hide-sensitive-info.md

Problem

Designing for physical privacy and security is sometimes overlooked in the design process. By owning bitcoin, you are in a position of being your own bank, and the responsibility of securing and protecting your funds falls on you. With this in mind, perhaps physical privacy should be looked at more seriously. So in a scenario where a user finds themselves in an uncomfortable environment, being able to ensure their immediate safety or comfort by protecting the sensitive information on their wallets, could come in handy.

Solution

This page should would serve as an introduction to physical privacy for designers, understanding why physical privacy should be seen as important and how this can be achieved in the wallet designs

Assumptions about the reader

  1. Has read the getting started chapter
  2. Knows basics about bitcoin wallets

Result

Comment thread guide/payments/hide-sensitive-info.md Outdated

The hide icon / button, which is usually displayed within close reach of the balance itself, is used to quickly and easily hide and reveal wallet information by tapping or clicking on it.

![hidden by eye icon](/assets/images/payments/hide-info-hidden-by-eye-icon.png)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you consider making this a bit bigger as it's difficult to know what to look at without zooming in, especially on mobile?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I will work on this

Comment thread guide/payments/hide-sensitive-info.md Outdated

## Consider removing the hide toggle from the homepage

Having the show/hide button right on the main screen make things quite obvious for someone who has access to your device to press unhide. A solution would be to move the hide toggle away from the home screen and into the app settings. This way, if someone has access to your device and opens the app, they may not immediately know how to reveal the hidden information as it is not as obvious as the previous solutions.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth also including what information will be hidden as well.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, that's noted

@pavlenex pavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations and thanks for your first PR. 🎉

Although for me it's a bit hard to see in which context this will be related to the payment guide, it's certainly great piece of information. As payment guide progresses, we may be able to agree on the structure of content, but since we still don't have the context, we can change that if needed in the future.

I've made a few minor suggestions and added a few recommendations mostly around content simplification and a bit too informal language used on two places.

Comment thread guide/payments/hide-sensitive-info.md Outdated
Comment thread guide/payments/hide-sensitive-info.md Outdated
Comment thread guide/payments/hide-sensitive-info.md Outdated
Comment thread guide/payments/hide-sensitive-info.md Outdated

Cons

- It may be annoying having to repeatedly put in your min when ever you want to reveal your information especially if you do so often

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It may be annoying having to repeatedly put in your min when ever you want to reveal your information especially if you do so often

Too informal imo. Annoying, also unsure what this means put in your min when ever you want to reveal your information

Comment thread guide/payments/hide-sensitive-info.md Outdated

# Hiding Sensitive Information

Imagine this scenario. You are in a public place, and you need to make a payment using your bitcoin wallet. You open your wallet on your phone, but you don’t feel comfortable having your address and balance information clearly visible to strangers who may be looking over your shoulder. Hence by giving users the ability to hide sensitive information in their wallet if desired, they gain an added sense of privacy and security when using the app in public.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearly visible to strangers who may be looking over your shoulder

Video surveillance can be another attack vector to add

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes an excellent point! considering that video surveillance is quite common nowadays.

Comment thread guide/payments/hide-sensitive-info.md Outdated

## Why is this pattern important to designers?

Privacy in bitcoin payments goes far beyond hiding balances and other sensitive information, the privacy by design framework states that privacy should be incorporated and built into products by default. This way, whether or not the user is concerned with their data privacy, they would always be protected through good UX.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great paragraph.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

through good UX.

Perhaps UI?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a good resource we can link to for "privacy by design framework"? If we mention a framework, we should make it easy to read up on it.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread guide/payments/hide-sensitive-info.md Outdated

## Entering a pin to unveil information

A problem that seemed to arise throughout each implementation was that is was as easy to reverse the hidden state as it was to enable it. This may be for convenience sake, however, if you are in a situation where you are concerned about unauthorized access by someone who has your device, once hidden perhaps you should be only able to unhide if a PIN or password has been entered. This could therefore reaffirm the identity of the wallet owner for extra security.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be for convenience sake, however, if you are in a situation where you are concerned about unauthorized access by someone who has your device, once hidden perhaps you should be only able to unhide if a PIN or password has been entered.

This sentence seems a bit lengthy and wordy, perhaps you can try to break it down a bit and simplify.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, noted!

Comment thread guide/payments/hide-sensitive-info.md Outdated
Comment thread guide/payments/hide-sensitive-info.md Outdated
Comment thread guide/payments/hide-sensitive-info.md
@GBKS

GBKS commented Jan 18, 2021

Copy link
Copy Markdown
Contributor

Really like the new images. Could you please also make the image sources available so they can also be something we can collaborate on like we do with text? What I have done on my pages is to have all images sources in a Figma file and link that in a comment at the top of the page (doesn't have to be Figma). Also outlined an example here.

Small typo on the images. It should be "received", not "recieved".

Thanks for patiently addressing all the feedback.

@BitcoinErrorLog

Copy link
Copy Markdown

The tricky part with privacy modes, is people know they exist.

Maybe you can survive a wrench attack if you give them your hidden wallet that only actually has 10% of your net worth, or?

You can't just have a hidden balance, or one hidden wallet. You need at least 3.

  • Default open wallet - hot money only, probably LN with a max total
  • Wrench offering wallet - custom % of hidden cold wallet?
  • Top secret hidden cold wallet
    But mgmt of these would need to be automatic, and the method for retrieving a "wrench wallet" would need to be same as cold wallet, so a multi-PIN/pw setup.

@ConorOkus

Copy link
Copy Markdown
Collaborator

I would like to add this to a page I've been working on here on protecting a wallet. @Tiana01 how do you feel about adding this content there?

@pavlenex

Copy link
Copy Markdown
Contributor

@ConorOkus Great idea, I think the reason we left this PR stale is that we couldn't find a suitable place for it. Go for it, but if you know how please add @Tiana01 as co-author of the commits for that section. I think portions of it would indeed fit perfectly into the onboarding section.

@pavlenex

Copy link
Copy Markdown
Contributor

Closing this in favour of #302, thanks @ConorOkus for adding this great PR to a proper place and for crediting @Tiana01's commits in your PR.

@pavlenex pavlenex closed this May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants