Skip to content

Create Sending bitcoin page - #181

Merged
pavlenex merged 20 commits into
BitcoinDesign:masterfrom
johnsBeharry:feature/sending-bitcoin
Mar 31, 2021
Merged

Create Sending bitcoin page#181
pavlenex merged 20 commits into
BitcoinDesign:masterfrom
johnsBeharry:feature/sending-bitcoin

Conversation

@johnsBeharry

Copy link
Copy Markdown
Contributor

No description provided.

@johnsBeharry
johnsBeharry marked this pull request as draft March 12, 2021 09:39

@pavlenex pavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

Comment thread guide/payments/send.md Outdated
Comment thread guide/payments/send.md Outdated
Comment thread guide/payments/send.md Outdated
Comment thread guide/payments/send.md Outdated
Comment thread guide/payments/send.md Outdated
Comment thread guide/payments/send.md Outdated
Comment thread guide/payments/send.md Outdated
Comment thread guide/payments/send.md Outdated
Comment thread guide/payments/send.md Outdated
Comment thread guide/payments/send.md
@johnsBeharry

Copy link
Copy Markdown
Contributor Author
SUMMARY FROM WORK SESSION (copied from slack)

Onboarding

  • Privacy by design and designers guide to adversarial thinking. @ConorOkus and @Tiana01 to link up.

Foundations / Units & Symbols

  • Is not clear what the calculation for the different bitcoin denominations are.

Payments / Send / Inputing an address

Payments / Send / Inputing an amount

  • What are some more don’ts?

Payments / Send / Transaction fee

  • Correct the calculations in the graphic since Low urgency is selected.
  • Users may just care about speed and price, so calculations might be an advanced topic.

@pavlenex
pavlenex marked this pull request as ready for review March 31, 2021 12:01
pavlenex
pavlenex previously approved these changes Mar 31, 2021

@pavlenex pavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @johnsBeharry.

As usual, I had to find a few things to nit-pick, but this section is phenomenal. Concise, easy to follow up, provide great information with good graphics that make it easy to understand what's going on.

tACK to get this merged as soon as the few typos I've found are addressed.

Comment thread guide/payments/send.md Outdated
Comment thread guide/payments/send.md Outdated
Comment thread guide/payments/send.md Outdated
Comment thread guide/payments/send.md Outdated
Comment thread guide/payments/send.md Outdated
Co-authored-by: Pavlenex <pavle@pavle.org>
pavlenex
pavlenex previously approved these changes Mar 31, 2021

@pavlenex pavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving my final ✅ , thanks for quickly addressing the tiny nits @johnsBeharry.

This one can be merged unless anyone else has the time to review it before the community call. I'll YOLO merge if no complaints until then.

This completes the second sprint. Great work everyone!

We will open a separate issue to add a header and another image.

@pavlenex
pavlenex merged commit c9b77d1 into BitcoinDesign:master Mar 31, 2021
@pavlenex

Copy link
Copy Markdown
Contributor

Let's gooooo gooo gooo 🚀 🚀 🚀

Sprint 2 complete 🙌

@danielnordh

Copy link
Copy Markdown
Contributor

Minor feedback

  • Change the 'Don'ts' under Inputting an address (it's currently double negative, which reads like don't prevent the sending to an invalid address
  • There is both 'inputting' and inputing' on the page, pick one
  • 'Carefully consider if and how you expose transaction fees to senders.' should it be 'Carefully consider if and how you expose transaction fee ADJUSTMENTS to senders.' ?
  • 'broadcasted' -> 'broadcast'
  • '1 confirmation' -> 'First confirmation'
  • '6 confirmations' -> 'Sixth confirmation' or 'Fully confirmed'

@psacramento-gh

psacramento-gh commented Apr 12, 2021

Copy link
Copy Markdown
Contributor
  • Change the 'Don'ts' under Inputting an address (it's currently double negative, which reads like don't prevent the sending to an invalid address
    -- My take on it: - Make it possible that a transaction is sent if the address is invalid

  • 'Carefully consider if and how you expose transaction fees to senders.' should it be 'Carefully consider if and how you expose transaction fee ADJUSTMENTS to senders.' ?
    -- I would rather use the word SELECTION, instead of ADJUSTMENTS.

  • 'broadcasted' -> 'broadcast'

  • '1 confirmation' -> 'First confirmation'

  • '6 confirmations' -> 'Sixth confirmation' or 'Fully confirmed'

All done.

psacramento-gh added a commit to psacramento-gh/Guide that referenced this pull request Apr 12, 2021
Changes based on the recommendations made by @danielnordh here: BitcoinDesign#181 (comment)
@johnsBeharry

Copy link
Copy Markdown
Contributor Author

hey @paulosacramento you'll need to create a pull request so we can review your change.

You can click below to do so 👇
https://github.com/BitcoinDesign/Guide/compare/master...paulosacramento:patch-1?expand=1

@psacramento-gh psacramento-gh mentioned this pull request Apr 16, 2021
@psacramento-gh

Copy link
Copy Markdown
Contributor

Thanks for explaining @johnsBeharry

johnsBeharry added a commit that referenced this pull request Apr 16, 2021
Changes based on the recommendations made by @danielnordh #181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants