Update send.md - #236
Merged
Merged
Conversation
Changes based on the recommendations made by @danielnordh here: BitcoinDesign#181 (comment)
| {% include image.html | ||
| image = "/assets/images/guide/payments/send/first-confirmation.svg" | ||
| alt-text = "Notifications after the transaction is broadcasted" | ||
| alt-text = "Notifications after the transaction is broadcast" |
Contributor
There was a problem hiding this comment.
not sure about this. is it grammatically correct?
Contributor
There was a problem hiding this comment.
Both appear to be acceptable. See here. I personally prefer "broadcast", for whatever reason it sounds better, but YMMV.
Contributor
There was a problem hiding this comment.
Buffalo buffalo Buffalo buffalo buffalo buffalo Buffalo buffalo
GBKS
reviewed
Apr 16, 2021
Contributor
|
Closes #209 |
Co-authored-by: Christoph Ono <chri@sto.ph>
johnsBeharry
approved these changes
Apr 16, 2021
johnsBeharry
left a comment
Contributor
There was a problem hiding this comment.
Still not completely used to broadcast over broadcasted in some places, but if english works like this then I won't fight it.
Thanks for taking this on @paulosacramento!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes based on the recommendations made by @danielnordh here: #181 (comment)