Improve http codec extractor tests#11640
Conversation
Extract the ContextInterpreter tests related to AppSec to remove duplication. Handle extractor initialization in a new parent test class Deduplicate constants and values into the new parent test class
|
Add @mhlidd as reviewer for visibility :) |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
mhlidd
left a comment
There was a problem hiding this comment.
Generally LGTM! Maybe some of the logic in AbstractHttpExtractorTest can go into HttpCodecTestHelper but not necessary.
|
That what I did in the first place, but with the next PR that will take care of injector, it ended up with a mixed bag of unrelated things in the helper class 🤷 |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
fa230dd
into
master
Extract the ContextInterpreter tests related to AppSec to remove duplication. Handle extractor initialization in a new parent test class Deduplicate constants and values into the new parent test class
What Does This Do
This PR improves the HttpCodec extractor tests that were recently moved to JUnit and cleaned up ( #11576, #11581, #11606).
It goes a step further by:
Motivation
Additional Notes
This should only be a refactor, no behavior change.
The only change is that AppSec is now tests with all the propagation styles where B3 and X-Ray were previously missing.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]