Skip to content

Improve http codec injector tests#11690

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bbujon/groovy-to-java
Jun 22, 2026
Merged

Improve http codec injector tests#11690
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bbujon/groovy-to-java

Conversation

@PerfectSlayer

Copy link
Copy Markdown
Contributor

What Does This Do

This PR is a complement to #11640
It brings the same kind of clean up / refactoring to the injector tests.

Motivation

Remove duplicated code, mirror the extractor tests

Additional Notes

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer requested a review from a team as a code owner June 22, 2026 10:16
@PerfectSlayer PerfectSlayer added the tag: no release notes Changes to exclude from release notes label Jun 22, 2026
@PerfectSlayer PerfectSlayer requested a review from amarziali June 22, 2026 10:16
@datadog-prod-us1-4

This comment has been minimized.

@bric3 bric3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the simplification

@dd-octo-sts

dd-octo-sts Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.01 s 14.00 s [-0.7%; +0.9%] (no difference)
startup:insecure-bank:tracing:Agent 13.00 s 13.04 s [-1.3%; +0.7%] (no difference)
startup:petclinic:appsec:Agent 16.86 s 16.77 s [-0.5%; +1.4%] (no difference)
startup:petclinic:iast:Agent 16.88 s 16.95 s [-1.2%; +0.4%] (no difference)
startup:petclinic:profiling:Agent 16.76 s 16.24 s [-1.3%; +7.6%] (no difference)
startup:petclinic:sca:Agent 16.92 s 16.70 s [+0.4%; +2.2%] (maybe worse)
startup:petclinic:tracing:Agent 16.18 s 16.22 s [-1.1%; +0.7%] (no difference)

Commit: f371fa39 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@PerfectSlayer

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 22, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-22 11:31:13 UTC ℹ️ Start processing command /merge


2026-06-22 11:31:24 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-06-22 11:45:06 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-06-22 13:20:39 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 3006004 into master Jun 22, 2026
971 of 981 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the bbujon/groovy-to-java branch June 22, 2026 13:20
@github-actions github-actions Bot added this to the 1.64.0 milestone Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: context propagation Trace context propagation tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants