You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-09-09] Payment issue for E/App PR#98326 #100091
@hoangzinh The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Sign in as a workspace member who has paid reports.
Go to Spend > Reports and open the columns picker. Enable the Paid by column.
Verify the Paid by column shows the person who paid each paid report and is blank for unpaid reports.
Click the Paid by column header and verify the rows sort by that name.
Open Filters, choose Paid by, select one or more users, and apply.
Verify the results only include reports paid by the selected users (unpaid reports never match), and the filter bar shows a Paid by chip.
Select the paid reports and click on Export from the selected drop down > Current View. Verify the exported file has a Paid by column with the name of the user who paid.
If a post on the PR or the issue mentions a regression or a deploy blocker, the C+ must post on the issue before the payment date.
Post one of these two:
It was a regression. Say so. Pay drops 50% for each regression on the issue.
It was not a regression. Give the reason, and include all three:
Quote the sentence that settles it, as a blockquote. Use a screenshot only when the proof is visual.
Link the exact comment, not the issue,
State who closed the linked blocker and whether a PR closed it. A blocker the CME closed with no fix PR is not a regression. A blocker closed by a fix PR is one.
If the C+ does not post by the payment date, the CM assumes every mention of a regression or a deploy blocker reduces the amount.
#90300 paid 150% for 28 files. #91098 paid 200% for 37 files across 2 PRs
Needs a ruling
Yes if you disagree with the increase
The increase nobody asked for
#98326 changed 34 files and added 1672 lines. That clears both size thresholds, 25 files and 1000 added lines, and size is a standalone factor. One factor gives 150%.
Nobody requested this. The rules say the review proposes an increase whether or not anyone asked, because a payee who has to ask for the right amount is underpaid until they ask, and asking is a skill not everyone has.
Comparable cases: #90300 paid 150% for 28 files, #91098 paid 200% for 37 files across two PRs, #76914 paid 200% for 33 files and +1163 lines.
I found no second factor, so 150% and not 200%.
The regression, already settled
Two blockers were linked and both are resolved:
#99969, rebutted. @hoangzinh: "This DB is not a regression; it's expected behavior", and it was demoted and closed.
#99968, confirmed by @hoangzinh: "Confirmed. This is a regression from our PR, but... Can we consider to don't penalty on payment amount?"
@JS00001 answered: "Lets keep this at $250, no regression penalty." An employee saying the regression should not change the amount is a valid rebuttal, so no cut applies.
Read that as a waiver of the cut, not as a cap on the price.@JS00001 was answering whether to go down to $125. The size increase is a separate question and was never put to him.
The missing checklist blocks the review rather than cutting the amount.
@JS00001, you set $250 when the question was the regression penalty. The PR is 34 files and +1672 lines, which the rules price at 150%. Worth a look before this is paid.
Claude posting on behalf of Matt. PAYRUBRICTEST v2
Given that this issue is a feature request. I completed the regression test proposal here #100091 (comment). Do you still need a C+ checklist? @mallenexpensify
Activity
melvin-bot commentedon Sep 2, 2026
@hoangzinh The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
hoangzinh commentedon Sep 2, 2026
Regression Test Proposal
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Sep 7, 2026
@hoangzinh Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Sep 8, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Sep 8, 2026
Payment Summary
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Sep 10, 2026
@hoangzinh from the C+ doc
hoangzinh commentedon Sep 11, 2026
Sorry @mallenexpensify I forgot to post this. Let me post it now
hoangzinh commentedon Sep 11, 2026
This DB is not a regression; it's expected behavior
hoangzinh commentedon Sep 11, 2026
Confirmed. This is a regression from our PR, but given:
Can we consider to don't penatly on payment amount?
cc @JS00001 for your opinion.
JS00001 commentedon Sep 11, 2026
Lets keep this at $250, no regression penalty
mallenexpensify commentedon Sep 14, 2026
Claude posting on behalf of Matt:
Blocked on the checklist, but the amount may be $375 rather than $250. The PR is large enough to trigger an increase and nobody has raised it.
@hoangzinh plz complete the Contributor+ checklist and tag me in a post once you have. Thx
The increase nobody asked for
#98326 changed 34 files and added 1672 lines. That clears both size thresholds, 25 files and 1000 added lines, and size is a standalone factor. One factor gives 150%.
Nobody requested this. The rules say the review proposes an increase whether or not anyone asked, because a payee who has to ask for the right amount is underpaid until they ask, and asking is a skill not everyone has.
Comparable cases: #90300 paid 150% for 28 files, #91098 paid 200% for 37 files across two PRs, #76914 paid 200% for 33 files and +1163 lines.
I found no second factor, so 150% and not 200%.
The regression, already settled
Two blockers were linked and both are resolved:
@JS00001 answered: "Lets keep this at $250, no regression penalty." An employee saying the regression should not change the amount is a valid rebuttal, so no cut applies.
Read that as a waiver of the cut, not as a cap on the price. @JS00001 was answering whether to go down to $125. The size increase is a separate question and was never put to him.
Everything else
The missing checklist blocks the review rather than cutting the amount.
@JS00001, you set $250 when the question was the regression penalty. The PR is 34 files and +1672 lines, which the rules price at 150%. Worth a look before this is paid.
Claude posting on behalf of Matt.
PAYRUBRICTEST v2hoangzinh commentedon Sep 15, 2026
Given that this issue is a feature request. I completed the regression test proposal here #100091 (comment). Do you still need a C+ checklist? @mallenexpensify
JS00001 commentedon Sep 15, 2026
I disagree with this, 1516 of the 1672 lines are autogenerated parser code
Lets stick with 250
mallenexpensify commentedon Sep 15, 2026
Payment Summary
Contributor+: @hoangzinh due $250 via NewDot
^ Test case created. Thx
laurenreidexpensify commentedon Sep 21, 2026
$250 approved @hoangzinh New Expensify