Skip to content

[Due for payment 2026-09-09] Payment issue for E/App PR#98326 #100091

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #98326
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/670393.
Contributor+ member who reviewed the PR - @hoangzinh.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Sep 2, 2026

    @melvin-bot
    Author

    @hoangzinh The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. hoangzinh commented on Sep 2, 2026

    @hoangzinh
    Contributor

    Regression Test Proposal

    Test:

    1. Sign in as a workspace member who has paid reports.
    2. Go to Spend > Reports and open the columns picker. Enable the Paid by column.
    3. Verify the Paid by column shows the person who paid each paid report and is blank for unpaid reports.
    4. Click the Paid by column header and verify the rows sort by that name.
    5. Open Filters, choose Paid by, select one or more users, and apply.
    6. Verify the results only include reports paid by the selected users (unpaid reports never match), and the filter bar shows a Paid by chip.
    7. Select the paid reports and click on Export from the selected drop down > Current View. Verify the exported file has a Paid by column with the name of the user who paid.

    Do we agree 👍 or 👎

  3. melvin-bot commented on Sep 7, 2026

    @melvin-bot
    Author

    @hoangzinh Eep! 4 days overdue now. Issues have feelings too...

  4. melvin-bot commented on Sep 8, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  5. melvin-bot commented on Sep 8, 2026

    @melvin-bot
    Author

    Payment Summary

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  6. mallenexpensify commented on Sep 10, 2026

    @mallenexpensify
    Contributor

    @hoangzinh from the C+ doc

    If a post on the PR or the issue mentions a regression or a deploy blocker, the C+ must post on the issue before the payment date.

    Post one of these two:

    It was a regression. Say so. Pay drops 50% for each regression on the issue.

    It was not a regression. Give the reason, and include all three:

    • Quote the sentence that settles it, as a blockquote. Use a screenshot only when the proof is visual.
    • Link the exact comment, not the issue,
    • State who closed the linked blocker and whether a PR closed it. A blocker the CME closed with no fix PR is not a regression. A blocker closed by a fix PR is one.

    If the C+ does not post by the payment date, the CM assumes every mention of a regression or a deploy blocker reduces the amount.

  7. hoangzinh commented on Sep 11, 2026

    @hoangzinh
    Contributor

    Sorry @mallenexpensify I forgot to post this. Let me post it now

  8. hoangzinh commented on Sep 11, 2026

    @hoangzinh
    Contributor

    This DB is not a regression; it's expected behavior

    Cool, so I think we can demote and close this issue as expected then.
    Ref: #99969 (comment)

  9. hoangzinh commented on Sep 11, 2026

    @hoangzinh
    Contributor

    Confirmed. This is a regression from our PR, but given:

    • This is a new feature we added + PR LOC was huge
    • The deploy blocker was minor; the user can see it after a refresh or by revisiting the page
    • We attempted to fix it and ship the fix asap.

    Can we consider to don't penatly on payment amount?

    cc @JS00001 for your opinion.

  10. JS00001 commented on Sep 11, 2026

    @JS00001
    Contributor

    Lets keep this at $250, no regression penalty

  11. mallenexpensify commented on Sep 14, 2026

    @mallenexpensify
    Contributor

    Claude posting on behalf of Matt:

    Blocked on the checklist, but the amount may be $375 rather than $250. The PR is large enough to trigger an increase and nobody has raised it.

    @hoangzinh plz complete the Contributor+ checklist and tag me in a post once you have. Thx

    Contributor Nothing due, @c3024 is a Backend Contributor
    Contributor+ @hoangzinh, $375 via NewDot on the rules, see below
    Job price $250, standard, no price in title
    Reduction None. One regression, waived by @JS00001
    Increase 150%, size. 34 files, +1672 lines
    Blockers 2 linked, both resolved
    Precedent #90300 paid 150% for 28 files. #91098 paid 200% for 37 files across 2 PRs
    Needs a ruling Yes if you disagree with the increase
    The increase nobody asked for

    #98326 changed 34 files and added 1672 lines. That clears both size thresholds, 25 files and 1000 added lines, and size is a standalone factor. One factor gives 150%.

    Nobody requested this. The rules say the review proposes an increase whether or not anyone asked, because a payee who has to ask for the right amount is underpaid until they ask, and asking is a skill not everyone has.

    Comparable cases: #90300 paid 150% for 28 files, #91098 paid 200% for 37 files across two PRs, #76914 paid 200% for 33 files and +1163 lines.

    I found no second factor, so 150% and not 200%.

    The regression, already settled

    Two blockers were linked and both are resolved:

    • #99969, rebutted. @hoangzinh: "This DB is not a regression; it's expected behavior", and it was demoted and closed.
    • #99968, confirmed by @hoangzinh: "Confirmed. This is a regression from our PR, but... Can we consider to don't penalty on payment amount?"

    @JS00001 answered: "Lets keep this at $250, no regression penalty." An employee saying the regression should not change the amount is a valid rebuttal, so no cut applies.

    Read that as a waiver of the cut, not as a cap on the price. @JS00001 was answering whether to go down to $125. The size increase is a separate question and was never put to him.

    Everything else
    PR #98326, author @c3024, 34 files, +1672 / -1456
    C+ checklist on this issue None posted
    Reviewer checklist on the PR Posted by @hoangzinh, all boxes checked
    Platform evidence 5 of 5 boxes checked, 1 of 5 carries a video

    The missing checklist blocks the review rather than cutting the amount.

    @JS00001, you set $250 when the question was the regression penalty. The PR is 34 files and +1672 lines, which the rules price at 150%. Worth a look before this is paid.


    Claude posting on behalf of Matt. PAYRUBRICTEST v2

  12. hoangzinh commented on Sep 15, 2026

    @hoangzinh
    Contributor

    Given that this issue is a feature request. I completed the regression test proposal here #100091 (comment). Do you still need a C+ checklist? @mallenexpensify

  13. JS00001 commented on Sep 15, 2026

    @JS00001
    Contributor

    The PR is 34 files and +1672 lines, which the rules price at 150%. Worth a look before this is paid.

    I disagree with this, 1516 of the 1672 lines are autogenerated parser code

    Image

    Lets stick with 250

  14. mallenexpensify commented on Sep 15, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @hoangzinh due $250 via NewDot

    ^ Test case created. Thx

  15. laurenreidexpensify commented on Sep 21, 2026

    @laurenreidexpensify
    Contributor

    $250 approved @hoangzinh New Expensify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions