Skip to content

QBO - Export Company Cards - Default vendor toggle missing #100540

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.73-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176908/test-cases/41237435
Email or phone of affected tester (no customers): testing210790@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Mac/Chrome
App Component: Other

Action Performed:

Precondition:

Use a workspace with QuickBooks Online connected.
Add another admin to the workspace.

  1. Navigate to Accounting.
  2. Click Export.
  3. Click Export Company Cards.
  4. Click Export as.
  5. Select Vendor Bill.

Expected Result:

The Default vendor toggle is displayed and is disabled by default.

Actual Result:

The Default vendor option is displayed, but the expected toggle is missing.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

bandicam.2026-09-07.20-10-30-726.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7253581

Issue OwnerCurrent Issue Owner: @huult

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 7, 2026
  2. MelvinBot commented on Sep 7, 2026

    @MelvinBot
    Contributor

    Proposal

    This is not a regression — the toggle was deliberately removed. The BrowserStack test case is stale.

    What is the root cause of that problem?

    Expensify/App#99867 (merged 2026-09-03) intentionally replaced the QBO Vendor Bill Default vendor toggle with an always-visible navigable row, to match the pattern Sage Intacct adopted in Expensify/App#97016. From that PR's description:

    Vendor Bill branch: replaced the legacy ToggleSettingOptionRow + Accordion with a single always-visible Default vendor row that opens the existing bill default-vendor selector. The underlying setting values are untouched — the Advanced page's Create new entities (autoCreateVendor) toggle and its API action are unchanged.

    So the reported "Actual Result" is the new intended design:

    Test case 41237435 still asserts the pre-#99867 behavior ("The Default vendor toggle is displayed and is disabled by default"), which is why it failed.

    What changes do you think we should make in order to solve the problem?

    No App code change. Update BrowserStack TC 41237435 so the QBO Vendor Bill step expects a tappable Default vendor row (no switch, opens the vendor selector), and close this issue as working as intended.

    Also worth correcting on this report: "Reproducible in production: No" is not accurate. #99867 shipped in production 9.4.72-2 (published 2026-09-07 10:47 UTC), about 6.5 hours before this was filed — so current production behaves the same way as staging.

    Supporting evidence

    Release inclusion (merge commit 2fb1e5eb):

    • 9.4.71-0 (prod) — not included
    • 9.4.72-2 (prod, 2026-09-07 10:47 UTC) — included
    • 9.4.73-0-staging onward — included

    The old copy was deleted, not orphaned. #99867 removed workspace.qbo.defaultVendorDescription along with its only two call sites (the toggle's subtitle and switchAccessibilityLabel) across all locales. The string still present at en.ts:5041 is the unrelated workspace.qbd.defaultVendorDescription for QuickBooks Desktop, a separate integration #99867 did not touch — which is why QBD still shows a toggle at DynamicQuickbooksDesktopCompanyCardExpenseAccountPage.tsx:96. If a tester compares QBO against QBD, that difference is expected.

    Decoupling was explicit. #99867 also added tests/unit/pages/workspace/accounting/qbo/defaultVendorSubscriptionsTest.ts asserting the export path no longer surfaces autoCreateVendor because it is an Advanced setting. The PR's own test steps say it "deliberately leaves the existing autoCreateVendor behavior unchanged."

    Alternative considered — was the toggle dropped by accident? Ruled out: the removal is described in the PR body, the toggle's translation keys were deleted in the same PR, a unit test was added to lock in the new subscription behavior, and the PR is a stated follow-up to an approved design change (the internal design issue linked from #99867). An accidental deletion would not carry all four.

    Precondition note. "Add another admin to the workspace" in the repro steps has no bearing on this row — visibility is gated only on the QBO non-reimbursable export destination.

    Not verified live. I confirmed this from code and PR history only; reproducing the screen needs a workspace with a real QuickBooks Online OAuth connection.

    Related issues

    Nothing looks like a duplicate. Expensify/App#96846 ("Company Card - Credit Card Export Account Lists Appear on Vendor Bills") touches the same screen but is a different defect.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/100540) to create a draft PR. (Note: this proposal recommends no code change — accepting it means updating the test case and closing the issue.)
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run · no recording available

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 7, 2026
  4. melvin-bot commented on Sep 7, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @huult (External)

  5. melvin-bot commented on Sep 7, 2026

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  6. huult commented on Sep 8, 2026

    @huult
    Contributor

    This is not a regression — the toggle was deliberately removed. The BrowserStack test case is stale.

    @Beamanator could you ask QA to update the BrowserStack test case based on the changes in PR #99867?

  7. m-natarajan commented on Sep 8, 2026

    @m-natarajan

    @Beamanator @huult Updated the referenced test case

  8. huult commented on Sep 9, 2026

    @huult
    Contributor

    Yeah, thanks! We can close this ticket. cc @Beamanator

  9. self-assigned this
    on Sep 9, 2026
  10. Beamanator commented on Sep 9, 2026

    @Beamanator
    Contributor

    sure thing, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions