Skip to content

[Payment due @mkhutornyi] Sage Intacct: Default vendor as navigable arrow row with updated copy - #97016

Merged
mollfpr merged 17 commits into
mainfrom
claude-sageIntacctDefaultVendorRow
Jul 28, 2026
Merged

mollfpr merged 17 commits into
mainfrom
claude-sageIntacctDefaultVendorRow

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Jul 25, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The Sage Intacct Default vendor row on the credit-card-charge (non-reimbursable) export path used to be a toggle that expanded an accordion holding a nested select row. This PR reshapes it into a single, always-visible arrow row that navigates straight to the existing vendor select page.

The vendor now starts empty. When nothing is picked, the row title is blank and a muted line below the row explains what will happen: Expenses that don't auto-match will default to this Sage Intacct vendor. Otherwise, they'll export as Credit Card Misc. Once a vendor is chosen, the title shows the vendor's name and the muted line drops the fallback sentence.

The vendor select page's header text was also updated. Above the search bar, on the non-reimbursable path, it now reads: Choose a default Sage Intacct vendor for expenses that don't match automatically. The reimbursable path's header is unchanged.

The helper text and select-page header both live under workspace.accounting and take the integration display name as a parameter, so QBO, Xero, and other connections can reuse the same copy while rendering their own name. Polyglot Parrot translations were applied for all supported languages.

Behavior preserved: the row stays hidden until a non-reimbursable export type is chosen; the Vendor Bill path continues to render its existing arrow row (no muted helper text); the vendor list source is unchanged; no Auth/PHP changes.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/664271
PROPOSAL: https://github.com/Expensify/Expensify/issues/664271#issuecomment-5075633547

Tests

  1. Sign in and open a workspace that is connected to Sage Intacct.
  2. Navigate to Workspaces > [your workspace] > Accounting > Export > Export company card expenses as.
  3. Set Export as to Credit card charge.
  4. Verify the Default vendor row appears as a single arrow row (not a toggle). The row title is blank — there is no "Not set" placeholder. Directly under the row, verify muted text reads: Expenses that don't auto-match will default to this Sage Intacct vendor. Otherwise, they'll export as Credit Card Misc.
  5. Tap the Default vendor row. Verify the vendor select page opens and the header above the search bar reads: Choose a default Sage Intacct vendor for expenses that don't match automatically.
  6. Select a vendor from the list. Verify:
    • You are returned to the previous page.
    • The row title now shows the selected vendor's name.
    • The muted helper text under the row updates to just one sentence: Expenses that don't auto-match will default to this Sage Intacct vendor. (the "Otherwise, they'll export as Credit Card Misc." fallback sentence is gone).
  7. Tap the Default vendor row again, then tap the currently selected vendor to clear it. Verify the row title returns to blank and the muted helper text returns to the two-sentence version that includes the Credit Card Misc fallback.
  8. Change Export as to Vendor bill. Verify the Default vendor row still renders as an arrow row and that no muted helper text appears below it (the helper text is credit-card-charge only).
  9. Confirm no errors appear in the JS console throughout the flow.
  • Verify that no errors appear in the JS console

Offline tests

  1. With the Export company card expenses as page open on a Sage Intacct workspace and Export as set to Credit card charge, disable your network connection.
  2. Tap Default vendor and select a vendor.
  3. Verify the selection reflects optimistically while offline: the row title shows the vendor's name and the muted helper text switches to the one-sentence variant (no Credit Card Misc fallback).
  4. Clear the vendor while still offline (tap the row, tap the selected vendor). Verify the row title returns to blank and the muted helper text returns to the two-sentence version.
  5. Re-enable your network connection. Verify the selection persists (matches whichever state you left it in) and no error is displayed.

QA Steps

Ping me & @heyjennahay to test

Same as Tests above. Run the flow on a Sage Intacct-connected workspace on the staging environment and verify each expected outcome.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

No default vendor set:

Screenshot 2026-07-27 at 8 02 43 AM

Selecting a default vendor:

Screenshot 2026-07-27 at 8 14 00 AM

Yes default vendor set (hovered too):

Screenshot 2026-07-27 at 8 02 34 AM

…copy

Co-authored-by: Alex Beaman <Beamanator@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team July 25, 2026 00:05
@OSBotify

This comment has been minimized.

@Beamanator

Copy link
Copy Markdown
Contributor

@MelvinBot apply the polyglot parrot fix

@codecov

codecov Bot commented Jul 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...cct/export/DynamicSageIntacctDefaultVendorPage.tsx 0.00% <0.00%> (ø)
.../export/SageIntacctNonReimbursableExpensesPage.tsx 0.00% <0.00%> (ø)
... and 19 files with indirect coverage changes

Co-authored-by: Alex Beaman <Beamanator@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Fixed the failing typecheck check and pushed to this branch (316fc02).

Root cause: The PR added the defaultVendorNotSet string to en.ts and es.ts, but not to the other 8 language files. TranslationDeepObject requires every locale to define the same keys, so tsc failed with TS2741: Property 'defaultVendorNotSet' is missing in de, fr, it, ja, nl, pl, pt-BR, and zh-hans.

Fix: Added defaultVendorNotSet (the localized equivalent of "Not set", reusing each file's existing notSet translation) to all 8 files, placed right after the Sage Intacct defaultVendor key to mirror en.ts. Verified locally with npm run typecheck-tsgo (passes) and ran npm run fmt.

The checklist check (PR Author Checklist) is still red, but that's the human-only checklist — it stays failing until the co-author fills out the boxes and test steps, so it's expected and not something I fix.

Co-authored-by: Alex Beaman <Beamanator@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🦜 Applied the Polyglot Parrot translations in 1dacbf0bb61.

The only remaining un-applied part of the parrot patch was the defaultVendorDescription rewrite (single-template → two-branch form with the corrected reimbursable/non-reimbursable copy) across de, es, fr, it, ja, nl, pl, pt-BR, zh-hans, plus a couple of es corrections (Sin establecer → No establecido and the two description branches).

I intentionally skipped the patch's defaultVendorNotSet additions — those keys were already added (with identical values) in 316fc02, so re-applying them would have created duplicate keys. Verified each language file still has exactly one defaultVendorNotSet.

Note: npm run prettier/typecheck/lint are gated in this environment and couldn't be run locally, but the edits reproduce the parrot bot's already-formatted output verbatim, so CI checks should validate them.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The only failing check is PR Author Checklist / checklist, and there's nothing in the code to fix — every code-quality check is green.

Why it's failing: the check reports 0 out of 38 checklist items completed. It's a static check that just verifies the boxes in the PR body are ticked; it fails until they are.

Why I'm not "fixing" it by pushing: the PR Author Checklist boxes attest to manual testing (running the flow on all platforms, verifying no console errors, etc.) that a human must actually perform and confirm. The PR body still has the // TODO: The human co-author must fill out... placeholders for the Tests and QA Steps sections. It would be wrong for me to auto-tick them, so this is on you (Beamanator) to complete before marking the PR ready for review.

Check results at time of analysis

All code-related checks passed:

  • typecheck ✅
  • ESLint check ✅ · Oxfmt check ✅ · Compare knip issues against main ✅
  • test (jobs 1–8) ✅
  • build (…) (all variants) ✅
  • React Compiler Compliance, Storybook tests, Bun tests, spellcheck, generateTranslations ✅

Only PR Author Checklist / checklist is fail; baseline-perf-tests / branch-perf-tests were still running (informational, not code-correctness).

Next steps: fill out the Tests/QA Steps sections and tick the PR Author Checklist boxes, then re-run the check — it'll pass.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Re-checked — the state is unchanged. The only failing check is still PR Author Checklist / checklist, which fails solely because the checklist boxes in the PR body aren't ticked. Every code-quality check is passing (typecheck, ESLint, Oxfmt, knip, all 8 test jobs, all builds, Storybook, Bun/spellcheck/translations, and the perf tests).

There's nothing for me to fix in code, and I won't tick the author-checklist boxes on your behalf — they attest to manual cross-platform testing you (Beamanator) must perform, and the PR body still has the // TODO: The human co-author must fill out... placeholders in the Tests/QA sections.

To clear this check: fill out the Tests/QA Steps sections and tick the PR Author Checklist boxes — the check re-runs on edit and will pass.

@Beamanator

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 1dacbf0bb6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Re-checked after the main merge (70a2c90) re-ran CI — same conclusion: there's no code fix to push. Every code-quality check is green again (typecheck, spellcheck, ESLint, Oxfmt, knip, all 8 test jobs, all build variants, Storybook, React Compiler, generateTranslations).

The only failing check is PR Author Checklist / checklist, which fails purely because the 38 author-checklist boxes in the PR body aren't ticked (0 out of 38 completed). That's a human step — the boxes attest to manual cross-platform testing, and the body still has the // TODO: The human co-author must fill out... placeholders in the Tests and QA Steps sections. I won't auto-tick those.

Next step (yours): fill out the Tests/QA Steps sections, tick the PR Author Checklist boxes, and the check will pass. (baseline-perf-tests / branch-perf-tests were still running — informational, not code-correctness.)

Introduce two connection-agnostic strings under `workspace.accounting`:
- `defaultVendorHelperText({connectionName, isSet})` for the muted description below the "Default vendor" row on export pages.
- `defaultVendorSelectHeader({connectionName})` for the "Choose a default … vendor" header above the vendor select list.

Both take the integration display name as a parameter so QBO, Sage Intacct, Xero, etc. can share the copy while rendering their own name.
- Non-reimbursable default vendor row no longer falls back to a "Not set" title. When no vendor is picked, the row title is empty and the muted helper text carries the meaning.
- The helper text below the row now reads: "Expenses that don't auto-match will default to this Sage Intacct vendor." When no vendor is set, it appends "Otherwise, they'll export as Credit Card Misc." so admins understand the fallback behavior.
- The default vendor select page header (non-reimbursable path) now reads "Choose a default Sage Intacct vendor for expenses that don't match automatically." The reimbursable-path header is unchanged.

Both new strings live under `workspace.accounting` and receive the connection display name as a parameter, so QBO and Xero can reuse them later. Removes the now-unused `defaultVendorNotSet` key from all language files.
@OSBotify

This comment has been minimized.

Squawk! Translates the new defaultVendorHelperText and defaultVendorSelectHeader strings into all supported languages, and refines the existing sageIntacct.defaultVendorDescription translations while we are here.
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Still the same situation — nothing to push. Your latest commit (96ea23b) passed every code check (typecheck, ESLint, Oxfmt, all test jobs, all build variants, knip).

The only red check is PR Author Checklist / checklist, which fails with 0 out of 38 checklist items completed. It's a static check that just verifies the PR Author Checklist boxes are ticked; it stays red until they are, and those boxes attest to manual testing that a human must actually do — so I can't tick them for you.

To make it pass: fill out the Tests / QA Steps sections (still have the // TODO: human co-author placeholders) and check the PR Author Checklist boxes. The check re-evaluates on your next push.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Re-checked — nothing to fix in code. Every check is green except PR Author Checklist / checklist, which fails only because the checklist boxes aren't ticked (0 out of 38 checklist items). The perf tests that were still running earlier have since passed.

This one's on you (Beamanator): fill out the Tests / QA Steps sections (still showing the // TODO: The human co-author must fill out... placeholders) and check the PR Author Checklist boxes. I can't tick them for you — they attest to manual cross-platform testing a human has to actually do. Once they're checked, the check will pass.

@Beamanator
Beamanator requested a review from mkhutornyi July 27, 2026 14:00
@Beamanator
Beamanator marked this pull request as ready for review July 27, 2026 14:01
@Beamanator
Beamanator requested a review from a team as a code owner July 27, 2026 14:01
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and parasharrajat and removed request for a team July 27, 2026 14:01
@melvin-bot

melvin-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

When SageIntacctNonReimbursableExpensesPage was reshaped from the toggle + accordion pattern into a plain MenuItemWithTopDescription arrow row, the wrapping OfflineWithFeedback was left with only pendingAction wired. The default vendor field's error stopped rendering as text and the user lost the ability to dismiss it, leaving only a non-dismissable brickRoadIndicator red dot when a SetSageIntacctDefaultVendor write failed.

Thread optional errors and onCloseError through MenuItemToRender and renderDefault, and wire them on the Default vendor row using getLatestErrorField and clearSageIntacctErrorField against the export-mode-specific settingName (NON_REIMBURSABLE_VENDOR for Vendor Bill, NON_REIMBURSABLE_CREDIT_CARD_VENDOR for Credit card charge).
@Beamanator

Copy link
Copy Markdown
Contributor

Pulled main to hopefully fix eslint & typescript checks - also sliiiightly changed the copy so that we'll show:

  • If no default is selected yet, make it show Expenses that don't auto-match will default to this vendor. Otherwise, they'll export as Credit Card Misc. (don't include the connection name)
  • If a default is selected, instead show Expenses that don't auto-match will default to this vendor. (again, without the connection name)

@Beamanator

Copy link
Copy Markdown
Contributor

Ready again 🙏

@mkhutornyi

Copy link
Copy Markdown
Contributor

@codex review

@mkhutornyi

Copy link
Copy Markdown
Contributor

@MelvinBot review

@mkhutornyi

Copy link
Copy Markdown
Contributor

@Beamanator since you're co-authored, we might need another engineer to merge this PR.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 4d4a4044c8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Review

Nice cleanup — collapsing the toggle + accordion into a single always-visible arrow row reads much better, and pulling the Sage-specific creditCardMiscFallback out of the shared workspace.accounting.defaultVendorHelperText is the right call. The refactored logic looks correct: defaultVendorSettingName switches the subscribed setting/error field between vendor-bill and credit-card-charge, helperText is scoped to the credit-card-charge path only, and shouldHide: !config?.export.nonReimbursable keeps the row hidden until an export type is chosen.

One thing that should be fixed before merge, plus a couple of nits.

🔴 Credit Card Misc. is a literal vendor name — most locales wrongly translate it

Credit Card Misc. is the actual name of the vendor record Expensify creates in the accounting system, not descriptive prose. The existing QBO copy treats it as a literal and keeps the English string even inside translated sentences — e.g. es.ts:4645 reads …crearemos un proveedor asociado 'Credit Card Misc.'.

The new creditCardMiscFallback breaks that convention inconsistently — some locales localize the vendor name, others keep it English:

Locale Rendering Vendor name
en / fr / nl Credit Card Misc (kept English) ✅ literal
es Tarjeta de crédito (Varios) ❌ translated
de Kreditkarte – Verschiedenes ❌ translated
it Varie carta di credito ❌ translated
pt-BR Diversos de Cartão de Crédito ❌ translated
pl Różne wydatki karty kredytowej ❌ translated
ja クレジットカードその他 ❌ translated
zh-hans 信用卡杂项 ❌ translated

A Spanish/German/etc. user is told their expenses export as a vendor that, in Sage Intacct, is literally named Credit Card Misc. — they'll go looking for a translated name that doesn't exist. The surrounding sentence should stay localized, but the vendor name itself should remain the literal Credit Card Misc. in every locale, matching the QBO precedent.

🟡 Nits (non-blocking)

  • SageIntacctNonReimbursableExpensesPage.tsx:44: !!(defaultVendorName && defaultVendorName !== '') — an empty string is already falsy, so !!defaultVendorName is equivalent. The row title a few lines down repeats the same defaultVendorName && defaultVendorName !== '' check; it can reuse isDefaultVendorSet.
  • ExtendedMenuItemWithSubscribedSettings is no longer imported by this page after the refactor — worth a quick check that it's still referenced somewhere, otherwise the type/ToggleItemWithKey plumbing in intacct/types.ts is now dead.

Everything else looks good. Once the vendor-name literal is consistent across locales this is good to go.

…name

Refactors workspace.accounting.defaultVendorHelperText from a
connection-name-parameterized string ({connectionName}) into a
connection-name-free variant that toggles the "Credit Card Misc"
fallback sentence based on whether a default vendor is set:

  isSet=true  -> "Expenses that don't auto-match will default to this vendor."
  isSet=false -> "Expenses that don't auto-match will default to this vendor. Otherwise, they'll export as Credit Card Misc."

This lets all three integrations (Sage Intacct, QBO, Xero) render
the same copy under the Default vendor row instead of each carrying
its own connection-specific phrasing.

Sage Intacct's NonReimbursableExpensesPage now uses the shared string
directly and no longer appends the sageIntacct.creditCardMiscFallback
key, which is deleted. The workspace.accounting.defaultVendorSelectHeader
page-header string keeps its {connectionName} parameter for now since
it is only used from the Sage Intacct select page.

QBO and Xero rows are not wired up in this commit and continue to
render without the muted helper text; that normalization is tracked in
Expensify/Expensify#664722.
@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index c0315633d4b..a85d1704edb 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -5072,8 +5072,8 @@ ${amount} für ${merchant} – ${date}`,
             defaultVendor: 'Standardanbieter',
             defaultVendorDescription: (isReimbursable: boolean) =>
                 isReimbursable
-                    ? `Legen Sie einen Standardlieferanten fest, der auf erstattungsfähige Ausgaben angewendet wird, für die es in Sage Intacct keinen passenden Lieferanten gibt.`
-                    : `Ausgaben, die keinem Ihrer Sage Intacct-Lieferanten zugeordnet werden können, werden standardmäßig diesem Lieferanten zugewiesen.`,
+                    ? `Legen Sie einen Standardlieferanten fest, der auf erstattungsfähige Ausgaben angewendet wird, für die es keinen passenden Lieferanten in Sage Intacct gibt.`
+                    : `Ausgaben, die keinen Ihrer Sage Intacct-Lieferanten zugeordnet werden können, werden standardmäßig diesem Lieferanten zugewiesen.`,
             exportDescription: 'Konfigurieren Sie, wie Expensify Daten nach Sage Intacct exportiert.',
             exportPreferredExporterNote:
                 'Der bevorzugte Exporteur kann jede Workspace-Adminperson sein, muss jedoch auch Domain-Admin sein, wenn du in den Domaineinstellungen unterschiedliche Exportkonten für einzelne Firmenkarten festlegst.',
@@ -6972,10 +6972,10 @@ Der Control-Tarif beginnt bei 9 $ pro aktivem Mitglied und Monat.`,
             defaultVendor: 'Standardanbieter',
             defaultVendorHelperText: ({isSet}: DefaultVendorHelperTextParams) =>
                 isSet
-                    ? `Expenses that don't auto-match will default to this vendor.`
-                    : `Expenses that don't auto-match will default to this vendor. Otherwise, they'll export as Credit Card Misc.`,
+                    ? `Spesen, die nicht automatisch abgeglichen werden, werden standardmäßig diesem Anbieter zugeordnet.`
+                    : `Ausgaben, die nicht automatisch abgeglichen werden, werden standardmäßig diesem Lieferanten zugeordnet. Andernfalls werden sie als „Credit Card Misc.“ exportiert.`,
             defaultVendorSelectHeader: ({connectionName}: ConnectionDisplayNameParams) =>
-                `Wählen Sie einen Standard-${connectionName}-Anbieter für Ausgaben, die nicht automatisch zugeordnet werden.`,
+                `Wählen Sie einen Standard-${connectionName}-Lieferanten für Ausgaben, die nicht automatisch zugeordnet werden.`,
             defaultAccount: 'Standardkonto',
             autoSync: 'Automatische Synchronisierung',
             autoSyncDescription: 'NetSuite und Expensify automatisch jeden Tag synchronisieren. Finalisierte Berichte in Echtzeit exportieren',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 9d2f50216d3..f521b9f0fd0 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -4967,7 +4967,7 @@ ${amount} para ${merchant} - ${date}`,
             defaultVendorDescription: (isReimbursable: boolean) =>
                 isReimbursable
                     ? `Establece un proveedor predeterminado que se aplicará a los gastos reembolsables que no tengan un proveedor coincidente en Sage Intacct.`
-                    : `Los gastos que no se puedan asociar a tus proveedores de Sage Intacct se asignarán a este proveedor de forma predeterminada.`,
+                    : `Los gastos que no se puedan conciliar con tus proveedores de Sage Intacct se asignarán por defecto a este proveedor.`,
             exportDescription: 'Configure cómo se exportan los datos de Expensify a Sage Intacct.',
             exportPreferredExporterNote:
                 'El exportador preferido puede ser cualquier administrador del área de trabajo, pero también debe ser un administrador del dominio si establece diferentes cuentas de exportación para tarjetas de empresa individuales en Configuración del dominio.',
@@ -6758,8 +6758,8 @@ El plan Controlar empieza en 9 $ por miembro activo al mes.`,
             defaultVendor: 'Proveedor predeterminado',
             defaultVendorHelperText: ({isSet}: DefaultVendorHelperTextParams) =>
                 isSet
-                    ? `Expenses that don't auto-match will default to this vendor.`
-                    : `Expenses that don't auto-match will default to this vendor. Otherwise, they'll export as Credit Card Misc.`,
+                    ? `Los gastos que no se asignen automáticamente se asociarán por defecto a este proveedor.`
+                    : `Los gastos que no se concilien automáticamente se asignarán a este proveedor de forma predeterminada. En caso contrario, se exportarán como Credit Card Misc.`,
             defaultVendorSelectHeader: ({connectionName}: ConnectionDisplayNameParams) =>
                 `Elige un proveedor predeterminado de ${connectionName} para los gastos que no se asignen automáticamente.`,
             defaultAccount: 'Cuenta predeterminada',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 7fd73a6f024..f2be49975a1 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -5082,8 +5082,8 @@ ${amount} pour ${merchant} - ${date}`,
             defaultVendor: 'Fournisseur par défaut',
             defaultVendorDescription: (isReimbursable: boolean) =>
                 isReimbursable
-                    ? `Définissez un fournisseur par défaut qui sera appliqué aux dépenses remboursables ne disposant pas d’un fournisseur correspondant dans Sage Intacct.`
-                    : `Les dépenses qui ne peuvent pas être rapprochées de vos fournisseurs Sage Intacct seront par défaut attribuées à ce fournisseur.`,
+                    ? `Définissez un fournisseur par défaut qui s’appliquera aux dépenses remboursables n’ayant pas de fournisseur correspondant dans Sage Intacct.`
+                    : `Les dépenses qui ne peuvent pas être associées à vos fournisseurs Sage Intacct seront, par défaut, affectées à ce fournisseur.`,
             exportDescription: 'Configurez comment les données Expensify sont exportées vers Sage Intacct.',
             exportPreferredExporterNote:
                 'L’exportateur préféré peut être n’importe quel administrateur d’espace de travail, mais doit également être un administrateur de domaine si vous définissez des comptes d’exportation différents pour chaque carte d’entreprise individuelle dans les paramètres de domaine.',
@@ -6999,8 +6999,8 @@ Le forfait Control commence à 9 $ par Membre actif et par mois.`,
             defaultVendor: 'Fournisseur par défaut',
             defaultVendorHelperText: ({isSet}: DefaultVendorHelperTextParams) =>
                 isSet
-                    ? `Expenses that don't auto-match will default to this vendor.`
-                    : `Expenses that don't auto-match will default to this vendor. Otherwise, they'll export as Credit Card Misc.`,
+                    ? `Les dépenses qui ne sont pas automatiquement rapprochées seront, par défaut, associées à ce fournisseur.`
+                    : `Les dépenses qui ne sont pas associées automatiquement seront attribuées par défaut à ce fournisseur. Sinon, elles seront exportées sous Crédit carte diverse.`,
             defaultVendorSelectHeader: ({connectionName}: ConnectionDisplayNameParams) =>
                 `Choisissez un fournisseur ${connectionName} par défaut pour les dépenses qui ne correspondent pas automatiquement.`,
             defaultAccount: 'Compte par défaut',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 551fa8a1347..166d45713b6 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -5052,7 +5052,7 @@ ${amount} per ${merchant} - ${date}`,
             defaultVendorDescription: (isReimbursable: boolean) =>
                 isReimbursable
                     ? `Imposta un fornitore predefinito che verrà applicato alle spese rimborsabili che non hanno un fornitore corrispondente in Sage Intacct.`
-                    : `Le spese che non possono essere abbinate ai tuoi fornitori Sage Intacct verranno assegnate a questo fornitore per impostazione predefinita.`,
+                    : `Le spese che non possono essere abbinate ai tuoi fornitori Sage Intacct verranno associate per impostazione predefinita a questo fornitore.`,
             exportDescription: 'Configura come i dati di Expensify vengono esportati in Sage Intacct.',
             exportPreferredExporterNote:
                 'L’esportatore preferito può essere qualsiasi amministratore dello spazio di lavoro, ma deve anche essere un Amministratore del dominio se imposti conti di esportazione diversi per le singole carte aziendali nelle Impostazioni del dominio.',
@@ -6953,8 +6953,8 @@ Il piano Control parte da 9 $ al mese per ogni membro attivo.`,
             defaultVendor: 'Fornitore predefinito',
             defaultVendorHelperText: ({isSet}: DefaultVendorHelperTextParams) =>
                 isSet
-                    ? `Expenses that don't auto-match will default to this vendor.`
-                    : `Expenses that don't auto-match will default to this vendor. Otherwise, they'll export as Credit Card Misc.`,
+                    ? `Le spese che non vengono abbinate automaticamente verranno assegnate per impostazione predefinita a questo fornitore.`
+                    : `Le spese che non vengono abbinate automaticamente useranno questo fornitore per impostazione predefinita. In caso contrario, saranno esportate come Varie carta di credito.`,
             defaultVendorSelectHeader: ({connectionName}: ConnectionDisplayNameParams) =>
                 `Scegli un fornitore predefinito ${connectionName} per le spese che non vengono abbinate automaticamente.`,
             defaultAccount: 'Conto predefinito',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 8fecf0e8df3..294b078b7dd 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -5006,8 +5006,8 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
             defaultVendor: 'デフォルトのベンダー',
             defaultVendorDescription: (isReimbursable: boolean) =>
                 isReimbursable
-                    ? `Sage Intacct で一致するベンダーがない立替経費に適用するデフォルトのベンダーを設定します。`
-                    : `Sage Intacct の取引先に照合できない経費は、デフォルトでこの取引先に紐づけられます。`,
+                    ? `Sage Intacct で一致する仕入先がない立替経費に適用するデフォルトの仕入先を設定します。`
+                    : `Sage Intacct の仕入先に照合できない経費は、デフォルトでこの仕入先に紐づけられます。`,
             exportDescription: 'Expensify のデータを Sage Intacct へエクスポートする方法を設定します。',
             exportPreferredExporterNote:
                 '優先されるエクスポーターは任意のワークスペース管理者にできますが、ドメイン設定で会社カードごとに別々のエクスポート先口座を設定している場合は、ドメイン管理者である必要もあります。',
@@ -6873,9 +6873,9 @@ Control プランは、アクティブメンバー1人あたり月額 $9 から
             defaultVendor: 'デフォルトのベンダー',
             defaultVendorHelperText: ({isSet}: DefaultVendorHelperTextParams) =>
                 isSet
-                    ? `Expenses that don't auto-match will default to this vendor.`
-                    : `Expenses that don't auto-match will default to this vendor. Otherwise, they'll export as Credit Card Misc.`,
-            defaultVendorSelectHeader: ({connectionName}: ConnectionDisplayNameParams) => `自動的に照合されない経費に使用する、デフォルトの ${connectionName} 取引先を選択します。`,
+                    ? `自動照合されない経費は、デフォルトでこのベンダーに割り当てられます。`
+                    : `自動照合されない経費は、デフォルトでこのベンダーに割り当てられます。それ以外は「Credit Card Misc」としてエクスポートされます。`,
+            defaultVendorSelectHeader: ({connectionName}: ConnectionDisplayNameParams) => `自動的に照合されない経費に対して使用する、デフォルトの ${connectionName} 仕入先を選択します。`,
             defaultAccount: 'デフォルトのアカウント',
             autoSync: '自動同期',
             autoSyncDescription: 'NetSuite と Expensify を毎日自動で同期。確定したレポートをリアルタイムでエクスポート',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 6a5ac82dfa4..0d6dbda5318 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -5045,8 +5045,8 @@ ${amount} voor ${merchant} - ${date}`,
             defaultVendor: 'Standaardleverancier',
             defaultVendorDescription: (isReimbursable: boolean) =>
                 isReimbursable
-                    ? `Stel een standaardleverancier in die wordt toegepast op declarabele uitgaven waarvoor geen overeenkomende leverancier in Sage Intacct is.`
-                    : `Uitgaven die niet aan je Sage Intacct-leveranciers kunnen worden gekoppeld, worden standaard aan deze leverancier toegewezen.`,
+                    ? `Stel een standaardleverancier in die wordt toegepast op vergoedbare uitgaven waarvoor geen overeenkomende leverancier in Sage Intacct is.`
+                    : `Declaraties die niet overeenkomen met je Sage Intacct-leveranciers worden standaard aan deze leverancier toegewezen.`,
             exportDescription: 'Configureer hoe Expensify-gegevens worden geëxporteerd naar Sage Intacct.',
             exportPreferredExporterNote:
                 'De voorkeurs-exporteur kan elke werkruimtebeheerder zijn, maar moet ook een domeinbeheerder zijn als je in Domeininstellingen verschillende exportrekeningen instelt voor individuele bedrijfskaarten.',
@@ -6939,10 +6939,10 @@ Het Control-abonnement begint bij $9 per actieve deelnemer per maand.`,
             defaultVendor: 'Standaardleverancier',
             defaultVendorHelperText: ({isSet}: DefaultVendorHelperTextParams) =>
                 isSet
-                    ? `Expenses that don't auto-match will default to this vendor.`
-                    : `Expenses that don't auto-match will default to this vendor. Otherwise, they'll export as Credit Card Misc.`,
+                    ? `Declaraties die niet automatisch worden gematcht, worden standaard aan deze leverancier gekoppeld.`
+                    : `Bonnetjes die niet automatisch worden gekoppeld, worden standaard aan deze leverancier toegewezen. Anders worden ze geëxporteerd als Credit Card Misc.`,
             defaultVendorSelectHeader: ({connectionName}: ConnectionDisplayNameParams) =>
-                `Kies een standaard ${connectionName}-leverancier voor uitgaven die niet automatisch worden gekoppeld.`,
+                `Kies een standaard ${connectionName}-leverancier voor uitgaven die niet automatisch worden gematcht.`,
             defaultAccount: 'Standaardrekening',
             autoSync: 'Automatisch synchroniseren',
             autoSyncDescription: 'Synchroniseer NetSuite en Expensify automatisch, elke dag. Exporteer een afgerond rapport in realtime',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 72b0d50c9af..dcd91868f7f 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -5031,8 +5031,8 @@ ${amount} dla ${merchant} - ${date}`,
             defaultVendor: 'Domyślny dostawca',
             defaultVendorDescription: (isReimbursable: boolean) =>
                 isReimbursable
-                    ? `Ustaw domyślnego dostawcę, który będzie stosowany do wydatków podlegających zwrotowi, jeśli nie mają pasującego dostawcy w Sage Intacct.`
-                    : `Wydatki, których nie da się dopasować do kontrahentów w Sage Intacct, zostaną domyślnie przypisane do tego kontrahenta.`,
+                    ? `Ustaw domyślnego dostawcę, który zostanie zastosowany do wydatków podlegających zwrotowi, niemających pasującego dostawcy w Sage Intacct.`
+                    : `Wydatki, których nie da się dopasować do Twoich dostawców Sage Intacct, zostaną domyślnie przypisane do tego dostawcy.`,
             exportDescription: 'Skonfiguruj sposób eksportu danych z Expensify do Sage Intacct.',
             exportPreferredExporterNote:
                 'Preferowanym eksporterem może być dowolny administrator przestrzeni roboczej, ale musi on również być administratorem domeny, jeśli w Ustawieniach domeny ustawisz różne konta eksportu dla poszczególnych kart firmowych.',
@@ -6920,9 +6920,10 @@ Plan Control zaczyna się od 9 USD za aktywnego członka miesięcznie.`,
             defaultVendor: 'Domyślny dostawca',
             defaultVendorHelperText: ({isSet}: DefaultVendorHelperTextParams) =>
                 isSet
-                    ? `Expenses that don't auto-match will default to this vendor.`
-                    : `Expenses that don't auto-match will default to this vendor. Otherwise, they'll export as Credit Card Misc.`,
-            defaultVendorSelectHeader: ({connectionName}: ConnectionDisplayNameParams) => `Wybierz domyślnego dostawcę ${connectionName} dla wydatków, które nie pasują automatycznie.`,
+                    ? `Wydatki, które nie dopasują się automatycznie, będą domyślnie przypisane do tego dostawcy.`
+                    : `Wydatki, które nie dopasują się automatycznie, zostaną domyślnie przypisane do tego dostawcy. W przeciwnym razie zostaną wyeksportowane jako Credit Card Misc.`,
+            defaultVendorSelectHeader: ({connectionName}: ConnectionDisplayNameParams) =>
+                `Wybierz domyślnego dostawcę ${connectionName} dla wydatków, które nie zostaną dopasowane automatycznie.`,
             defaultAccount: 'Domyślne konto',
             autoSync: 'Automatyczna synchronizacja',
             autoSyncDescription: 'Synchronizuj NetSuite i Expensify automatycznie, każdego dnia. Eksportuj sfinalizowany raport w czasie rzeczywistym',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index ee5534fa27d..87535086800 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -5038,7 +5038,7 @@ ${amount} para ${merchant} - ${date}`,
             defaultVendorDescription: (isReimbursable: boolean) =>
                 isReimbursable
                     ? `Defina um fornecedor padrão que será aplicado às despesas reembolsáveis que não tiverem um fornecedor correspondente no Sage Intacct.`
-                    : `Despesas que não puderem ser associadas aos seus fornecedores do Sage Intacct serão atribuídas a este fornecedor por padrão.`,
+                    : `As despesas que não puderem ser associadas aos seus fornecedores do Sage Intacct serão atribuídas a este fornecedor por padrão.`,
             exportDescription: 'Configure como os dados do Expensify são exportados para o Sage Intacct.',
             exportPreferredExporterNote:
                 'O exportador preferencial pode ser qualquer administrador do espaço de trabalho, mas também deve ser um Administrador de Domínio se você definir diferentes contas de exportação para cartões corporativos individuais em Configurações de Domínio.',
@@ -6932,8 +6932,8 @@ O plano Control começa em US$ 9 por membro ativo por mês.`,
             defaultVendor: 'Fornecedor padrão',
             defaultVendorHelperText: ({isSet}: DefaultVendorHelperTextParams) =>
                 isSet
-                    ? `Expenses that don't auto-match will default to this vendor.`
-                    : `Expenses that don't auto-match will default to this vendor. Otherwise, they'll export as Credit Card Misc.`,
+                    ? `Despesas que não forem correspondidas automaticamente terão este fornecedor como padrão.`
+                    : `Despesas que não forem conciliadas automaticamente serão atribuídas a este fornecedor por padrão. Caso contrário, serão exportadas como Credit Card Misc.`,
             defaultVendorSelectHeader: ({connectionName}: ConnectionDisplayNameParams) =>
                 `Escolha um fornecedor padrão do ${connectionName} para despesas que não sejam correspondidas automaticamente.`,
             defaultAccount: 'Conta padrão',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 0020eee7346..6b7b1f36582 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4889,7 +4889,7 @@ ${amount},商户:${merchant} - 日期:${date}`,
             creditCardAccount: '信用卡账户',
             defaultVendor: '默认供应商',
             defaultVendorDescription: (isReimbursable: boolean) =>
-                isReimbursable ? `为可报销但在 Sage Intacct 中没有匹配供应商的报销费用设置一个默认供应商。` : `无法与 Sage Intacct 供应商匹配的报销将默认归入此供应商。`,
+                isReimbursable ? `为可报销但在 Sage Intacct 中没有匹配供应商的报销费用设置一个默认供应商。` : `无法与 Sage Intacct 供应商匹配的报销将默认归到此供应商名下。`,
             exportDescription: '配置 Expensify 数据导出到 Sage Intacct 的方式。',
             exportPreferredExporterNote: '首选导出人可以是任意工作区管理员,但如果你在“域设置”中为各个公司卡设置了不同的导出账户,则该导出人还必须是域管理员。',
             exportPreferredExporterSubNote: '设置完成后,首选导出人将在其账户中看到可供导出的报表。',
@@ -6715,10 +6715,8 @@ _如需更详细的说明,请[访问我们的帮助网站](${CONST.NETSUITE_IM
             exportDate: '导出日期',
             defaultVendor: '默认供应商',
             defaultVendorHelperText: ({isSet}: DefaultVendorHelperTextParams) =>
-                isSet
-                    ? `Expenses that don't auto-match will default to this vendor.`
-                    : `Expenses that don't auto-match will default to this vendor. Otherwise, they'll export as Credit Card Misc.`,
-            defaultVendorSelectHeader: ({connectionName}: ConnectionDisplayNameParams) => `为未自动匹配的报销选择一个默认的 ${connectionName} 供应商。`,
+                isSet ? `未自动匹配的报销将默认归属到此供应商。` : `未自动匹配的报销将默认为此供应商,否则将以“信用卡杂项”导出。`,
+            defaultVendorSelectHeader: ({connectionName}: ConnectionDisplayNameParams) => `为未能自动匹配的报销选择一个默认的 ${connectionName} 供应商。`,
             defaultAccount: '默认账户',
             autoSync: '自动同步',
             autoSyncDescription: '每天自动同步 NetSuite 和 Expensify。实时导出已完成报表',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

The "Otherwise, they'll export as Credit Card Misc." fallback sentence
only applies to the credit-card-charge non-reimbursable export path.
On Vendor Bill export mode, no such fallback exists, so rendering the
same copy there would mislead admins about how unmatched expenses are
handled. Gate the helper text on nonReimbursable === CREDIT_CARD_CHARGE
so Vendor Bill mode falls back to no helper text.
Squawk! Translates the connection-name-free defaultVendorHelperText
variants into all supported languages, and refines a handful of adjacent
sageIntacct.defaultVendorDescription and defaultVendorSelectHeader
translations while we are here.

@mollfpr mollfpr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mollfpr
mollfpr merged commit 762b826 into main Jul 28, 2026
42 checks passed
@mollfpr
mollfpr deleted the claude-sageIntacctDefaultVendorRow branch July 28, 2026 08:03
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.4.46-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Help site review — no changes required

I reviewed the changes in this PR against the help site articles under docs/articles. No help-site updates are required. I did not open a draft PR.

Why: This PR is a UI-presentation + microcopy change to the Sage Intacct Default vendor row (toggle/accordion → always-visible arrow row) plus updated in-app helper/select-page copy. It does not change any capability that the help site documents. The one article that covers this flow — Configure-Sage-Intacct.md — already describes the behavior accurately and at a level that is agnostic to the in-app widget:

Export company card expenses as → Credit Card Charges / Vendor Bills — Optional: Set a default vendor for unmatched charges

That statement remains true after this PR. The article never described the old toggle, so nothing is now stale, and the exact in-app strings (Credit Card Misc. fallback, select-page header) aren't mirrored in the docs.

What I checked
  • Searched all Sage Intacct articles (new-expensify and expensify-classic) for default vendor, non-reimbursable, credit card charge, export company card.
  • The only substantive matches are in Configure-Sage-Intacct.md (New Expensify), lines 119 and 121–131, which describe the optional default vendor for out-of-pocket and company-card exports — still accurate.
  • The reimbursable / Vendor Bill paths are explicitly unchanged by this PR, and the docs don't reference the accordion/toggle mechanic that was reshaped.

Optional (not required): if you'd like, the article could add a one-line note that unmatched credit-card-charge expenses export as Credit Card Misc. when no default vendor is set — this fallback is newly surfaced in the app copy but isn't documented today. Reply and I'll open that draft PR.

Since no help-site PR was created, there's nothing linked to review. If you'd like the optional enhancement above, just say the word and I'll open a draft PR (titled per your format, labeled HelpDot, assigned to you).

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@melvin-bot

melvin-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #97533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

InternalQA This pull request required internal QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants