You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-16] [Verify account] Workflows > Add bank account pops the next step after magic code verification #101748
As an unvalidated workspace admin, going to Workflows > Payments > Add bank account > Connect manually (or Log into your bank) and entering the magic code puts you back on the "Connect manually / Log into your bank" screen instead of the next bank account step.
That omission creates a race. The verify account screen and VerifiedBankAccountFlowEntryPoint.tsx live in the same modal stack, so both stay mounted and both react to the same account.validated Onyx merge:
VerifyAccountPageBase's own effect at VerifyAccountPageBase.tsx:74-87 finds no navigateForwardTo, so it falls into handleCloseWithFallback() → Navigation.goBack(navigateBackTo), which pops back to the entry path — taking the freshly pushed step with it.
Solution
Give the verify account page ownership of the forward transition so only one place navigates after validation.
Action Items
Pass navigateForwardTo: in DynamicReimbursementAccountVerifyAccountPage.tsx, read ONYXKEYS.REIMBURSEMENT_ACCOUNT_OPTION_PRESSED plus the policy/currency context and compute the forward route the same way prepareNextStep / handleConnectManually / handleConnectPlaid do (MANUAL → the USD or non-USD setup step, PLAID → the Plaid step). Mirror DynamicAddBankAccountVerifyAccountPage.tsx:26-39.
Remove the duplicate navigation: once the verify page forwards, drop the Onyx-driven effect at VerifiedBankAccountFlowEntryPoint.tsx:163-187 or convert it to the onValidationSuccess callback VerifyAccountPageBase already exposes. Two post-validation Navigation calls is the bug; deleting one removes it structurally rather than reordering it.
Cover both branches: verify Connect manually and Log into your bank separately — they take different forward routes.
Verify: as an unvalidated admin, Workflows > Payments > Add bank account > Connect manually > enter the magic code, and confirm you land on the next bank account step and stay there.
Specific Component to Migrate
DynamicReimbursementAccountVerifyAccountPage
Current files: src/pages/ReimbursementAccount/DynamicReimbursementAccountVerifyAccountPage.tsx, src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx
changed the title [-][Verify account] Workflows > Add bank account pops the next step after magic code verification[/-][+][Due for payment 2026-10-16] [Verify account] Workflows > Add bank account pops the next step after magic code verification[/+]on Oct 9, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.6-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-16. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
This is sub-issue of project #72980 which was before Sep 19, so the payment will be $250
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Scenario 1: Connect manually on a USD workspace
Open app as an admin with an unvalidated account on a USD workspace with no bank account
Navigate to Workspace > Workflows > Payments > Add bank account
Tap "Connect manually"
Verify that the "Validate your account" magic code screen opens
Enter the magic code
Verify that you land on the Country step of the bank account setup
Scenario 2: Log into your bank on a USD workspace
Open app as an admin with an unvalidated account on a USD workspace with no bank account
Navigate to Workspace > Workflows > Payments > Add bank account
Tap "Log into your bank"
Enter the magic code
Verify that you land on the Country step of the bank account setup
Wait a few seconds
Verify that you stay on the Country step and are not sent back to the "Add bank account" screen
Continue past the Country step
Verify that the bank info step offers the Plaid login
Scenario 3: Connect manually on a non-USD workspace
Open app as an admin with an unvalidated account on a workspace whose default currency is not USD (e.g. EUR) and which has no bank account
Navigate to Workspace > Workflows > Payments > Add bank account
Verify that only "Connect manually" is shown
Tap "Connect manually" and enter the magic code
Verify that you land on the "Currency and country" step
Scenario 4: Admin who is already validated
Open app as an admin with a validated account on a USD workspace with no bank account
Navigate to Workspace > Workflows > Payments > Add bank account
Tap "Connect manually"
Verify that the magic code screen is skipped and you land directly on the Country step
Activity
[-][Verify account] Workflows > Add bank account pops the next step after magic code verification[/-][+][Due for payment 2026-10-16] [Verify account] Workflows > Add bank account pops the next step after magic code verification[/+]melvin-bot commentedon Oct 9, 2026
@aimane-chnaif
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.6-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-16. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
aimane-chnaif commentedon Oct 11, 2026
This is sub-issue of project #72980 which was before Sep 19, so the payment will be $250
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Scenario 1: Connect manually on a USD workspace
Scenario 2: Log into your bank on a USD workspace
Scenario 3: Connect manually on a non-USD workspace
Scenario 4: Admin who is already validated
Do we agree 👍 or 👎
melvin-bot commentedon Oct 12, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 15, 2026
Payment Summary
Resolving PRs:
Add bank account pops the next step after magic code verification #102522
Contributor: @jmusial does not require payment (Contractor)
Reviewer: @aimane-chnaif owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Oct 17, 2026
Payment Summary
Contributor+: @aimane-chnaif due $250 via NewDot
Paying $250 cuz of the above.
aimane-chnaif commentedon Oct 18, 2026
@mallenexpensify can you please check these issues as well? Thanks
mallenexpensify commentedon Oct 18, 2026
@aimane-chnaif both updated.
garrettmknight commentedon Oct 30, 2026
$250 approved for @aimane-chnaif