You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-12] Providing magic code during verification navigates back instead of continuing forward in flow #72980
Version Number: 9.2.34-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@OlGierd03 Slack conversation (hyperlinked to channel name): #Expensify Bugs
Action Performed:
Log in with a new account and do not verify with a magic code
Create a workspace as admin using the green "+" button
Go to the Inbox tab and create an expense in the workspace
Submit and approve the expense
Click the Pay button → choose Pay with business account or Mark as Paid
When prompted, enter the magic code to verify the account
Observe navigation after submitting the magic code
Expected Result:
After successfully providing the magic code, the user should be navigated forward to the next step in the payment flow, continuing where they left off.
Actual Result:
After entering the magic code, the app navigates backward, behaving like a backTo navigation. The user is returned to the previous screen instead of progressing, breaking the flow.
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceScreen.Recording.2025-10-20.at.13.47.20.movRecording.1784.mp4
Hi, I'm from Software Mansion and am familiar with the issue. I've been working on the SettlementButton and would like to work on this issue as a follow-up to #71330
@mountiny since you assigned to me after @aimane-chnaif posted their amount, I'm assuming you're 👍 with $1500. I'll leave open for a day or three then close
As an unvalidated workspace admin with an eligible business bank account visible, go to Workflows > Payments and click Add bank account.
On "Choose an existing bank account to pay expenses or add a new one.", click Add bank account.
Actual: Not Found page.
3. Works, but only by accident: Add domain
AddDomainPage.tsx:142 now uses useVerifyAccountAndResume.
But WORKSPACES_ADD_DOMAIN isn't in DYNAMIC_ROUTES.VERIFY_ACCOUNT.entryScreens, so the dynamic route fails validation (and logs a warning).
It only resolves because the old static WORKSPACES_ADD_DOMAIN_VERIFY_ACCOUNT screen is still registered at the same URL.
If that leftover screen is deleted, Add domain breaks.
The clean fix is to add the screen to entryScreens.
@jmusial please check ^ and validate findings.
Should we create new sub-issues for these?
All three reproduce in code at 54b6817. Each issue has the mechanism, permalinked code, and action items.
What the verification turned up
Case 1 — confirmed, with a sharper root cause than "the step gets popped".DynamicReimbursementAccountVerifyAccountPage.tsx:9-13 is the only caller of VerifyAccountPageBase that omits navigateForwardTo. Both it and VerifiedBankAccountFlowEntryPoint.tsx sit in the same modal stack and react to the same account.validated merge: the entry point pushes the next step, then VerifyAccountPageBase.tsx:74-87 falls into handleCloseWithFallback() and pops it back off. Two navigations racing, not one bad one — so the fix deletes one of them rather than reordering.
Case 2 — confirmed, one-line fix.SCREENS.CONNECT_EXISTING_BUSINESS_BANK_ACCOUNT_ROOT is missing from entryScreens on ROUTES.ts:166-186, so route resolution falls through to the '*' catch-all. The handler in PaymentMethodList is correct. Your line numbers were a few off at this SHA (PaymentMethodList.tsx:639-655); the issue uses the current ones.
Case 3 — confirmed exactly as described. The Log.warn fires at getStateFromPath.ts:68-71, then the static config.ts:2206 entry rescues it. The issue lists all six registration sites to remove once entryScreens is fixed, so the cleanup lands as one PR instead of a later surprise regression.
Verification was a static code trace, not a live repro, for all three.
Activity
melvin-bot commentedon Oct 20, 2025
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.OlGierd03 commentedon Oct 20, 2025
Hi, I'm from Software Mansion and am familiar with the issue. I've been working on the
SettlementButtonand would like to work on this issue as a follow-up to #71330mountiny commentedon Oct 21, 2025
Follow up to #69171
mountiny commentedon Oct 22, 2025
@OlGierd03 Will look into the fix
melvin-bot commentedon Oct 27, 2025
@OlGierd03 Eep! 4 days overdue now. Issues have feelings too...
muttmuure commentedon Oct 28, 2025
Still being worked on
229 remaining items
melvin-bot commentedon Sep 7, 2026
Auto-assign attempt failed, all eligible assignees are OOO.
mallenexpensify commentedon Sep 8, 2026
Payment Summary
Contributor+: @aimane-chnaif due $1500 via NewDot
@mountiny since you assigned to me after @aimane-chnaif posted their amount, I'm assuming you're 👍 with $1500. I'll leave open for a day or three then close
mountiny commentedon Sep 10, 2026
yeah looks good to me
melvin-bot commentedon Sep 10, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
garrettmknight commentedon Sep 14, 2026
$1500 approved for @aimane-chnaif
aimane-chnaif commentedon Sep 16, 2026
I found more flows where the flow stops after the magic code.
1. Workflows > Add bank account: the next step gets popped
Where: VerifiedBankAccountFlowEntryPoint.tsx:163-187, together with DynamicReimbursementAccountVerifyAccountPage.tsx:12.
Repro:
Screen.Recording.2026-09-16.at.6.22.38.PM.mov
2. Connect existing business bank account > Add bank account: Not Found instead of the verify page
Where: PaymentMethodList.tsx:630-634, rendered by ConnectExistingBusinessBankAccountPage.tsx:134.
Repro (if you have such an account):
3. Works, but only by accident: Add domain
AddDomainPage.tsx:142 now uses
useVerifyAccountAndResume.But
WORKSPACES_ADD_DOMAINisn't inDYNAMIC_ROUTES.VERIFY_ACCOUNT.entryScreens, so the dynamic route fails validation (and logs a warning).It only resolves because the old static
WORKSPACES_ADD_DOMAIN_VERIFY_ACCOUNTscreen is still registered at the same URL.If that leftover screen is deleted, Add domain breaks.
The clean fix is to add the screen to
entryScreens.@jmusial please check ^ and validate findings.
Should we create new sub-issues for these?
jmusial commentedon Sep 21, 2026
@aimane-chnaif yup, those cases indeed exist. Thank you for finding them!
@MelvinBot please add a separate sub issue under this issue for each case described here and assign @aimane-chnaif myself and @mountiny
@mountiny if you could please add labels once Melvin is done, thx
MelvinBot commentedon Sep 21, 2026
Created three sub-issues, one per case, all assigned to
jmusial,mountiny, andaimane-chnaif. No labels applied — over tomountiny.All three reproduce in code at
54b6817. Each issue has the mechanism, permalinked code, and action items.What the verification turned up
Case 1 — confirmed, with a sharper root cause than "the step gets popped".
DynamicReimbursementAccountVerifyAccountPage.tsx:9-13is the only caller ofVerifyAccountPageBasethat omitsnavigateForwardTo. Both it andVerifiedBankAccountFlowEntryPoint.tsxsit in the same modal stack and react to the sameaccount.validatedmerge: the entry point pushes the next step, thenVerifyAccountPageBase.tsx:74-87falls intohandleCloseWithFallback()and pops it back off. Two navigations racing, not one bad one — so the fix deletes one of them rather than reordering.Case 2 — confirmed, one-line fix.
SCREENS.CONNECT_EXISTING_BUSINESS_BANK_ACCOUNT_ROOTis missing fromentryScreensonROUTES.ts:166-186, so route resolution falls through to the'*'catch-all. The handler inPaymentMethodListis correct. Your line numbers were a few off at this SHA (PaymentMethodList.tsx:639-655); the issue uses the current ones.Case 3 — confirmed exactly as described. The
Log.warnfires atgetStateFromPath.ts:68-71, then the staticconfig.ts:2206entry rescues it. The issue lists all six registration sites to remove onceentryScreensis fixed, so the cleanup lands as one PR instead of a later surprise regression.Verification was a static code trace, not a live repro, for all three.
view run