You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-16] [$175] Accounting- RBR appears on Both QBO rows after making an error on last row #102378
Version Number: 9.4.94-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#101594 Email or phone of affected tester (no customers):duytestnguyen+389@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Pixel 7a Adnroid 17 App Component: Workspace Settings
Action Performed:
Preconditions:
Account with QBO connection on Workspace
Open Hybrid app
Go to Workspace setting
Go to Accounting > Advance
Turn 'Simulate failing network requests' on
Tap on 'QuickBooks Online invoice collection account'
Select any account in the list
Expected Result:
The RBR should appears on on 'QuickBooks Online invoice collection account' row
Actual Result:
The RBR appears on both "QuickBooks Online bill payment account", "QuickBooks Online invoice collection account" rows
The "bill payment account" row shows an RBR when either the reimbursement account or the collection account has an error.
In QuickbooksAdvancedPage.tsx:35, reimbursementOrCollectionAccountIDs holds both reimbursementAccountID and collectionAccountID. The bill payment row uses that list for its RBR and pending state (lines 82-84).
When the invoice collection account update fails, only errorFields.collectionAccountID is set. Both rows match it, so both show the RBR.
What changes do you think we should make in order to solve the problem?
In QuickbooksAdvancedPage.tsx, make the bill payment row use only CONST.QUICKBOOKS_CONFIG.REIMBURSEMENT_ACCOUNT_ID for subscribedSettings, brickRoadIndicator, and pendingAction. That matches the invoice collection row and the FX row, which each use only their own field. Then remove the unused reimbursementOrCollectionAccountIDs constant.
This change keeps the toggle case working. When the "Reimbursed reports" toggle fails, both fields get errors and both rows still show the RBR.
The "Reimbursed reports" toggle updates both keys (QuickbooksOnline.ts:534-542). On failure, buildOnyxDataForMultipleQuickbooksConfigurations sets an error on every updated key (QuickbooksOnline.ts:136-137). The bill payment row doesn't need to watch collectionAccountID to catch that case.
The same combined list also sets the bill payment row's pendingAction. So the row also greys out while only the collection account is saving. The fix above corrects that too.
What alternative solutions did you explore? (Optional)
None. A one-field-per-row mapping is the pattern the rest of this page already uses.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/102378) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Accounting- RBR appears on Both QBO rows after making an error on last row[/-][+][$175] Accounting- RBR appears on Both QBO rows after making an error on last row[/+]on Sep 28, 2026
Please re-state the problem that we are trying to solve in this issue.
In Workspace > Accounting > QuickBooks Online > Advanced, when an error occurs on the "QuickBooks Online invoice collection account" row (e.g. during a network failure), the Red Brick Road (RBR) error indicator appears on both the "QuickBooks Online bill payment account" row and the "QuickBooks Online invoice collection account" row, instead of only on the invoice collection account row.
What is the root cause of that problem?
In src/pages/workspace/accounting/qbo/advanced/QuickbooksAdvancedPage.tsx:
Because qboBillPaymentAccount configures strictly the reimbursement account (qboConfig?.reimbursementAccountID), subscribing it to [REIMBURSEMENT_ACCOUNT_ID, COLLECTION_ACCOUNT_ID] causes areSettingsInErrorFields to evaluate to true whenever errorFields.collectionAccountID is present.
As a result, an error that belongs solely to the invoice collection account leaks to the bill payment account row, showing an unexpected RBR error on both rows.
What changes do you think we should make in order to solve the problem?
In src/pages/workspace/accounting/qbo/advanced/QuickbooksAdvancedPage.tsx:
Replace reimbursementOrCollectionAccountIDs with reimbursementAccountIDs containing only CONST.QUICKBOOKS_CONFIG.REIMBURSEMENT_ACCOUNT_ID.
Update the qboBillPaymentAccount menu item to subscribe solely to reimbursementAccountIDs.
What alternative solutions did you explore? (Optional)
Inline filtering within areSettingsInErrorFields: Unnecessary overhead. Each row in the accordion represents an independent setting with its own selector page, so subscribing each row strictly to its respective setting key matches the pattern used by qboInvoiceCollectionAccount and qboFxExpenseAccount.
The bill-payment row is subscribed to both QuickBooks fields:
[reimbursementAccountID, collectionAccountID]
even though that row only represents reimbursementAccountID. Because the row passes that combined list to both areSettingsInErrorFields() and settingsPendingAction(), a failed update to the invoice collection account also makes the bill-payment row show an RBR (and can make it appear pending).
The two selectors already update independent fields, so the UI subscription is broader than the data each row owns.
Fix
In QuickbooksAdvancedPage.tsx:
replace the combined reimbursementOrCollectionAccountIDs list with a reimbursement-only list;
use that reimbursement-only list for the bill-payment row's subscribedSettings, brickRoadIndicator, and pendingAction;
keep the invoice row on collectionAccountID;
remove the now-unused combined constant.
This preserves the reimbursed-reports toggle behavior: when that operation fails it writes errors to both fields, so each row will still independently show its own RBR.
Validation
I would cover the three relevant cases:
collection-account failure → RBR only on invoice collection row;
reimbursement-account failure → RBR only on bill-payment row;
reimbursed-reports toggle failure → both rows show RBR because both fields fail.
The same assertions should apply to pending state so a collection-only save does not gray out the bill-payment row.
Please re-state the problem that we are trying to solve in this issue.
In Workspace > Accounting > QuickBooks Online > Advanced, when a simulated network error or validation failure occurs on the "QuickBooks Online invoice collection account" row, the Red Brick Road (RBR) error indicator and pending state appear on both the "QuickBooks Online bill payment account" row and the "QuickBooks Online invoice collection account" row, instead of strictly on the invoice collection account row.
What is the root cause of that problem?
In src/pages/workspace/accounting/qbo/advanced/QuickbooksAdvancedPage.tsx:
The bill payment row configures strictly the reimbursement account (qboConfig?.reimbursementAccountID).
However, subscribing it to [REIMBURSEMENT_ACCOUNT_ID, COLLECTION_ACCOUNT_ID] causes areSettingsInErrorFields to evaluate to true whenever errorFields.collectionAccountID is present, leaking the error to the bill payment row.
Similarly, settingsPendingAction(reimbursementOrCollectionAccountIDs, qboConfig?.pendingFields) causes the bill payment row to prematurely display a pending/saving state whenever the invoice collection account is being saved.
What changes do you think we should make in order to solve the problem?
In src/pages/workspace/accounting/qbo/advanced/QuickbooksAdvancedPage.tsx:
Replace reimbursementOrCollectionAccountIDs with a dedicated reimbursement array reimbursementAccountIDs:
Add unit tests in tests/unit/pages/workspace/accounting/QuickbooksAdvancedPageTest.tsx:
Test 1: When qboConfig.errorFields.collectionAccountID is populated, assert that only the invoice collection account row displays brickRoadIndicator: 'error', while the bill payment row displays no indicator.
Test 2: When qboConfig.errorFields.reimbursementAccountID is populated, assert that only the bill payment row displays brickRoadIndicator: 'error'.
Test 3: When both fields have errors, assert that both rows independently display their respective indicators.
What alternative solutions did you explore? (Optional)
None. Each setting in the QuickBooks advanced accordion represents an independent configuration field with its own selector route. Subscribing each row strictly to its respective setting key matches the established pattern used by collectionAccountIDs and fxExpenseAccounts.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
applause-bot commentedon Sep 28, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/4837b2f72113421f4c4e06f1f245cdec9517a4e5b37a2fc2f85f786e4a066922
https://platform.applause.com/services/links/v1/external/4a8bc0fa502511bb36b1dd520e32890494e01d983257a873b61668bd947c76c5
MelvinBot commentedon Sep 28, 2026
Proposal
What is the root cause of that problem?
The "bill payment account" row shows an RBR when either the reimbursement account or the collection account has an error.
In
QuickbooksAdvancedPage.tsx:35,reimbursementOrCollectionAccountIDsholds bothreimbursementAccountIDandcollectionAccountID. The bill payment row uses that list for its RBR and pending state (lines 82-84).When the invoice collection account update fails, only
errorFields.collectionAccountIDis set. Both rows match it, so both show the RBR.This bug is older than
MenuItemdecomposition - section rows. That PR's base commit already had the same logic, so it's not a regression.What changes do you think we should make in order to solve the problem?
In
QuickbooksAdvancedPage.tsx, make the bill payment row use onlyCONST.QUICKBOOKS_CONFIG.REIMBURSEMENT_ACCOUNT_IDforsubscribedSettings,brickRoadIndicator, andpendingAction. That matches the invoice collection row and the FX row, which each use only their own field. Then remove the unusedreimbursementOrCollectionAccountIDsconstant.This change keeps the toggle case working. When the "Reimbursed reports" toggle fails, both fields get errors and both rows still show the RBR.
Supporting evidence
REIMBURSEMENT_ACCOUNT_ID(QuickbooksAccountSelectPage.tsx:103-106).COLLECTION_ACCOUNT_ID(QuickbooksInvoiceAccountSelectPage.tsx:104-107).QuickbooksOnline.ts:534-542). On failure,buildOnyxDataForMultipleQuickbooksConfigurationssets an error on every updated key (QuickbooksOnline.ts:136-137). The bill payment row doesn't need to watchcollectionAccountIDto catch that case.pendingAction. So the row also greys out while only the collection account is saving. The fix above corrects that too.What alternative solutions did you explore? (Optional)
None. A one-field-per-row mapping is the pattern the rest of this page already uses.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/102378)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
melvin-bot commentedon Sep 28, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
External)[-]Accounting- RBR appears on Both QBO rows after making an error on last row[/-][+][$175] Accounting- RBR appears on Both QBO rows after making an error on last row[/+]melvin-bot commentedon Sep 28, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022104424159433939951
ashusatyarthi-wq commentedon Sep 28, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
In Workspace > Accounting > QuickBooks Online > Advanced, when an error occurs on the "QuickBooks Online invoice collection account" row (e.g. during a network failure), the Red Brick Road (RBR) error indicator appears on both the "QuickBooks Online bill payment account" row and the "QuickBooks Online invoice collection account" row, instead of only on the invoice collection account row.
What is the root cause of that problem?
In
src/pages/workspace/accounting/qbo/advanced/QuickbooksAdvancedPage.tsx:Lines 35–37 define the error subscription keys:
The menu item configuration for the bill payment account row (
qboBillPaymentAccount) usesreimbursementOrCollectionAccountIDs(lines 78–85):Because
qboBillPaymentAccountconfigures strictly the reimbursement account (qboConfig?.reimbursementAccountID), subscribing it to[REIMBURSEMENT_ACCOUNT_ID, COLLECTION_ACCOUNT_ID]causesareSettingsInErrorFieldsto evaluate totruewhenevererrorFields.collectionAccountIDis present.As a result, an error that belongs solely to the invoice collection account leaks to the bill payment account row, showing an unexpected RBR error on both rows.
What changes do you think we should make in order to solve the problem?
In
src/pages/workspace/accounting/qbo/advanced/QuickbooksAdvancedPage.tsx:reimbursementOrCollectionAccountIDswithreimbursementAccountIDscontaining onlyCONST.QUICKBOOKS_CONFIG.REIMBURSEMENT_ACCOUNT_ID.qboBillPaymentAccountmenu item to subscribe solely toreimbursementAccountIDs.What alternative solutions did you explore? (Optional)
areSettingsInErrorFields: Unnecessary overhead. Each row in the accordion represents an independent setting with its own selector page, so subscribing each row strictly to its respective setting key matches the pattern used byqboInvoiceCollectionAccountandqboFxExpenseAccount.ashusatyarthi-wq commentedon Sep 28, 2026
Compare branch: https://github.com/ashusatyarthi-wq/App/compare/fix/qbo-advanced-rbr-error-102378
fix: scope QBO bill payment account row error subscription
franklincg commentedon Sep 28, 2026
Proposal
Root cause
The bill-payment row is subscribed to both QuickBooks fields:
[reimbursementAccountID, collectionAccountID]even though that row only represents
reimbursementAccountID. Because the row passes that combined list to bothareSettingsInErrorFields()andsettingsPendingAction(), a failed update to the invoice collection account also makes the bill-payment row show an RBR (and can make it appear pending).The two selectors already update independent fields, so the UI subscription is broader than the data each row owns.
Fix
In
QuickbooksAdvancedPage.tsx:reimbursementOrCollectionAccountIDslist with a reimbursement-only list;subscribedSettings,brickRoadIndicator, andpendingAction;collectionAccountID;This preserves the reimbursed-reports toggle behavior: when that operation fails it writes errors to both fields, so each row will still independently show its own RBR.
Validation
I would cover the three relevant cases:
The same assertions should apply to pending state so a collection-only save does not gray out the bill-payment row.
bonnhatnguyen commentedon Sep 29, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
In Workspace > Accounting > QuickBooks Online > Advanced, when a simulated network error or validation failure occurs on the "QuickBooks Online invoice collection account" row, the Red Brick Road (RBR) error indicator and pending state appear on both the "QuickBooks Online bill payment account" row and the "QuickBooks Online invoice collection account" row, instead of strictly on the invoice collection account row.
What is the root cause of that problem?
In
src/pages/workspace/accounting/qbo/advanced/QuickbooksAdvancedPage.tsx:Lines 35–37 define setting subscriptions:
The menu item configuration for the bill payment account (
qboBillPaymentAccount) usesreimbursementOrCollectionAccountIDs(lines 78–85):qboConfig?.reimbursementAccountID).[REIMBURSEMENT_ACCOUNT_ID, COLLECTION_ACCOUNT_ID]causesareSettingsInErrorFieldsto evaluate totruewhenevererrorFields.collectionAccountIDis present, leaking the error to the bill payment row.settingsPendingAction(reimbursementOrCollectionAccountIDs, qboConfig?.pendingFields)causes the bill payment row to prematurely display a pending/saving state whenever the invoice collection account is being saved.What changes do you think we should make in order to solve the problem?
In
src/pages/workspace/accounting/qbo/advanced/QuickbooksAdvancedPage.tsx:reimbursementOrCollectionAccountIDswith a dedicated reimbursement arrayreimbursementAccountIDs:qboBillPaymentAccountrow solely toreimbursementAccountIDs:Automated Unit Tests:
Add unit tests in
tests/unit/pages/workspace/accounting/QuickbooksAdvancedPageTest.tsx:qboConfig.errorFields.collectionAccountIDis populated, assert that only the invoice collection account row displaysbrickRoadIndicator: 'error', while the bill payment row displays no indicator.qboConfig.errorFields.reimbursementAccountIDis populated, assert that only the bill payment row displaysbrickRoadIndicator: 'error'.What alternative solutions did you explore? (Optional)
None. Each setting in the QuickBooks advanced accordion represents an independent configuration field with its own selector route. Subscribing each row strictly to its respective setting key matches the established pattern used by
collectionAccountIDsandfxExpenseAccounts.Contributor details
Your Expensify account email: bonnhatnguyen0@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0139ed4098bdc50182
22 remaining items
melvin-bot commentedon Oct 15, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 15, 2026
Payment Summary
Resolving PRs:
Show QBO bill payment account RBR only for its own field errors #102982
Reviewer: @parasharrajat owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Oct 17, 2026
Payment Summary
Contributor+: @parasharrajat due $175 via NewDot
@parasharrajat plz complete the Contributor+ checklist and tag me in a post once you have. Thx
mallenexpensify commentedon Oct 20, 2026
@parasharrajat plz complete the Contributor+ checklist and tag me in a post once you have. Thx
melvin-bot commentedon Oct 20, 2026
@parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
parasharrajat commentedon Oct 26, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: https://github.com/Expensify/App/pull/46511/files#r4377430393
Link to the comment on the Issue: https://github.com/Expensify/App/pull/46511/files#r4377430393
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/696150
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-d26d-ab58-c83f-2ec2adc6e164parasharrajat commentedon Oct 26, 2026
done @mallenexpensify