Skip to content

MenuItem decomposition - section rows - #101594

Merged
roryabraham merged 22 commits into
Expensify:mainfrom
software-mansion-labs:war-in/menuitem-decomposition-section
Sep 25, 2026
Merged

roryabraham merged 22 commits into
Expensify:mainfrom
software-mansion-labs:war-in/menuitem-decomposition-section

Conversation

@war-in

@war-in war-in commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds MenuItemSectionRow preset: a MenuItem.Root that bleeds through Section horizontal padding (replaces ad-hoc mhn5/mhn8 wrappers + sectionMenuItemTopDescription). Migrates section rows in ~25 settings/workspace pages (Profile, Preferences, Wallet, Subscription, Workspace overview/workflows/rules, etc.) to compound MenuItem API. No visual change intended.

Fixed Issues

$ #100159
PROPOSAL:

Tests

  1. Navigate to Account > Profile
  2. Verify that each row (display name, contact methods, status, pronouns, timezone, etc.) shows the label on top and value below, with chevron on navigable rows and red dot on rows with errors, full-width hover/press highlight aligned with Section edges
  3. Tap each navigable row and verify it opens the correct page
  4. Navigate to Account > Preferences
  5. Verify that Priority mode, Language, Payment currency and Theme rows look identical to main (label, value, chevron, "AI generated" hint for non-fully-supported languages) and each opens the correct page
  6. Navigate to Account > Wallet
  7. Verify that "Add personal card", "Import transactions" and "Looking for company cards?" rows render with correct icons, title/description and chevron, and each opens the correct flow
  8. Navigate to Workspaces > pick a workspace > Overview
  9. Verify that name, description, currency, address and plan type rows render and navigate as on main; repeat for Workflows (Approvals/Payments tabs), Reports, Rules, Receipt partners, Time tracking and Travel sections
  10. Navigate to Account > Subscription (on an account with a paid subscription)
  11. Verify that card section rows, subscription settings rows (auto-renew, add-on seats) and "Cancel subscription" row render and navigate as on main
  12. Repeat checks on narrow (mobile) and wide (desktop) layouts and verify that rows span full Section width in both
  13. Navigate to Workspaces > pick a workspace connected to Xero > Accounting > Advanced
  14. Verify that the "Auto-sync" row shows its value, a chevron and the accounting-method hint below it (when auto-sync is enabled), and that the "Xero bill payment account" and "Xero invoice collections account" rows show the selected account name with chevron (and a red dot when the setting has an error). Tap each row and verify it opens the correct page
  15. Navigate to Accounting > Import and open Chart of accounts, Customers and Tracking categories
  16. Verify that the "Displayed as" rows on Chart of accounts and Customers are not pressable and have no chevron, and that each tracking category row on Tracking categories shows "Map to" with the selected option, a chevron, and opens the mapping page
  17. On a workspace connected to QuickBooks Online, repeat step 13 on Accounting > Advanced (Auto-sync, "QuickBooks Online bill payment account", "QuickBooks Online invoice collection account")
  18. Navigate to Accounting > Import and open Chart of accounts, Classes, Customers, Locations and a Custom segment. Verify that the "Displayed as" row is not pressable on Chart of accounts and Custom segment, and is pressable with a chevron on Classes, Customers and Locations and opens the "Displayed as" page. On Locations, verify the hint about line items is shown below the row, and that the row is not pressable and has no chevron when non-reimbursable expenses are not exported as credit/debit card
  19. On a workspace connected to QuickBooks Desktop, verify that the "Auto-sync" row on Accounting > Advanced shows its value, chevron and hint and opens the Auto-sync page, and that on Accounting > Import the "Displayed as" row is not pressable on Chart of accounts and is pressable with chevron on Classes and Customers
  20. Navigate to Workspaces > pick a workspace > Workflows > Approvals > Add approval workflow (or edit an existing one) and verify that the "Approver" / "Additional approver" row shows the label with a chevron and opens the approver selector; submit without an approver and verify the red dot and the error message below the row
  21. Repeat checks on narrow (mobile) and wide (desktop) layouts and verify that rows span full Section width in both, with the highlight flush with the page edges on the accounting pages

Offline tests

N/A - UI-only refactor, no API or Onyx changes.

QA Steps

Same as tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Adds a `MenuItem.Root` variant that bleeds through a `Section`'s own
horizontal padding, replacing the `wrapperStyle`/negative-margin pairs
consumers were hand-rolling.

Migrates the section rows that only need the stable leaves
(Row/Icon/Content/Title/Description/Trailing/Chevron/NewWindowIcon).
@codecov

codecov Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

@war-in war-in changed the title MenuItem decomposition - section rows [HOLD #101318] MenuItem decomposition - section rows Sep 22, 2026
@war-in war-in changed the title [HOLD #101318] MenuItem decomposition - section rows MenuItem decomposition - section rows Sep 23, 2026
@war-in
war-in marked this pull request as ready for review September 23, 2026 09:53
@war-in
war-in requested review from a team as code owners September 23, 2026 09:53
@melvin-bot
melvin-bot Bot requested review from Pujan92 and joekaufmanexpensify and removed request for a team and joekaufmanexpensify September 23, 2026 09:54
@melvin-bot

melvin-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 23, 2026 09:54
@Pujan92

Pujan92 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-09-25.at.16.41.32.mov

@Pujan92 Pujan92 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot
melvin-bot Bot requested a review from roryabraham September 25, 2026 11:23
@roryabraham
roryabraham merged commit 074cd05 into Expensify:main Sep 25, 2026
34 of 35 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are needed for this PR, so I did not create a docs PR.

This PR is a UI-only refactor. It moves section rows to the compound MenuItem API with no intended visual or behavior change. Help articles describe feature names, labels, and navigation paths, and none of those changed.

What I checked
  • Labels: Every translation key the PR removes, it adds back in the same place (for example, priorityModePage.priorityMode, workspace.common.displayedAs, workspace.accounting.autoSync, subscription.details.taxExemptStatus). No copy changed.
  • Language files: The PR does not touch any src/languages/*.ts file.
  • Navigation: Each row keeps the same destination. The test steps confirm rows open the same pages as on main.
  • Behavior: The PR does not change any API or Onyx logic. It only changes layout (row padding and hover area).

view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants