Repository navigation
MenuItem decomposition - section rows - #101594
roryabraham merged 22 commits into
Conversation
Adds a `MenuItem.Root` variant that bleeds through a `Section`'s own horizontal padding, replacing the `wrapperStyle`/negative-margin pairs consumers were hand-rolling. Migrates the section rows that only need the stable leaves (Row/Icon/Content/Title/Description/Trailing/Chevron/NewWindowIcon).
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
MenuItem decomposition - section rowsMenuItem decomposition - section rows
# Conflicts: # src/pages/settings/Wallet/WalletPage/index.tsx # src/pages/workspace/workflows/tabs/WorkflowsPaymentsTab.tsx
MenuItem decomposition - section rowsMenuItem decomposition - section rows
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-09-25.at.16.41.32.mov |
# Conflicts: # src/pages/settings/Subscription/SubscriptionSettings/index.tsx
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.94-0 🚀
|
|
No help site changes are needed for this PR, so I did not create a docs PR. This PR is a UI-only refactor. It moves section rows to the compound What I checked
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Adds
MenuItemSectionRowpreset: aMenuItem.Rootthat bleeds throughSectionhorizontal padding (replaces ad-hocmhn5/mhn8wrappers +sectionMenuItemTopDescription). Migrates section rows in ~25 settings/workspace pages (Profile, Preferences, Wallet, Subscription, Workspace overview/workflows/rules, etc.) to compoundMenuItemAPI. No visual change intended.Fixed Issues
$ #100159
PROPOSAL:
Tests
main(label, value, chevron, "AI generated" hint for non-fully-supported languages) and each opens the correct pagemain; repeat for Workflows (Approvals/Payments tabs), Reports, Rules, Receipt partners, Time tracking and Travel sectionsmainOffline tests
N/A - UI-only refactor, no API or Onyx changes.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari