You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-08] [$175] Onboarding - Accounting tiles use checkbox style button when it does not support multi select #102469
Version Number: 9.4.95-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#102267 Email or phone of affected tester (no customers):dnjosjdojionjso@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Other
Action Performed:
Go to staging.new.expensify.com
Log in with new Gmail account.
Select Manage my team's expenses.
Proceed to "Do you use any accounting software?" step.
Expected Result:
Accounting tiles will show radio style button for single selection list (according to #87087).
Actual Result:
Accounting tiles use checkbox style button when it does not support multi selection.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root cause: The accounting tiles still use a RadioButton, but the PR forces a 4px border radius on it (BaseOnboardingAccounting.tsx:183-190). SelectionButton sets shape only from the radius, so a radio with radius 4 looks exactly like a checkbox (SelectionButton.tsx:132).
Recommendation: roll forward with a one-line fix. Don't revert. Reverting would undo a 20-file feature to fix one prop. In src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx, remove the override and its comment:
- {/* Square to match the mocks, but a radio because only one option can be picked. */}
<RadioButton
isChecked={isSelected}
onPress={() => handleIntegrationSelect(optionKey)}
accessibilityLabel={label}
- containerBorderRadius={variables.componentBorderRadiusSmall}
wrapperStyle={styles.onboardingAccountingItemSelectionButton}
/>
The mocks show squares, and design never answered the reviewer's question about it. If design wants the square shape, demote this issue instead. It's a cosmetic onboarding issue.
Investigation details
Before this PR, each option was a RadioButtonWithLabel with the default circle. That matches Consistent checkboxes and radio buttons UI: circle for single-select, square for multi-select.
Radio and checkbox draw the same filled container and checkmark when checked. The border radius is the only difference (SelectionButton.tsx:197-218, variables.ts:49-56). Screen readers still announce the control as a radio.
The reviewer asked design whether the square was intentional (comment). Nobody replied.
The existing UI test queries CONST.ROLE.RADIO, so it should still pass after the fix. variables is still used elsewhere in the file.
Suggested AI code review rule (app-coding-standards): Flag a containerBorderRadius on <RadioButton> unless it's the circle value. Flag a circle radius on <Checkbox>. Search pattern: <(RadioButton|Checkbox)\b[^>]*containerBorderRadius=. The reverse case already exists in SpendRuleListItem.tsx:58-60, where a Checkbox is forced round. A stronger option is to type containerBorderRadius?: never on RadioButtonProps.
Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.
Activity
applause-bot commentedon Sep 28, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/2d23da6fd400d805f04f361385ed8150020f872524cb6ef0c5e857afb8dbc4d8
melvin-bot commentedon Sep 28, 2026
@roryabraham recently merged #102267, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Sep 28, 2026
Triggered auto assignment to @marcochavezf (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Sep 28, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Sep 28, 2026
@roryabraham @mkhutornyi you have been assigned to this deploy blocker because you reviewed the offending PR: #102267
melvin-bot commentedon Sep 28, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Sep 28, 2026
Deploy Blocker Analysis
Causing PR: Update the accounting software options and switch to a tile layout. Confidence is high.
Root cause: The accounting tiles still use a
RadioButton, but the PR forces a 4px border radius on it (BaseOnboardingAccounting.tsx:183-190).SelectionButtonsets shape only from the radius, so a radio with radius 4 looks exactly like a checkbox (SelectionButton.tsx:132).Recommendation: roll forward with a one-line fix. Don't revert. Reverting would undo a 20-file feature to fix one prop. In
src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx, remove the override and its comment:The mocks show squares, and design never answered the reviewer's question about it. If design wants the square shape, demote this issue instead. It's a cosmetic onboarding issue.
Investigation details
RadioButtonWithLabelwith the default circle. That matches Consistent checkboxes and radio buttons UI: circle for single-select, square for multi-select.SelectionButton,RadioButton,Checkbox, the style variables, orOnboardingAccounting.CONST.ROLE.RADIO, so it should still pass after the fix.variablesis still used elsewhere in the file.Suggested AI code review rule (
app-coding-standards): Flag acontainerBorderRadiuson<RadioButton>unless it's the circle value. Flag a circle radius on<Checkbox>. Search pattern:<(RadioButton|Checkbox)\b[^>]*containerBorderRadius=. The reverse case already exists in SpendRuleListItem.tsx:58-60, where aCheckboxis forced round. A stronger option is to typecontainerBorderRadius?: neveronRadioButtonProps.Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.view run
21 remaining items
melvin-bot commentedon Oct 7, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 7, 2026
Payment Summary
Resolving PRs:
Use the default circle shape for the onboarding accounting radio buttons #102477
Reviewer: @mkhutornyi owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
melvin-bot commentedon Oct 12, 2026
@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?
mallenexpensify commentedon Oct 14, 2026
Payment Summary
Contributor+: @mkhutornyi due $175 via NewDot
trjExpensify commentedon Oct 15, 2026
approved $175 for @mkhutornyi