Skip to content

[Due for payment 2026-10-08] [$175] Onboarding - Accounting tiles use checkbox style button when it does not support multi select #102469

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.95-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #102267
Email or phone of affected tester (no customers): dnjosjdojionjso@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with new Gmail account.
  3. Select Manage my team's expenses.
  4. Proceed to "Do you use any accounting software?" step.

Expected Result:

Accounting tiles will show radio style button for single selection list (according to #87087).

Actual Result:

Accounting tiles use checkbox style button when it does not support multi selection.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7271972_1790631611761.2.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Nathan Lemma
Bug ID: 7271972

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 28, 2026
  2. applause-bot commented on Sep 28, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/2d23da6fd400d805f04f361385ed8150020f872524cb6ef0c5e857afb8dbc4d8

  3. melvin-bot commented on Sep 28, 2026

    @melvin-bot

    @roryabraham recently merged #102267, but they are OOO right now, so I'll auto-assign someone else.

  4. melvin-bot commented on Sep 28, 2026

    @melvin-bot

    Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. github-actions commented on Sep 28, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Sep 28, 2026

    @melvin-bot

    @roryabraham @mkhutornyi you have been assigned to this deploy blocker because you reviewed the offending PR: #102267

  7. melvin-bot commented on Sep 28, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Sep 28, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Causing PR: Update the accounting software options and switch to a tile layout. Confidence is high.

    Root cause: The accounting tiles still use a RadioButton, but the PR forces a 4px border radius on it (BaseOnboardingAccounting.tsx:183-190). SelectionButton sets shape only from the radius, so a radio with radius 4 looks exactly like a checkbox (SelectionButton.tsx:132).

    Recommendation: roll forward with a one-line fix. Don't revert. Reverting would undo a 20-file feature to fix one prop. In src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx, remove the override and its comment:

    -                {/* Square to match the mocks, but a radio because only one option can be picked. */}
                     <RadioButton
                         isChecked={isSelected}
                         onPress={() => handleIntegrationSelect(optionKey)}
                         accessibilityLabel={label}
    -                    containerBorderRadius={variables.componentBorderRadiusSmall}
                         wrapperStyle={styles.onboardingAccountingItemSelectionButton}
                     />

    The mocks show squares, and design never answered the reviewer's question about it. If design wants the square shape, demote this issue instead. It's a cosmetic onboarding issue.

    Investigation details
    • Before this PR, each option was a RadioButtonWithLabel with the default circle. That matches Consistent checkboxes and radio buttons UI: circle for single-select, square for multi-select.
    • Radio and checkbox draw the same filled container and checkmark when checked. The border radius is the only difference (SelectionButton.tsx:197-218, variables.ts:49-56). Screen readers still announce the control as a radio.
    • The reviewer asked design whether the square was intentional (comment). Nobody replied.
    • The other 68 PRs on Deploy Checklist: New Expensify 2026-09-28 don't touch SelectionButton, RadioButton, Checkbox, the style variables, or OnboardingAccounting.
    • The existing UI test queries CONST.ROLE.RADIO, so it should still pass after the fix. variables is still used elsewhere in the file.

    Suggested AI code review rule (app-coding-standards): Flag a containerBorderRadius on <RadioButton> unless it's the circle value. Flag a circle radius on <Checkbox>. Search pattern: <(RadioButton|Checkbox)\b[^>]*containerBorderRadius=. The reverse case already exists in SpendRuleListItem.tsx:58-60, where a Checkbox is forced round. A stronger option is to type containerBorderRadius?: never on RadioButtonProps.


    Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.


    view run

  9. 21 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 7, 2026
  11. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  13. melvin-bot commented on Oct 12, 2026

    @melvin-bot

    @mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

  14. mallenexpensify commented on Oct 14, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @mkhutornyi due $175 via NewDot

  15. trjExpensify commented on Oct 15, 2026

    @trjExpensify
    Contributor

    approved $175 for @mkhutornyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions